New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Mistral AI as a new provider in LLM Deployment #11020
Add Mistral AI as a new provider in LLM Deployment #11020
Conversation
Signed-off-by: Ngo Minh Thang Nguyen <thangnguyen.dn.1991@gmail.com>
Documentation preview for 73a6980 will be available when this CircleCI job completes successfully. More info
|
Hi @thnguyendn great stuff! Could you add an entry in the integration suite for this provider? https://github.com/mlflow/mlflow/blob/master/tests/gateway/test_integration.py |
Signed-off-by: Ngo Minh Thang Nguyen <thangnguyen.dn.1991@gmail.com>
Hi, @BenWilson2 , a new commit has been added to add entry in integration suite for the provider |
Signed-off-by: Ngo Minh Thang Nguyen <thangnguyen.dn.1991@gmail.com>
Hi @BenWilson2 , could you please review the PR? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me with the added test! Thanks for the contribution :)
Are you planning on a follow-up to add the examples and the docs updates?
Signed-off-by: Ngo Minh Thang Nguyen <thangnguyen.dn.1991@gmail.com>
Hi @BenWilson2 , I've just updated docs and add examples for the provider. Can you check it @BenWilson2 ? Are you planning to add the PR in your next patch version 2.10.2 ? |
Signed-off-by: Ben Wilson <39283302+BenWilson2@users.noreply.github.com>
We don't include features with patch releases. This will be included in the 2.11 release of MLflow. Thanks again for the contribution! I'll merge it once CI finishes :) |
Signed-off-by: Ben Wilson <39283302+BenWilson2@users.noreply.github.com>
Signed-off-by: Ngo Minh Thang Nguyen <thangnguyen.dn.1991@gmail.com> Signed-off-by: Ben Wilson <39283302+BenWilson2@users.noreply.github.com> Co-authored-by: Ngo Minh Thang Nguyen <thangnguyen.dn.1991@gmail.com> Co-authored-by: Ben Wilson <39283302+BenWilson2@users.noreply.github.com>
馃洜 DevTools 馃洜
Install mlflow from this PR
Checkout with GitHub CLI
Related Issues/PRs
Resolve #10948
What changes are proposed in this pull request?
Though MLFlow has already proposed Mistral AI as part of Hugging Face TGI, this PR is created to fill the need of having Mistral AI as a new LLM Provider, that could be easier to manage by the centralized endpoint of MLFlow LLM Deployment.
In terms of functionality, the new provider provides an endpoint for completion and another one for embedding, those which correspond to the Mistral AI completion (https://docs.mistral.ai/api/#operation/createChatCompletion) and embedding APIs (https://docs.mistral.ai/api/#operation/createEmbedding).
Technically, the changes in this Pull Request can be found in the following places:
How is this PR tested?
Does this PR require documentation update?
Release Notes
Is this a user-facing change?
What component(s), interfaces, languages, and integrations does this PR affect?
Components
area/artifacts
: Artifact stores and artifact loggingarea/build
: Build and test infrastructure for MLflowarea/deployments
: MLflow Deployments client APIs, server, and third-party Deployments integrationsarea/docs
: MLflow documentation pagesarea/examples
: Example codearea/model-registry
: Model Registry service, APIs, and the fluent client calls for Model Registryarea/models
: MLmodel format, model serialization/deserialization, flavorsarea/recipes
: Recipes, Recipe APIs, Recipe configs, Recipe Templatesarea/projects
: MLproject format, project running backendsarea/scoring
: MLflow Model server, model deployment tools, Spark UDFsarea/server-infra
: MLflow Tracking server backendarea/tracking
: Tracking Service, tracking client APIs, autologgingInterface
area/uiux
: Front-end, user experience, plotting, JavaScript, JavaScript dev serverarea/docker
: Docker use across MLflow's components, such as MLflow Projects and MLflow Modelsarea/sqlalchemy
: Use of SQLAlchemy in the Tracking Service or Model Registryarea/windows
: Windows supportLanguage
language/r
: R APIs and clientslanguage/java
: Java APIs and clientslanguage/new
: Proposals for new client languagesIntegrations
integrations/azure
: Azure and Azure ML integrationsintegrations/sagemaker
: SageMaker integrationsintegrations/databricks
: Databricks integrationsHow should the PR be classified in the release notes? Choose one:
rn/none
- No description will be included. The PR will be mentioned only by the PR number in the "Small Bugfixes and Documentation Updates" sectionrn/breaking-change
- The PR will be mentioned in the "Breaking Changes" sectionrn/feature
- A new user-facing feature worth mentioning in the release notesrn/bug-fix
- A user-facing bug fix worth mentioning in the release notesrn/documentation
- A user-facing documentation change worth mentioning in the release notes