New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove global torch import in llm_inference_utils.py #11115
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: B-Step62 <yuki.watanabe@databricks.com>
Documentation preview for 025b2f9 will be available when this CircleCI job completes successfully. More info
|
github-actions
bot
added
area/build
Build and test infrastructure for MLflow
rn/none
List under Small Changes in Changelogs.
labels
Feb 14, 2024
Signed-off-by: B-Step62 <yuki.watanabe@databricks.com>
Signed-off-by: B-Step62 <yuki.watanabe@databricks.com>
mlflow-automation
requested review from
BenWilson2,
daniellok-db,
harupy,
serena-ruan and
WeichenXu123
and removed request for
mlflow-automation
February 14, 2024 01:39
BenWilson2
approved these changes
Feb 14, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
37 tasks
annzhang-db
pushed a commit
to annzhang-db/mlflow
that referenced
this pull request
Feb 14, 2024
Signed-off-by: B-Step62 <yuki.watanabe@databricks.com>
sateeshmannar
pushed a commit
to StateFarmIns/mlflow
that referenced
this pull request
Feb 20, 2024
Signed-off-by: B-Step62 <yuki.watanabe@databricks.com>
artjen
pushed a commit
to artjen/mlflow
that referenced
this pull request
Mar 26, 2024
Signed-off-by: B-Step62 <yuki.watanabe@databricks.com> Signed-off-by: Arthur Jenoudet <arthur.jenoudet@databricks.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
馃洜 DevTools 馃洜
Install mlflow from this PR
Checkout with GitHub CLI
Related Issues/PRs
Fix test failure
What changes are proposed in this pull request?
mlflow/transformers/llm_inference_utils.py
imports Pytorch globally and caused import error for test environment where Pytorch is not installed. Indeed torch is only used for type annotation, so we can wrap it inTYPE_CHECKING
so it won't be imported at runtime.How is this PR tested?
Langchain CI tests triggered by the dummy commit: https://github.com/mlflow/mlflow/actions/runs/7895154250/job/21547078167?pr=11115
Does this PR require documentation update?
Release Notes
Is this a user-facing change?
What component(s), interfaces, languages, and integrations does this PR affect?
Components
area/artifacts
: Artifact stores and artifact loggingarea/build
: Build and test infrastructure for MLflowarea/deployments
: MLflow Deployments client APIs, server, and third-party Deployments integrationsarea/docs
: MLflow documentation pagesarea/examples
: Example codearea/model-registry
: Model Registry service, APIs, and the fluent client calls for Model Registryarea/models
: MLmodel format, model serialization/deserialization, flavorsarea/recipes
: Recipes, Recipe APIs, Recipe configs, Recipe Templatesarea/projects
: MLproject format, project running backendsarea/scoring
: MLflow Model server, model deployment tools, Spark UDFsarea/server-infra
: MLflow Tracking server backendarea/tracking
: Tracking Service, tracking client APIs, autologgingInterface
area/uiux
: Front-end, user experience, plotting, JavaScript, JavaScript dev serverarea/docker
: Docker use across MLflow's components, such as MLflow Projects and MLflow Modelsarea/sqlalchemy
: Use of SQLAlchemy in the Tracking Service or Model Registryarea/windows
: Windows supportLanguage
language/r
: R APIs and clientslanguage/java
: Java APIs and clientslanguage/new
: Proposals for new client languagesIntegrations
integrations/azure
: Azure and Azure ML integrationsintegrations/sagemaker
: SageMaker integrationsintegrations/databricks
: Databricks integrationsHow should the PR be classified in the release notes? Choose one:
rn/none
- No description will be included. The PR will be mentioned only by the PR number in the "Small Bugfixes and Documentation Updates" sectionrn/breaking-change
- The PR will be mentioned in the "Breaking Changes" sectionrn/feature
- A new user-facing feature worth mentioning in the release notesrn/bug-fix
- A user-facing bug fix worth mentioning in the release notesrn/documentation
- A user-facing documentation change worth mentioning in the release notes