Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix add environment variable to disable mlflow configuring logging on import #11137

Merged
merged 1 commit into from Feb 21, 2024

Conversation

jmahlik
Copy link
Contributor

@jmahlik jmahlik commented Feb 14, 2024

🛠 DevTools 🛠

Open in GitHub Codespaces

Install mlflow from this PR

pip install git+https://github.com/mlflow/mlflow.git@refs/pull/11137/merge

Checkout with GitHub CLI

gh pr checkout 11137

Related Issues/PRs

Resolve #11132

What changes are proposed in this pull request?

Setting MLFLOW_LOGGING_CONFIGURE_LOGGING to false disables mlflow from configuring logging on import, which may not be desired.

How is this PR tested?

Bit hard to write a unit test for this one since it requires importing mlflow again after it's imported so logging has already been configured globally.

Here's an example to test it out:

import os
import logging

# Set this to False to disable logging config from happening on import
os.environ["MLFLOW_LOGGING_CONFIGURE_LOGGING"] = "True"

import mlflow

# The default for mlflow is INFO, but we should be able to override this
logging.basicConfig(level=logging.DEBUG)

mlflow_logger = logging.getLogger("mlflow")
root_logger = logging.getLogger()

# Will have no handlers with False
print(mlflow_logger.handlers)

# Mlflow ignores the logging config so this won't show
mlflow_logger.debug("hello from mlflow")

# But all other loggers pick up the logging config
root_logger.debug("hello from root")

Output with True

[<StreamHandler (NOTSET)>]
DEBUG:root:hello from root

Output with False

[]
DEBUG:mlflow:hello from mlflow
DEBUG:root:hello from root
  • Existing unit/integration tests
  • New unit/integration tests
  • Manual tests

Does this PR require documentation update?

  • No. You can skip the rest of this section.
  • Yes. I've updated:
    • Examples
    • API references
    • Instructions

Release Notes

Is this a user-facing change?

  • No. You can skip the rest of this section.
  • Yes. Give a description of this change to be included in the release notes for MLflow users.

See PR description.

What component(s), interfaces, languages, and integrations does this PR affect?

Components

  • area/artifacts: Artifact stores and artifact logging
  • area/build: Build and test infrastructure for MLflow
  • area/deployments: MLflow Deployments client APIs, server, and third-party Deployments integrations
  • area/docs: MLflow documentation pages
  • area/examples: Example code
  • area/model-registry: Model Registry service, APIs, and the fluent client calls for Model Registry
  • area/models: MLmodel format, model serialization/deserialization, flavors
  • area/recipes: Recipes, Recipe APIs, Recipe configs, Recipe Templates
  • area/projects: MLproject format, project running backends
  • area/scoring: MLflow Model server, model deployment tools, Spark UDFs
  • area/server-infra: MLflow Tracking server backend
  • area/tracking: Tracking Service, tracking client APIs, autologging

Interface

  • area/uiux: Front-end, user experience, plotting, JavaScript, JavaScript dev server
  • area/docker: Docker use across MLflow's components, such as MLflow Projects and MLflow Models
  • area/sqlalchemy: Use of SQLAlchemy in the Tracking Service or Model Registry
  • area/windows: Windows support

Language

  • language/r: R APIs and clients
  • language/java: Java APIs and clients
  • language/new: Proposals for new client languages

Integrations

  • integrations/azure: Azure and Azure ML integrations
  • integrations/sagemaker: SageMaker integrations
  • integrations/databricks: Databricks integrations

How should the PR be classified in the release notes? Choose one:

  • rn/none - No description will be included. The PR will be mentioned only by the PR number in the "Small Bugfixes and Documentation Updates" section
  • rn/breaking-change - The PR will be mentioned in the "Breaking Changes" section
  • rn/feature - A new user-facing feature worth mentioning in the release notes
  • rn/bug-fix - A user-facing bug fix worth mentioning in the release notes
  • rn/documentation - A user-facing documentation change worth mentioning in the release notes

Copy link

github-actions bot commented Feb 14, 2024

Documentation preview for c6964c5 will be available when this CircleCI job
completes successfully.

More info

@github-actions github-actions bot added area/server-infra MLflow Tracking server backend area/tracking Tracking service, tracking client APIs, autologging rn/bug-fix Mention under Bug Fixes in Changelogs. labels Feb 14, 2024
mlflow/__init__.py Outdated Show resolved Hide resolved
@jmahlik jmahlik force-pushed the do-not-configure-logging branch 2 times, most recently from 69fb02f to 1ca8562 Compare February 19, 2024 17:48
@jmahlik
Copy link
Contributor Author

jmahlik commented Feb 19, 2024

Rebased to resolve the conflicts.

… import

Setting MLFLOW_LOGGING_CONFIGURE_LOGGING to false disables mlflow from
configuring logging on import, which may not be desired.

Closes mlflow#11132

Signed-off-by: Justin Mahlik <38999128+jmahlik@users.noreply.github.com>
Copy link
Member

@BenWilson2 BenWilson2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Nice quality of life customization :) Thanks @jmahlik

@BenWilson2 BenWilson2 merged commit 0fd83dd into mlflow:master Feb 21, 2024
37 checks passed
artjen pushed a commit to artjen/mlflow that referenced this pull request Mar 26, 2024
… import (mlflow#11137)

Signed-off-by: Justin Mahlik <38999128+jmahlik@users.noreply.github.com>
artjen pushed a commit to artjen/mlflow that referenced this pull request Mar 26, 2024
… import (mlflow#11137)

Signed-off-by: Justin Mahlik <38999128+jmahlik@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/server-infra MLflow Tracking server backend area/tracking Tracking service, tracking client APIs, autologging rn/bug-fix Mention under Bug Fixes in Changelogs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Logging config is difficult to override
3 participants