New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix add environment variable to disable mlflow configuring logging on import #11137
Merged
BenWilson2
merged 1 commit into
mlflow:master
from
StateFarmIns:do-not-configure-logging
Feb 21, 2024
Merged
Fix add environment variable to disable mlflow configuring logging on import #11137
BenWilson2
merged 1 commit into
mlflow:master
from
StateFarmIns:do-not-configure-logging
Feb 21, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Documentation preview for c6964c5 will be available when this CircleCI job More info
|
github-actions
bot
added
area/server-infra
MLflow Tracking server backend
area/tracking
Tracking service, tracking client APIs, autologging
rn/bug-fix
Mention under Bug Fixes in Changelogs.
labels
Feb 14, 2024
harupy
reviewed
Feb 15, 2024
harupy
reviewed
Feb 15, 2024
jmahlik
force-pushed
the
do-not-configure-logging
branch
2 times, most recently
from
February 19, 2024 17:48
69fb02f
to
1ca8562
Compare
Rebased to resolve the conflicts. |
… import Setting MLFLOW_LOGGING_CONFIGURE_LOGGING to false disables mlflow from configuring logging on import, which may not be desired. Closes mlflow#11132 Signed-off-by: Justin Mahlik <38999128+jmahlik@users.noreply.github.com>
jmahlik
force-pushed
the
do-not-configure-logging
branch
from
February 19, 2024 18:46
1ca8562
to
c6964c5
Compare
BenWilson2
approved these changes
Feb 21, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Nice quality of life customization :) Thanks @jmahlik
artjen
pushed a commit
to artjen/mlflow
that referenced
this pull request
Mar 26, 2024
… import (mlflow#11137) Signed-off-by: Justin Mahlik <38999128+jmahlik@users.noreply.github.com>
artjen
pushed a commit
to artjen/mlflow
that referenced
this pull request
Mar 26, 2024
… import (mlflow#11137) Signed-off-by: Justin Mahlik <38999128+jmahlik@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area/server-infra
MLflow Tracking server backend
area/tracking
Tracking service, tracking client APIs, autologging
rn/bug-fix
Mention under Bug Fixes in Changelogs.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🛠 DevTools 🛠
Install mlflow from this PR
Checkout with GitHub CLI
Related Issues/PRs
Resolve #11132
What changes are proposed in this pull request?
Setting MLFLOW_LOGGING_CONFIGURE_LOGGING to false disables mlflow from configuring logging on import, which may not be desired.
How is this PR tested?
Bit hard to write a unit test for this one since it requires importing mlflow again after it's imported so logging has already been configured globally.
Here's an example to test it out:
Output with True
Output with False
Does this PR require documentation update?
Release Notes
Is this a user-facing change?
See PR description.
What component(s), interfaces, languages, and integrations does this PR affect?
Components
area/artifacts
: Artifact stores and artifact loggingarea/build
: Build and test infrastructure for MLflowarea/deployments
: MLflow Deployments client APIs, server, and third-party Deployments integrationsarea/docs
: MLflow documentation pagesarea/examples
: Example codearea/model-registry
: Model Registry service, APIs, and the fluent client calls for Model Registryarea/models
: MLmodel format, model serialization/deserialization, flavorsarea/recipes
: Recipes, Recipe APIs, Recipe configs, Recipe Templatesarea/projects
: MLproject format, project running backendsarea/scoring
: MLflow Model server, model deployment tools, Spark UDFsarea/server-infra
: MLflow Tracking server backendarea/tracking
: Tracking Service, tracking client APIs, autologgingInterface
area/uiux
: Front-end, user experience, plotting, JavaScript, JavaScript dev serverarea/docker
: Docker use across MLflow's components, such as MLflow Projects and MLflow Modelsarea/sqlalchemy
: Use of SQLAlchemy in the Tracking Service or Model Registryarea/windows
: Windows supportLanguage
language/r
: R APIs and clientslanguage/java
: Java APIs and clientslanguage/new
: Proposals for new client languagesIntegrations
integrations/azure
: Azure and Azure ML integrationsintegrations/sagemaker
: SageMaker integrationsintegrations/databricks
: Databricks integrationsHow should the PR be classified in the release notes? Choose one:
rn/none
- No description will be included. The PR will be mentioned only by the PR number in the "Small Bugfixes and Documentation Updates" sectionrn/breaking-change
- The PR will be mentioned in the "Breaking Changes" sectionrn/feature
- A new user-facing feature worth mentioning in the release notesrn/bug-fix
- A user-facing bug fix worth mentioning in the release notesrn/documentation
- A user-facing documentation change worth mentioning in the release notes