Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Join run and experiment in graphql #11173

Merged

Conversation

edwardfeng-db
Copy link
Collaborator

@edwardfeng-db edwardfeng-db commented Feb 18, 2024

Related Issues/PRs

N/A

What changes are proposed in this pull request?

  • Joining experiment data into MlflowRun Graphql schema type
  • Adding unit test to test the functionality
  • Updating the schema_autogeneration.py logic to use dotted class reference to resolve circular dependency, as documented here

How is this PR tested?

  • Existing unit/integration tests
  • New unit/integration tests
  • Manual tests

Does this PR require documentation update?

  • No. You can skip the rest of this section.
  • Yes. I've updated:
    • Examples
    • API references
    • Instructions

Release Notes

Is this a user-facing change?

  • No. You can skip the rest of this section.
  • Yes. Give a description of this change to be included in the release notes for MLflow users.

What component(s), interfaces, languages, and integrations does this PR affect?

Components

  • area/artifacts: Artifact stores and artifact logging
  • area/build: Build and test infrastructure for MLflow
  • area/deployments: MLflow Deployments client APIs, server, and third-party Deployments integrations
  • area/docs: MLflow documentation pages
  • area/examples: Example code
  • area/model-registry: Model Registry service, APIs, and the fluent client calls for Model Registry
  • area/models: MLmodel format, model serialization/deserialization, flavors
  • area/recipes: Recipes, Recipe APIs, Recipe configs, Recipe Templates
  • area/projects: MLproject format, project running backends
  • area/scoring: MLflow Model server, model deployment tools, Spark UDFs
  • area/server-infra: MLflow Tracking server backend
  • area/tracking: Tracking Service, tracking client APIs, autologging

Interface

  • area/uiux: Front-end, user experience, plotting, JavaScript, JavaScript dev server
  • area/docker: Docker use across MLflow's components, such as MLflow Projects and MLflow Models
  • area/sqlalchemy: Use of SQLAlchemy in the Tracking Service or Model Registry
  • area/windows: Windows support

Language

  • language/r: R APIs and clients
  • language/java: Java APIs and clients
  • language/new: Proposals for new client languages

Integrations

  • integrations/azure: Azure and Azure ML integrations
  • integrations/sagemaker: SageMaker integrations
  • integrations/databricks: Databricks integrations

How should the PR be classified in the release notes? Choose one:

  • rn/none - No description will be included. The PR will be mentioned only by the PR number in the "Small Bugfixes and Documentation Updates" section
  • rn/breaking-change - The PR will be mentioned in the "Breaking Changes" section
  • rn/feature - A new user-facing feature worth mentioning in the release notes
  • rn/bug-fix - A user-facing bug fix worth mentioning in the release notes
  • rn/documentation - A user-facing documentation change worth mentioning in the release notes

Copy link

github-actions bot commented Feb 18, 2024

Documentation preview for 1e8a1b2 will be available when this CircleCI job
completes successfully.

More info

@edwardfeng-db edwardfeng-db marked this pull request as ready for review February 18, 2024 15:39
@edwardfeng-db edwardfeng-db force-pushed the edwardfeng-db/experiment-run-join branch from 1dec840 to d2465e8 Compare February 19, 2024 22:41
Signed-off-by: edwardfeng-db <jinghao.feng@databricks.com>
@edwardfeng-db edwardfeng-db force-pushed the edwardfeng-db/experiment-run-join branch from 028d1a0 to 9328c06 Compare February 19, 2024 22:47
@github-actions github-actions bot added the rn/none List under Small Changes in Changelogs. label Feb 19, 2024
Signed-off-by: edwardfeng-db <jinghao.feng@databricks.com>
Copy link
Member

@harupy harupy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Signed-off-by: edwardfeng-db <jinghao.feng@databricks.com>
@edwardfeng-db edwardfeng-db merged commit 601122d into mlflow:master Feb 20, 2024
37 checks passed
artjen pushed a commit to artjen/mlflow that referenced this pull request Mar 26, 2024
Signed-off-by: edwardfeng-db <jinghao.feng@databricks.com>
Signed-off-by: Arthur Jenoudet <arthur.jenoudet@databricks.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rn/none List under Small Changes in Changelogs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants