Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validate metric key length in _validate_metric #11209

Merged
merged 1 commit into from Feb 21, 2024
Merged

Validate metric key length in _validate_metric #11209

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
8 changes: 2 additions & 6 deletions mlflow/utils/validation.py
View file
Open in desktop
Expand Up @@ -163,6 +163,8 @@ def _validate_metric(key, value, timestamp, step):
INVALID_PARAMETER_VALUE,
)

_validate_length_limit("Metric name", MAX_ENTITY_KEY_LENGTH, key)
Copy link
Member Author

@harupy harupy Feb 21, 2024 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This would break code that logs metrics with key exceeding MAX_ENTITY_KEY_LENGTH (250) characters.



def _validate_param(key, value):
"""
Expand Down Expand Up @@ -315,12 +317,6 @@ def _validate_batch_log_limits(metrics, params, tags):
def _validate_batch_log_data(metrics, params, tags):
for metric in metrics:
_validate_metric(metric.key, metric.value, metric.timestamp, metric.step)
# TODO: move _validate_length_limit calls into _validate_metric etc. This would be a
# breaking change as _validate_metric is also used in the single-entry log_metric API. Thus
# we defer it for now to allow for a release of the batched logging APIs without breaking
# changes to other APIs. See related discussion in
# https://github.com/mlflow/mlflow/issues/985
_validate_length_limit("Metric name", MAX_ENTITY_KEY_LENGTH, metric.key)
Comment on lines -318 to -323
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This comment was added 5 years ago.

for param in params:
_validate_param(param.key, param.value)
for tag in tags:
Expand Down