Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Log table images #11464

Open
wants to merge 40 commits into
base: master
Choose a base branch
from
Open

Log table images #11464

wants to merge 40 commits into from

Conversation

jessechancy
Copy link
Collaborator

@jessechancy jessechancy commented Mar 19, 2024 •
edited by github-actions bot

🛠 DevTools 🛠

Open in GitHub Codespaces

Install mlflow from this PR

pip install git+https://github.com/mlflow/mlflow.git@refs/pull/11464/merge

Checkout with GitHub CLI

gh pr checkout 11464

Related Issues/PRs

#xxx

What changes are proposed in this pull request?

  • Add log_table support for images

How is this PR tested?

  • Existing unit/integration tests
  • New unit/integration tests
  • Manual tests

Does this PR require documentation update?

  • No. You can skip the rest of this section.
  • Yes. I've updated:
    • Examples
    • API references
    • Instructions

Release Notes

Is this a user-facing change?

  • No. You can skip the rest of this section.
  • Yes. Give a description of this change to be included in the release notes for MLflow users.

What component(s), interfaces, languages, and integrations does this PR affect?

Components

  • area/artifacts: Artifact stores and artifact logging
  • area/build: Build and test infrastructure for MLflow
  • area/deployments: MLflow Deployments client APIs, server, and third-party Deployments integrations
  • area/docs: MLflow documentation pages
  • area/examples: Example code
  • area/model-registry: Model Registry service, APIs, and the fluent client calls for Model Registry
  • area/models: MLmodel format, model serialization/deserialization, flavors
  • area/recipes: Recipes, Recipe APIs, Recipe configs, Recipe Templates
  • area/projects: MLproject format, project running backends
  • area/scoring: MLflow Model server, model deployment tools, Spark UDFs
  • area/server-infra: MLflow Tracking server backend
  • area/tracking: Tracking Service, tracking client APIs, autologging

Interface

  • area/uiux: Front-end, user experience, plotting, JavaScript, JavaScript dev server
  • area/docker: Docker use across MLflow's components, such as MLflow Projects and MLflow Models
  • area/sqlalchemy: Use of SQLAlchemy in the Tracking Service or Model Registry
  • area/windows: Windows support

Language

  • language/r: R APIs and clients
  • language/java: Java APIs and clients
  • language/new: Proposals for new client languages

Integrations

  • integrations/azure: Azure and Azure ML integrations
  • integrations/sagemaker: SageMaker integrations
  • integrations/databricks: Databricks integrations

How should the PR be classified in the release notes? Choose one:

  • rn/none - No description will be included. The PR will be mentioned only by the PR number in the "Small Bugfixes and Documentation Updates" section
  • rn/breaking-change - The PR will be mentioned in the "Breaking Changes" section
  • rn/feature - A new user-facing feature worth mentioning in the release notes
  • rn/bug-fix - A user-facing bug fix worth mentioning in the release notes
  • rn/documentation - A user-facing documentation change worth mentioning in the release notes

@jessechancy
log_table supporting images in dictionary and dataframes
69fe972 
Signed-off-by: Jesse Chan <jesse.chan@databricks.com>
@jessechancy
update log_table
5a0488a 
Signed-off-by: Jesse Chan <jesse.chan@databricks.com>
@jessechancy
update error message
cc9e9ef 
Signed-off-by: Jesse Chan <jesse.chan@databricks.com>
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 19, 2024 •
edited

Documentation preview for 944d78f will be available when this CircleCI job
completes successfully.

More info

mlflow-automation and others added 6 commits March 19, 2024 15:12
@mlflow-automation @BenWilson2
Run python3 dev/update_changelog.py --prev-version 2.1... (mlflow#1…
9b959d8 
…1466)

Signed-off-by: mlflow-automation <mlflow-automation@users.noreply.github.com>
Signed-off-by: Ben Wilson <39283302+BenWilson2@users.noreply.github.com>
Co-authored-by: mlflow-automation <mlflow-automation@users.noreply.github.com>
Co-authored-by: Ben Wilson <39283302+BenWilson2@users.noreply.github.com>
@harupy
Simplify _Example.__init__ (mlflow#11459)
7f27559 
Signed-off-by: harupy <17039389+harupy@users.noreply.github.com>
@mlflow-automation
Run python3 dev/update_mlflow_versions.py post-release... (mlflow#1…
2692f35 
…1472)

Signed-off-by: mlflow-automation <mlflow-automation@users.noreply.github.com>
Co-authored-by: mlflow-automation <mlflow-automation@users.noreply.github.com>
@clemenskol
Fix pydantic-v2 model deprecation warning (mlflow#11469) (mlflow#11470)
f588a9b 
Signed-off-by: Clemens Kolbitsch <clemens.kol@gmail.com>
Co-authored-by: Clemens Kolbitsch <clemens.kolbitsch@broadcom.com>
@daniellok-db
Fix URI local path traversal (mlflow#11473)
695d287
@BenWilson2
Fix an issue with chat request validation for LangChain flavor (mlflo…
7d110f7 
…w#11478)

Signed-off-by: Ben Wilson <benjamin.wilson@databricks.com>
chenmoneygithub
chenmoneygithub reviewed Mar 21, 2024
View reviewed changes
Copy link
Collaborator

@chenmoneygithub chenmoneygithub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Jesse, overall looks good! Let's wait for #11404.

mlflow/tracking/client.py
try:
import PIL
except ImportError as exc:
raise ImportError(
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This could lead to strange UX - for users not interested in image logging, they will still hit this code block. We should throw a warning and skip this part instead.

mlflow/tracking/client.py
Comment on lines +1755 to +1761
width, height = image.size
if width > height:
new_width = 256
new_height = int(height * (new_width / width))
else:
new_height = 256
new_width = int(width * (new_height / height))
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I remember you have a function for compressing image?

WeichenXu123 and others added 19 commits March 21, 2024 02:43
@WeichenXu123
Fix databricks runtime checking issue in databricks DCS cluster (mlfl…
fe3cea5 
…ow#11483)

Signed-off-by: Weichen Xu <weichen.xu@databricks.com>
@victorsun123 @dbczumar
Fix for get_databricks_host_creds in Model Serving Environment (mlf…
d063072 
…low#11468)

Signed-off-by: Victor <victor7sun@gmail.com>
Signed-off-by: dbczumar <corey.zumar@databricks.com>
Co-authored-by: dbczumar <corey.zumar@databricks.com>
@daniellok-db
Disallow % in model names (mlflow#11474)
a924d12 
Signed-off-by: Daniel Lok <daniel.lok@databricks.com>
@sunishsheth2009 @mlflow-automation
Deleting the global context for config path in langchain (mlflow#11494)
a391a02 
Signed-off-by: Sunish Sheth <sunishsheth2009@gmail.com>
Signed-off-by: mlflow-automation <mlflow-automation@users.noreply.github.com>
Co-authored-by: mlflow-automation <mlflow-automation@users.noreply.github.com>
@mlflow-automation @BenWilson2
Run python3 dev/update_changelog.py --prev-version 2.1... (mlflow#1…
598f373 
…1495)

Signed-off-by: mlflow-automation <mlflow-automation@users.noreply.github.com>
Signed-off-by: Ben Wilson <39283302+BenWilson2@users.noreply.github.com>
Co-authored-by: mlflow-automation <mlflow-automation@users.noreply.github.com>
Co-authored-by: Ben Wilson <39283302+BenWilson2@users.noreply.github.com>
@B-Step62
Fix Tensorflow cross-version test (mlflow#11489)
94c503f 
Signed-off-by: B-Step62 <yuki.watanabe@databricks.com>
@mlflow-automation
Run python3 dev/update_mlflow_versions.py post-release... (mlflow#1…
c8963fe 
…1498)

Signed-off-by: mlflow-automation <mlflow-automation@users.noreply.github.com>
Co-authored-by: mlflow-automation <mlflow-automation@users.noreply.github.com>
@harupy
Pin transformers for tensorflow 2.15.1 (mlflow#11500)
015de01 
Signed-off-by: harupy <17039389+harupy@users.noreply.github.com>
@harupy
Fix get_feature_cols for dev version spark (mlflow#11501)
c2cc781 
Signed-off-by: harupy <17039389+harupy@users.noreply.github.com>
Signed-off-by: Harutaka Kawamura <hkawamura0130@gmail.com>
@B-Step62
Avoid input example conversion for llm/v1/xxx task in Transformer fla…
fddd4f5 
…vor (mlflow#11508)

Signed-off-by: B-Step62 <yuki.watanabe@databricks.com>
@harupy
Fix proto autoformatting (mlflow#11457)
0a5a74e 
Signed-off-by: harupy <17039389+harupy@users.noreply.github.com>
@serena-ruan
Improve langchain model saving error message (mlflow#11511)
4c03ef1 
Signed-off-by: Serena Ruan <serena.rxy@gmail.com>
@fzyzcjy
Tiny fix doc about uniqueness (mlflow#11502)
d55df6c 
Signed-off-by: fzyzcjy <5236035+fzyzcjy@users.noreply.github.com>
@harupy
Fix test_disable_sklearn_autologging_does_not_revert_with_trainer (m…
f490387 
…lflow#11509)

Signed-off-by: harupy <17039389+harupy@users.noreply.github.com>
@B-Step62
Fix Transformers task inference for local custom code with llm v1 task (
2502703 
mlflow#11510)

Signed-off-by: B-Step62 <yuki.watanabe@databricks.com>
@harupy
Skip release frequency check for CRAN (mlflow#11513)
ba4370c 
Signed-off-by: harupy <17039389+harupy@users.noreply.github.com>
@ernestwong-db
[ML-35177] Move the new "deprecated" decorator to mlflow (mlflow#11506)
86291b0 
Signed-off-by: ernestwong-db <ernest.wong@databricks.com>
@harupy
Set PYTHONUTF8 to enable UTF-8 encoding by default for Windows (mlf…
3a93ccf 
…low#11514)

Signed-off-by: harupy <17039389+harupy@users.noreply.github.com>
@taranarmo
add docstring to lifecycle_stage property (mlflow#11463)
310a73f 
Signed-off-by: Sergey Volkov <taranarmo@gmail.com>
B-Step62 and others added 12 commits March 26, 2024 13:13
@B-Step62
Minor updates to Transformers llm inference task doc (mlflow#11517)
76228c2 
Signed-off-by: B-Step62 <yuki.watanabe@databricks.com>
@chenmoneygithub
Lift the DBR check when logging Delta table to MLflow (mlflow#11521)
f1d9565 
Signed-off-by: chenmoneygithub <chen.qian@databricks.com>
@harupy
Pin huggingface-hub (mlflow#11525)
1b9facc 
Signed-off-by: harupy <17039389+harupy@users.noreply.github.com>
@serena-ruan
Improve langchain runnable save exception handling (mlflow#11516)
42936f0 
Signed-off-by: Serena Ruan <serena.rxy@gmail.com>
@harupy
Test dev version of openai (mlflow#11528)
83b6c5f 
Signed-off-by: harupy <17039389+harupy@users.noreply.github.com>
@harupy
Replace return with yield in databricks_artifact_repo fixture (m…
da9fafb 
…lflow#11532)

Signed-off-by: harupy <17039389+harupy@users.noreply.github.com>
@daniellok-db
Fix sampling logic in GetSampledHistoryBulkInterval (mlflow#11475)
a983c24
@jessechancy @BenWilson2
Log image optimization (mlflow#11404)
e1d5903 
Signed-off-by: Jesse Chan <jesse.chan@databricks.com>
Signed-off-by: Jesse Chan <jessechanwork@gmail.com>
Co-authored-by: Ben Wilson <39283302+BenWilson2@users.noreply.github.com>
@jessechancy
log_table supporting images in dictionary and dataframes
5dd7247 
Signed-off-by: Jesse Chan <jesse.chan@databricks.com>
@jessechancy
update log_table
76a2249 
Signed-off-by: Jesse Chan <jesse.chan@databricks.com>
@jessechancy
update error message
6aa2b69 
Signed-off-by: Jesse Chan <jesse.chan@databricks.com>
@jessechancy
Merge branch 'log_table_images' of https://github.com/jessechancy/mlflow
944d78f 
 into log_table_images
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chenmoneygithub chenmoneygithub chenmoneygithub left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet