Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Delete runs API #11519

Open
wants to merge 38 commits into
base: master
Choose a base branch
from
Open

Add Delete runs API #11519

wants to merge 38 commits into from

Conversation

natannvw
Copy link

@natannvw natannvw commented Mar 25, 2024 •
edited by WeichenXu123

🛠 DevTools 🛠

Open in GitHub Codespaces

Install mlflow from this PR

pip install git+https://github.com/mlflow/mlflow.git@refs/pull/11519/merge

Checkout with GitHub CLI

gh pr checkout 11519

Related Issues/PRs

#xxx

What changes are proposed in this pull request?

Add "delete runs" (batched deletion) API.

How is this PR tested?

  • Existing unit/integration tests
  • New unit/integration tests
  • Manual tests

Does this PR require documentation update?

  • No. You can skip the rest of this section.
  • Yes. I've updated:
    • Examples
    • API references
    • Instructions

Release Notes

Is this a user-facing change?

  • No. You can skip the rest of this section.
  • Yes. Give a description of this change to be included in the release notes for MLflow users.

What component(s), interfaces, languages, and integrations does this PR affect?

Add "delete runs" (batched deletion) API.

Components

  • area/artifacts: Artifact stores and artifact logging
  • area/build: Build and test infrastructure for MLflow
  • area/deployments: MLflow Deployments client APIs, server, and third-party Deployments integrations
  • area/docs: MLflow documentation pages
  • area/examples: Example code
  • area/model-registry: Model Registry service, APIs, and the fluent client calls for Model Registry
  • area/models: MLmodel format, model serialization/deserialization, flavors
  • area/recipes: Recipes, Recipe APIs, Recipe configs, Recipe Templates
  • area/projects: MLproject format, project running backends
  • area/scoring: MLflow Model server, model deployment tools, Spark UDFs
  • area/server-infra: MLflow Tracking server backend
  • area/tracking: Tracking Service, tracking client APIs, autologging

Interface

  • area/uiux: Front-end, user experience, plotting, JavaScript, JavaScript dev server
  • area/docker: Docker use across MLflow's components, such as MLflow Projects and MLflow Models
  • area/sqlalchemy: Use of SQLAlchemy in the Tracking Service or Model Registry
  • area/windows: Windows support

Language

  • language/r: R APIs and clients
  • language/java: Java APIs and clients
  • language/new: Proposals for new client languages

Integrations

  • integrations/azure: Azure and Azure ML integrations
  • integrations/sagemaker: SageMaker integrations
  • integrations/databricks: Databricks integrations

How should the PR be classified in the release notes? Choose one:

  • rn/none - No description will be included. The PR will be mentioned only by the PR number in the "Small Bugfixes and Documentation Updates" section
  • rn/breaking-change - The PR will be mentioned in the "Breaking Changes" section
  • rn/feature - A new user-facing feature worth mentioning in the release notes
  • rn/bug-fix - A user-facing bug fix worth mentioning in the release notes
  • rn/documentation - A user-facing documentation change worth mentioning in the release notes

@github-actions GitHub Actions
Copy link

@natannvw Thank you for the contribution! Could you fix the following issue(s)?

⚠ DCO check

The DCO check failed. Please sign off your commit(s) by following the instructions here. See https://github.com/mlflow/mlflow/blob/master/CONTRIBUTING.md#sign-your-work for more details.

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 25, 2024 •
edited

Documentation preview for 32146c5 will be available when this CircleCI job
completes successfully.

More info

@natannvw natannvw mentioned this pull request Mar 25, 2024
Open
22 tasks
@WeichenXu123
Copy link
Collaborator

WeichenXu123 commented Mar 26, 2024 •
edited

Please add unit tests for filestore / SQL alchemy / reststore backends.

WeichenXu123
WeichenXu123 reviewed Mar 28, 2024
View reviewed changes
Copy link
Collaborator

@WeichenXu123 WeichenXu123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a new comment, otherwise good to me

@WeichenXu123 WeichenXu123 changed the title Delete runs Add Delete runs API Mar 28, 2024
@WeichenXu123
Copy link
Collaborator

Please fill the PR description too.

natannvw and others added 3 commits March 31, 2024 09:56
@natannvw
changed run_id to run_ids in message DeleteRuns
bfec7a9
@natannvw @WeichenXu123
Update mlflow/protos/service.proto
d27c486 
Co-authored-by: WeichenXu <weichen.xu@databricks.com>
Signed-off-by: natannvw <69158504+natannvw@users.noreply.github.com>
@natannvw
Merge branch 'delete-runs' of https://github.com/natannvw/mlflow into…
dc5b205 
… delete-runs
@natannvw
Copy link
Author

Refere

Couldn't find it. When I press on the Edit it only opens the title edit.

@github-actions github-actions bot added area/tracking Tracking service, tracking client APIs, autologging rn/feature Mention under Features in Changelogs. labels Apr 1, 2024
@WeichenXu123
Copy link
Collaborator

Refere

Couldn't find it. When I press on the Edit it only opens the title edit.

I help you edited it. Could you fix all failed tests ?

natannvw and others added 19 commits April 1, 2024 08:44
@natannvw
ruff
4e16b93
@ernestwong-db @natannvw
[ML-35177] Move the new "deprecated" decorator to mlflow (mlflow#11506)
062ba45 
Signed-off-by: ernestwong-db <ernest.wong@databricks.com>
Signed-off-by: Nathan <natannvw@gmail.com>
@harupy @natannvw
Set PYTHONUTF8 to enable UTF-8 encoding by default for Windows (mlf…
6a06b17 
…low#11514)

Signed-off-by: harupy <17039389+harupy@users.noreply.github.com>
Signed-off-by: Nathan <natannvw@gmail.com>
@taranarmo @natannvw
add docstring to lifecycle_stage property (mlflow#11463)
8387e25 
Signed-off-by: Sergey Volkov <taranarmo@gmail.com>
Signed-off-by: Nathan <natannvw@gmail.com>
@natannvw
added delete_runs()
d352ddd 
Signed-off-by: Nathan <natannvw@gmail.com>
@natannvw
update import
540fbfd 
Signed-off-by: Nathan <natannvw@gmail.com>
@natannvw
added try except in delete_runs()
b765e95 
Signed-off-by: Nathan <natannvw@gmail.com>
@natannvw
change to in_() in delete_runs()
72149bb 
Signed-off-by: Nathan <natannvw@gmail.com>
@natannvw
add new proto DeleteRuns
bcb57e4 
Signed-off-by: Nathan <natannvw@gmail.com>
@natannvw
add new proto DeleteRuns
d1a6416 
Signed-off-by: Nathan <natannvw@gmail.com>
@natannvw
add _delete_runs()
542fcbc 
Signed-off-by: Nathan <natannvw@gmail.com>
@natannvw
add _assert_list_of_strings()
90fd644 
Signed-off-by: Nathan <natannvw@gmail.com>
@natannvw
import new proto DeleteRuns
33bd4db 
Signed-off-by: Nathan <natannvw@gmail.com>
@natannvw
modify delete_runs() to use DeleteRuns()
c49dfd8 
Signed-off-by: Nathan <natannvw@gmail.com>
@natannvw
added delete_runs()
1272442 
Signed-off-by: Nathan <natannvw@gmail.com>
@natannvw
added tests for delete_runs()
3913e07 
Signed-off-by: Nathan <natannvw@gmail.com>
@natannvw
changed run_id to run_ids in message DeleteRuns
7bd2276 
Signed-off-by: Nathan <natannvw@gmail.com>
@natannvw
ruff
dd97132 
Signed-off-by: Nathan <natannvw@gmail.com>
@natannvw
Merge branch 'delete-runs' of https://github.com/natannvw/mlflow into…
32146c5 
… delete-runs
@WeichenXu123
Copy link
Collaborator

Your PR includes commits from other persons, could you remove unrelated commit history in the PR ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WeichenXu123 WeichenXu123 WeichenXu123 left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
area/tracking Tracking service, tracking client APIs, autologging rn/feature Mention under Features in Changelogs.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@natannvw @WeichenXu123 @ernestwong-db @harupy @taranarmo