New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversational LangChain model support #11552
base: master
Are you sure you want to change the base?
Conversational LangChain model support #11552
Conversation
Documentation preview for a92b8f9 will be available when this CircleCI job More info
|
48dabae
to
8cf51c3
Compare
@ishaan-mehta Thank you so much for your contribution!! Adding |
78a8369
to
a835048
Compare
Hi @B-Step62 — glad to help, and thanks for taking a look here! A couple thoughts:
|
@ishaan-mehta Thank you so much for the explanation! I've overlooked that the condition check is in prediction function, and that makes sense to remove the limitation then🙂 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall change looks good to me, thank you so much for the contribution!
A few requests:
- Could you run the pre-commit hook to format the code? you can run it by
pre-commit run --all-files
and it'll automatically update the files. - Could you add tests for (1) pass configurable as prediction parameter (2) run prediction with
RunnableWithMessageHistory
?
cc: @serena-ruan as SME
747aac1
to
3c8ad84
Compare
Hi @B-Step62, I've addressed your comments, added a test that addresses prediction with a |
Signed-off-by: Ishaan Mehta <45380942+ishaan-mehta@users.noreply.github.com>
Signed-off-by: Ishaan Mehta <45380942+ishaan-mehta@users.noreply.github.com>
Signed-off-by: Ishaan Mehta <45380942+ishaan-mehta@users.noreply.github.com>
Signed-off-by: Ishaan Mehta <45380942+ishaan-mehta@users.noreply.github.com>
Signed-off-by: Ishaan Mehta <45380942+ishaan-mehta@users.noreply.github.com>
Signed-off-by: Ishaan Mehta <45380942+ishaan-mehta@users.noreply.github.com>
Signed-off-by: Ishaan Mehta <45380942+ishaan-mehta@users.noreply.github.com>
4a658af
to
a92b8f9
Compare
@ishaan-mehta could you do a rebase to master? Let's see if we can get this merged in :) |
Related Issues/PRs
#xxxWhat changes are proposed in this pull request?
Adds support for conversational LangChain models (such as
RunnableWithMessageHistory
) by passing configurables to model invocation and callinginvoke
instead__call__
for all models.Adds check to ensure signature is not inferred from
lc_model
passed as astr
.How is this PR tested?
Does this PR require documentation update?
Release Notes
Is this a user-facing change?
Added support for prediction with any LangChain model loaded as a
python_function
(pyfunc
) instead of select types. Added support for passingconfigurable
fields toRunnable
LangChain models loaded as apython_function
(pyfunc
).What component(s), interfaces, languages, and integrations does this PR affect?
Components
area/artifacts
: Artifact stores and artifact loggingarea/build
: Build and test infrastructure for MLflowarea/deployments
: MLflow Deployments client APIs, server, and third-party Deployments integrationsarea/docs
: MLflow documentation pagesarea/examples
: Example codearea/model-registry
: Model Registry service, APIs, and the fluent client calls for Model Registryarea/models
: MLmodel format, model serialization/deserialization, flavorsarea/recipes
: Recipes, Recipe APIs, Recipe configs, Recipe Templatesarea/projects
: MLproject format, project running backendsarea/scoring
: MLflow Model server, model deployment tools, Spark UDFsarea/server-infra
: MLflow Tracking server backendarea/tracking
: Tracking Service, tracking client APIs, autologgingInterface
area/uiux
: Front-end, user experience, plotting, JavaScript, JavaScript dev serverarea/docker
: Docker use across MLflow's components, such as MLflow Projects and MLflow Modelsarea/sqlalchemy
: Use of SQLAlchemy in the Tracking Service or Model Registryarea/windows
: Windows supportLanguage
language/r
: R APIs and clientslanguage/java
: Java APIs and clientslanguage/new
: Proposals for new client languagesIntegrations
integrations/azure
: Azure and Azure ML integrationsintegrations/sagemaker
: SageMaker integrationsintegrations/databricks
: Databricks integrationsHow should the PR be classified in the release notes? Choose one:
rn/none
- No description will be included. The PR will be mentioned only by the PR number in the "Small Bugfixes and Documentation Updates" sectionrn/breaking-change
- The PR will be mentioned in the "Breaking Changes" sectionrn/feature
- A new user-facing feature worth mentioning in the release notesrn/bug-fix
- A user-facing bug fix worth mentioning in the release notesrn/documentation
- A user-facing documentation change worth mentioning in the release notes