Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MLflow] Removing adding Vector search endpoint dependencies as resources #11918

Merged
merged 1 commit into from
May 7, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion mlflow/langchain/databricks_dependencies.py
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,6 @@ def _extract_databricks_dependencies_from_retriever(
dependency_dict[_DATABRICKS_VECTOR_SEARCH_INDEX_NAME_KEY].append(index.name)
dependency_dict[_DATABRICKS_VECTOR_SEARCH_ENDPOINT_NAME_KEY].append(index.endpoint_name)
dependency_list.append(DatabricksVectorSearchIndex(index_name=index.name))
dependency_list.append(DatabricksServingEndpoint(endpoint_name=index.endpoint_name))

embeddings = getattr(vectorstore, "embeddings", None)
if isinstance(embeddings, (DatabricksEmbeddings, LegacyDatabricksEmbeddings)):
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,6 @@ def test_parsing_dependency_from_databricks_retriever(monkeypatch: pytest.Monkey
assert d.get(_DATABRICKS_VECTOR_SEARCH_ENDPOINT_NAME_KEY) == ["dbdemos_vs_endpoint"]
assert resources == [
DatabricksVectorSearchIndex(index_name="mlflow.rag.vs_index"),
DatabricksServingEndpoint(endpoint_name="dbdemos_vs_endpoint"),
DatabricksServingEndpoint(endpoint_name="databricks-bge-large-en"),
]

Expand Down Expand Up @@ -142,7 +141,6 @@ def test_parsing_dependency_from_databricks_retriever(monkeypatch: pytest.Monkey
assert d.get(_DATABRICKS_VECTOR_SEARCH_ENDPOINT_NAME_KEY) == ["dbdemos_vs_endpoint"]
assert resources == [
DatabricksVectorSearchIndex(index_name="mlflow.rag.vs_index"),
DatabricksServingEndpoint(endpoint_name="dbdemos_vs_endpoint"),
DatabricksServingEndpoint(endpoint_name="databricks-bge-large-en"),
]

Expand Down
Loading