Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Autogenerate CLI docs #1231

Merged
merged 5 commits into from May 10, 2019
Merged

Autogenerate CLI docs #1231

merged 5 commits into from May 10, 2019

Conversation

sueann
Copy link
Contributor

@sueann sueann commented May 9, 2019

What changes are proposed in this pull request?

Added a library to autogenerate CLI docs from CLI docstrings. If this looks okay I will revamp the CLI docstrings with material from the original cli.rst doc (didn't want to do this work prematurely).

How is this patch tested?

make livehtml

and inspect the CLI page

Release Notes

Is this a user-facing change?

  • No. You can skip the rest of this section.
  • Yes. Give a description of this change to be included in the release notes for MLflow users.

Revamped the CLI docs page to show all commands and options.

What component(s) does this PR affect?

  • CLI
  • Docs

How should the PR be classified in the release notes? Choose one:

  • rn/documentation

@sueann sueann added the rn/documentation Mention under Documentation Changes in Changelogs. label May 9, 2019
@sueann sueann requested a review from a user May 9, 2019 16:57
scipy
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

??

artifact location. Command takes a required argument for experiment ID. Command will thrown
an error if experiment is not found or already marked for deletion.

Experiments marked for deletion can be restored using ``restore`` command, unless they are
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should avoid losing some of these docs which are not in the CLI today. Specifically, for delete we currently refer to restore_experiment in the CLI docs (which doesn't exist) and don't mention the implementation of deletion stores. Mind adding these to the CLI?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah the plan was to add stuff from the old version of cli.rst into the CLI docstrings if we were okay with this autogen route (didn't want to do the work prematurely :P)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good so far!

option. If not provided, backend store will pick default location. Backend store will generate a
unique ID for each experiment.

All artifacts generated by runs related to this experiment will be stored under artifact location,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similarly to the comment below regarding delete, it may be good to retain this comment and the one below

@aarondav
Copy link
Contributor

aarondav commented May 9, 2019

Looks good! Is there a way to hide things? e.g., this is not very useful:

image

@sueann
Copy link
Contributor Author

sueann commented May 9, 2019

yeah... not sure of a quick way to hide things but will look briefly

@sueann sueann changed the title [RFC] Autogenerate CLI docs Autogenerate CLI docs May 10, 2019
@aarondav aarondav added the LGTM label May 10, 2019
@aarondav
Copy link
Contributor

LGTM!

@aarondav aarondav merged commit 49ab1dd into mlflow:master May 10, 2019
avflor pushed a commit to avflor/mlflow that referenced this pull request Aug 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
LGTM rn/documentation Mention under Documentation Changes in Changelogs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants