Added fit_generator hooks for autolog #1757
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the patch! Looks like this is causing some existing tests to fail though. Can you fix those, and also add tests that directly cover fit_generator? |
|
I fixed the failing tests. In my virtual env, some small and some large tests are still failing, but the same ones as in master. |
smurching
reviewed
Aug 23, 2019
|
|
||
| return client.get_run(run.info.run_id) | ||
|
|
||
|
|
||
| @pytest.mark.large | ||
| @pytest.mark.parametrize('fit_variant', ['fit', 'fit_generator']) |
There was a problem hiding this comment.
Nice, could we also add this parametrization to test_keras_autolog_model_can_load_from_artifact so that we have test coverage verifying that autologging logs a model when fit_generator is used?
smurching
approved these changes
Aug 23, 2019
|
Done |
ustcscgyer
pushed a commit
to ustcscgyer/mlflow
that referenced
this pull request
Sep 5, 2019
Keras autolog hooks now work when using model.fit_generator, not just model.fit.
22 tasks
22 tasks
avflor
pushed a commit
to avflor/mlflow
that referenced
this pull request
Aug 22, 2020
Keras autolog hooks now work when using model.fit_generator, not just model.fit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes are proposed in this pull request?
When using keras fit_generator instead it fit, the callback hooks are currently not installed. This patch fixes it.
How is this patch tested?
Only by running it on my data. I wasn't able to run the test_keras_autolog.py without errors on master with reasonable effort yet.
Release Notes
Is this a user-facing change?
Keras autolog hooks now work when using model.fit_generator, not just model.fit.
(Details in 1-2 sentences. You can just refer to another PR with a description if this PR is part of a larger change.)
What component(s) does this PR affect?
How should the PR be classified in the release notes? Choose one:
rn/breaking-change- The PR will be mentioned in the "Breaking Changes" sectionrn/none- No description will be included. The PR will be mentioned only by the PR number in the "Small Bugfixes and Documentation Updates" sectionrn/feature- A new user-facing feature worth mentioning in the release notesrn/bug-fix- A user-facing bug fix worth mentioning in the release notesrn/documentation- A user-facing documentation change worth mentioning in the release notes