[mlflow/R] Retry 429s in R's res client. #1851
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smurching
reviewed
Sep 17, 2019
| x <- mlflow_rest(client = client, max_rate_limit_interval = 2) | ||
| expect_equal(x$text, "text") | ||
| next_id <<- 1 | ||
| x <- mlflow_rest(client = client, max_rate_limit_interval = 2) |
There was a problem hiding this comment.
Nit: Looks like we test the exact same behavior twice? i.e.
x <- mlflow_rest(client = client, max_rate_limit_interval = 2)
expect_equal(x$text, "text")
next_id <<- 1
is repeated
There was a problem hiding this comment.
There is a slight difference, the first call does not reset nex_id so only the first call returns 429, the second call returns 200. Not sure if we need this as a separate test case though.
Codecov Report
@@ Coverage Diff @@
## master #1851 +/- ##
==========================================
+ Coverage 83% 83.25% +0.25%
==========================================
Files 20 20
Lines 1000 1009 +9
==========================================
+ Hits 830 840 +10
+ Misses 170 169 -1
Continue to review full report at Codecov.
|
avflor
pushed a commit
to avflor/mlflow
that referenced
this pull request
Aug 22, 2020
* Added retries for 429s in the R REST client and a test. * Added retries of 429s to R client. * nit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes are proposed in this pull request?
Similarly to other clients, R should retry 429s.
How is this patch tested?
Unit test.
Release Notes
Rest client in R will now retry 429 codes (rate limit exceeded) with an exponential backoff.
Is this a user-facing change?
(Details in 1-2 sentences. You can just refer to another PR with a description if this PR is part of a larger change.)
What component(s) does this PR affect?
How should the PR be classified in the release notes? Choose one:
rn/breaking-change- The PR will be mentioned in the "Breaking Changes" sectionrn/none- No description will be included. The PR will be mentioned only by the PR number in the "Small Bugfixes and Documentation Updates" sectionrn/feature- A new user-facing feature worth mentioning in the release notesrn/bug-fix- A user-facing bug fix worth mentioning in the release notesrn/documentation- A user-facing documentation change worth mentioning in the release notes