Log project backend for local runs with no environment #2207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smurching
reviewed
Dec 16, 2019
There was a problem hiding this comment.
Looks good! Thanks for adding a test verifying tags logged for conda environments, let's also update the docker project test to verify that the "local" tag is still logged?
smurching
approved these changes
Dec 17, 2019
lorenzwalthert
pushed a commit
to lorenzwalthert/mlflow
that referenced
this pull request
Jan 4, 2020
* Implement the fix * Add a small test * Docker test * Projects conda * Revert utils
avflor
pushed a commit
to avflor/mlflow
that referenced
this pull request
Aug 22, 2020
* Implement the fix * Add a small test * Docker test * Projects conda * Revert utils
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes are proposed in this pull request?
While reviewing #2202, I discovered that the
mlflow.project.backendtag is not currently being set when using thelocalbackend without a conda or docker environment. This PR fixes the issue and expands test coverage to ensure that the correct backend and environment tags are logged for thedocker,conda, andno environmentcasesHow is this patch tested?
(Details)
Release Notes
Is this a user-facing change?
What component(s) does this PR affect?
How should the PR be classified in the release notes? Choose one:
rn/breaking-change- The PR will be mentioned in the "Breaking Changes" sectionrn/none- No description will be included. The PR will be mentioned only by the PR number in the "Small Bugfixes and Documentation Updates" sectionrn/feature- A new user-facing feature worth mentioning in the release notesrn/bug-fix- A user-facing bug fix worth mentioning in the release notesrn/documentation- A user-facing documentation change worth mentioning in the release notes