Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix protobuf generation #2358

Merged
merged 5 commits into from Feb 7, 2020
Merged

Fix protobuf generation #2358

merged 5 commits into from Feb 7, 2020

Conversation

jcuquemelle
Copy link
Contributor

@jcuquemelle jcuquemelle commented Jan 29, 2020 •
edited

What changes are proposed in this pull request?

proto generation has been silently broken, as the test doesn't fail if protobufs have not been changed

at the end of the python small test, the test-generate-proto fails without breaking Travis

./test-generate-protos.sh
+++protoc --version
++PROTOC_VERSION='libprotoc 3.6.0'
++'[' 'libprotoc 3.6.0' '!=' 'libprotoc 3.6.0'
generate-protos.sh: line 5: [: missing `]'
++'libprotoc 3.6.0' '!=' 'libprotoc 3.6.1' ']'
generate-protos.sh: line 5: libprotoc 3.6.0: command not found

How is this patch tested?

proto generation works in Travis test

dbczumar
dbczumar approved these changes Feb 6, 2020
View reviewed changes
Copy link
Collaborator

@dbczumar dbczumar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @jcuquemelle

@dbczumar dbczumar merged commit 9fb84b1 into mlflow:master Feb 7, 2020
@smurching smurching added the rn/none List under Small Changes in Changelogs. label Mar 2, 2020
avflor pushed a commit to avflor/mlflow that referenced this pull request Aug 22, 2020
@jcuquemelle
Fix protobuf generation (mlflow#2358)
9322dee 
* fix protobuf generation

* fix proto generation (2nd try)

* fix proto generation (fix travis test)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dbczumar dbczumar dbczumar approved these changes

Assignees
No one assigned
Labels
rn/none List under Small Changes in Changelogs.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jcuquemelle @dbczumar @smurching