Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regenerate r doc and avoid R CMD check error #2553

Merged
merged 2 commits into from Mar 17, 2020

Conversation

lorenzwalthert
Copy link
Contributor

@lorenzwalthert lorenzwalthert commented Mar 5, 2020

What changes are proposed in this pull request?

Regenerate R doc according to CONTRIBUTING.md. Otherwise, new PRs that regenerate R documentation will fail because the current HEAD state is inconsistent. One roxygen comment to document internal function was turned into a normal comment to avoid R CMD check error due to incompleteness.

How is this patch tested?

None.

Release Notes

Is this a user-facing change?

  • No. You can skip the rest of this section.
  • Yes. Give a description of this change to be included in the release notes for MLflow users.

(Details in 1-2 sentences. You can just refer to another PR with a description if this PR is part of a larger change.)

What component(s) does this PR affect?

  • UI
  • CLI
  • API
  • REST-API
  • Examples
  • Docs
  • Tracking
  • Projects
  • Artifacts
  • Models
  • Scoring
  • Serving
  • R
  • Java
  • Python

How should the PR be classified in the release notes? Choose one:

  • rn/breaking-change - The PR will be mentioned in the "Breaking Changes" section
  • rn/none - No description will be included. The PR will be mentioned only by the PR number in the "Small Bugfixes and Documentation Updates" section
  • rn/feature - A new user-facing feature worth mentioning in the release notes
  • rn/bug-fix - A user-facing bug fix worth mentioning in the release notes
  • rn/documentation - A user-facing documentation change worth mentioning in the release notes

Copy link
Contributor

@tomasatdatabricks tomasatdatabricks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution!

@tomasatdatabricks tomasatdatabricks merged commit 3dd46c6 into mlflow:master Mar 17, 2020
@lorenzwalthert lorenzwalthert deleted the fix-rdoc branch March 18, 2020 06:39
@arjundc-db arjundc-db added the rn/none List under Small Changes in Changelogs. label Apr 16, 2020
avflor pushed a commit to avflor/mlflow that referenced this pull request Aug 22, 2020
* making roxygen comment a normal comment to avoid R CMD check failure due to noncomplete internal doc.

Also, then simply regenerating docs.

* add missing namespace prefix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rn/none List under Small Changes in Changelogs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants