Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding DatabricksArtifactRepository to the MLflow client. #2911

Merged
merged 34 commits into from Jun 16, 2020
Merged

Adding DatabricksArtifactRepository to the MLflow client. #2911

Show file tree
Hide file tree
Changes from 26 commits
Commits
Show all changes
34 commits
Select commit Hold shift + click to select a range
e63182b
Add protos and compilation
dbczumar May 12, 2020
cb69e26
Adding databricks_artifact_repo to store/artifact
arjundc-db May 19, 2020
3af5d3b
Addressing comments
arjundc-db May 19, 2020
38630d3
Addressing comments and fixing _download_file
arjundc-db May 20, 2020
1cb98e9
Code Clean-up and lint
arjundc-db May 20, 2020
870c0aa
Adding multi-part upload logic and unit tests
arjundc-db May 22, 2020
10cf458
Addressing comments
arjundc-db May 26, 2020
ecdce6a
Addressing comments, making azure download more memory efficent and o…
arjundc-db May 27, 2020
116c5d0
Small fix
arjundc-db May 27, 2020
11be341
Fixing list_artifacts
arjundc-db May 28, 2020
0609a5b
Addressing final comments.
arjundc-db Jun 1, 2020
3f1327d
Making extract_run_id static
arjundc-db Jun 1, 2020
98035b4
Adding AWS support
arjundc-db Jun 2, 2020
0b1af46
Addressing comments
arjundc-db Jun 4, 2020
3d923cb
Fix - needs docs and tests
dbczumar Jun 8, 2020
d3fab4a
Comment and simplification
dbczumar Jun 8, 2020
368973d
Special case for empty file upload to AWS
arjundc-db Jun 8, 2020
b67e4dc
Merge pull request #4 from dbczumar/databricks-repo-fix
arjundc-db Jun 8, 2020
5e87cf7
Merge branch 'databricks-artifact-repo' of https://github.com/arjundc…
arjundc-db Jun 8, 2020
72427a3
Clean up and added tests for relative path
arjundc-db Jun 8, 2020
f82c607
Page
dbczumar Jun 9, 2020
30e3885
Fix
dbczumar Jun 9, 2020
a03e099
Added relative path test cases
arjundc-db Jun 10, 2020
50a5e28
Merge pull request #5 from dbczumar/databricks-repo-pagination
arjundc-db Jun 10, 2020
8c75590
Merge branch 'databricks-artifact-repo' of https://github.com/arjundc…
arjundc-db Jun 10, 2020
6d36297
Added test for list_artifacts pagination
arjundc-db Jun 10, 2020
d84fa21
Merge branch 'master' into databricks-artifact-repo
dbczumar Jun 15, 2020
ec85f06
Fixing travis failures
arjundc-db Jun 16, 2020
70ca1d7
Merge branch 'databricks-artifact-repo' of https://github.com/arjundc…
arjundc-db Jun 16, 2020
c6585d6
Fixes
arjundc-db Jun 16, 2020
51ca61f
More fixes
arjundc-db Jun 16, 2020
d1b9dfd
More fixes
arjundc-db Jun 16, 2020
72ecab5
Clean-up
arjundc-db Jun 16, 2020
dfc7f60
Clean-up
arjundc-db Jun 16, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 4 additions & 2 deletions generate-protos.sh
View file
Open in desktop
Expand Up @@ -14,16 +14,18 @@ protoc -I="$PROTOS" \
"$PROTOS"/databricks.proto \
"$PROTOS"/service.proto \
"$PROTOS"/model_registry.proto \
"$PROTOS"/databricks_artifacts.proto \
"$PROTOS"/scalapb/scalapb.proto

OLD_SCALAPB="from scalapb import scalapb_pb2 as scalapb_dot_scalapb__pb2"
NEW_SCALAPB="from .scalapb import scalapb_pb2 as scalapb_dot_scalapb__pb2"
sed -i'.old' -e "s/$OLD_SCALAPB/$NEW_SCALAPB/g" "$PROTOS/databricks_pb2.py" "$PROTOS/service_pb2.py" "$PROTOS/model_registry_pb2.py"
sed -i'.old' -e "s/$OLD_SCALAPB/$NEW_SCALAPB/g" "$PROTOS/databricks_pb2.py" "$PROTOS/service_pb2.py" "$PROTOS/model_registry_pb2.py" "$PROTOS/databricks_artifacts_pb2.py"

OLD_DATABRICKS="import databricks_pb2 as databricks__pb2"
NEW_DATABRICKS="from . import databricks_pb2 as databricks__pb2"
sed -i'.old' -e "s/$OLD_DATABRICKS/$NEW_DATABRICKS/g" "$PROTOS/service_pb2.py" "$PROTOS/model_registry_pb2.py"
sed -i'.old' -e "s/$OLD_DATABRICKS/$NEW_DATABRICKS/g" "$PROTOS/service_pb2.py" "$PROTOS/model_registry_pb2.py" "$PROTOS/databricks_artifacts_pb2.py"

rm "$PROTOS/databricks_pb2.py.old"
rm "$PROTOS/service_pb2.py.old"
rm "$PROTOS/model_registry_pb2.py.old"
rm "$PROTOS/databricks_artifacts_pb2.py.old"