Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[R] fix duplicate stderr logging #3145

Merged
merged 2 commits into from Sep 17, 2020
Merged

[R] fix duplicate stderr logging #3145

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
76aa66d
fix duplicate stderr
yitao-li Jul 21, 2020
38f469d
update docs
lorenzwalthert Aug 14, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
9 changes: 2 additions & 7 deletions mlflow/R/mlflow/R/cli.R
View file
Open in desktop
Expand Up @@ -5,8 +5,8 @@
# Defaults to \code{FALSE}.
# @param echo Print the standard output and error to the screen? Defaults to
# \code{TRUE}, does not apply to background tasks.
# @param stderr_callback NULL, or a function to call for every chunk of the standard error.
# Defaults to a function that prints chunks to standard error.
# @param stderr_callback \code{NULL} (the default), or a function to call for
# every chunk of the standard error, passed to \code{\link[=processx:run]{processx::run()}}.
# @param client Mlflow client to provide environment for the cli process.
#
# @return A \code{processx} task.
Expand All @@ -30,11 +30,6 @@ mlflow_cli <- function(...,
MLFLOW_BIN = mlflow_bin,
MLFLOW_PYTHON_BIN = python_bin()
), env)
if (is.null(stderr_callback)) {
stderr_callback <- function(x, p) {
cat(x, file = stderr())
}
}
with_envvar(env, {
if (background) {
result <- process$new(mlflow_bin, args = unlist(args), echo_cmd = verbose, supervise = TRUE)
Expand Down