Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix missing alt-text #328

Merged
merged 1 commit into from Aug 21, 2018
Merged

Fix missing alt-text #328

merged 1 commit into from Aug 21, 2018

Conversation

ToonKBC
Copy link
Contributor

@ToonKBC ToonKBC commented Aug 20, 2018

No description provided.

@ToonKBC
Copy link
Contributor Author

ToonKBC commented Aug 20, 2018

Maybe a suggestion: adding react warnings to the travis build.

@codecov-io
Copy link

Codecov Report

Merging #328 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #328   +/-   ##
=======================================
  Coverage   56.38%   56.38%           
=======================================
  Files         113      113           
  Lines        5627     5627           
=======================================
  Hits         3173     3173           
  Misses       2454     2454
Impacted Files Coverage Δ
mlflow/server/js/src/components/ArtifactView.js 0% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update faf43d9...53de2c3. Read the comment docs.

@andrewmchen
Copy link
Contributor

andrewmchen commented Aug 20, 2018 •
edited

I think this specific warning from jsx-a11y isn't caught travis because it is not installed in our eslint configuration. (https://www.npmjs.com/package/eslint-plugin-jsx-a11y) It seems like a good thing to add to our eslint configuration though.

andrewmchen
andrewmchen reviewed Aug 20, 2018
View reviewed changes
mlflow/server/js/src/components/ArtifactView.js
@@ -288,7 +288,7 @@ decorators.Header = ({style, node}) => {
decorators.Loading = ({style}) => {
return (
<div style={style}>
<img className="loading-spinner" src={spinner}/>
<img alt="" className="loading-spinner" src={spinner}/>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does it make sense to actually have some text here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not really, it's a decorative spinner. The most useful alt-text would be 'loading' but that's unnecessary because the next word already is 'loading'.

@andrewmchen andrewmchen self-assigned this Aug 21, 2018
@andrewmchen andrewmchen merged commit 38b9180 into mlflow:master Aug 21, 2018
@andrewmchen
Copy link
Contributor

Thanks for the contribution!

aarondav pushed a commit that referenced this pull request Aug 23, 2018
@ToonKBC @aarondav
Fix missing alt-text (#328)
4811fb5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewmchen andrewmchen andrewmchen left review comments

Assignees

@andrewmchen andrewmchen

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ToonKBC @codecov-io @andrewmchen