Part 2 of the issue 3153 code snippets for the remaing API methods #3437
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jules Damji <dmatrix@comcast.net>
github-actions
bot
added
area/docs
harupy
reviewed
Sep 22, 2020
harupy
reviewed
Sep 22, 2020
harupy
reviewed
Sep 22, 2020
harupy
reviewed
Sep 22, 2020
harupy
reviewed
Sep 22, 2020
Signed-off-by: Jules Damji <dmatrix@comcast.net>
harupy
reviewed
Sep 24, 2020
mlflow/tracking/fluent.py
Outdated
| print("--") | ||
|
|
||
| # Check for any active runs | ||
| print("Active runs: {}".format(mlflow.active_run())) |
There was a problem hiding this comment.
Suggested change
| print("Active runs: {}".format(mlflow.active_run())) | |
| print("Active run: {}".format(mlflow.active_run())) |
Active runs souns like there is a possibility that there are multiple active runs.
harupy
reviewed
Sep 24, 2020
mlflow/tracking/fluent.py
Outdated
Comment on lines
820
to
821
|
|
||
| # Print pandas DataFrame's rows and columns |
There was a problem hiding this comment.
Suggested change
| # Print pandas DataFrame's rows and columns |
There was a problem hiding this comment.
yes, self explanatory
There was a problem hiding this comment.
I'll also remove other explicit # Print statements too
harupy
reviewed
Sep 24, 2020
mlflow/tracking/fluent.py
Outdated
Comment on lines
829
to
830
|
|
||
| # Print pandas DataFrame's rows and columns |
There was a problem hiding this comment.
Suggested change
| # Print pandas DataFrame's rows and columns |
harupy
reviewed
Sep 24, 2020
mlflow/tracking/fluent.py
Outdated
Comment on lines
149
to
150
|
|
||
| # Print the pandas DataFrame columns |
There was a problem hiding this comment.
Suggested change
| # Print the pandas DataFrame columns |
harupy
reviewed
Sep 24, 2020
Signed-off-by: Jules Damji <dmatrix@comcast.net>
harupy
approved these changes
Sep 25, 2020
|
LGTM! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Jules Damji dmatrix@comcast.net
What changes are proposed in this pull request?
This is part 2 for the #3385
(Details in 1-2 sentences. You can just refer to another PR with a description if this PR is part of a larger change.)
What component(s), interfaces, languages, and integrations does this PR affect?
Components
area/artifacts: Artifact stores and artifact loggingarea/build: Build and test infrastructure for MLflowarea/docs: MLflow documentation pagesarea/examples: Example codearea/model-registry: Model Registry service, APIs, and the fluent client calls for Model Registryarea/models: MLmodel format, model serialization/deserialization, flavorsarea/projects: MLproject format, project running backendsarea/scoring: Local serving, model deployment tools, spark UDFsarea/server-infra: MLflow server, JavaScript dev serverarea/tracking: Tracking Service, tracking client APIs, autologgingHow should the PR be classified in the release notes? Choose one:
rn/breaking-change- The PR will be mentioned in the "Breaking Changes" sectionrn/none- No description will be included. The PR will be mentioned only by the PR number in the "Small Bugfixes and Documentation Updates" sectionrn/feature- A new user-facing feature worth mentioning in the release notesrn/bug-fix- A user-facing bug fix worth mentioning in the release notesrn/documentation- A user-facing documentation change worth mentioning in the release notes