Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CROSS VERSION TEST] Fix regular expression to capture flavor name from changed files #3887

Merged
merged 1 commit into from Dec 22, 2020

Conversation

harupy
Copy link
Member

@harupy harupy commented Dec 22, 2020

Signed-off-by: harupy 17039389+harupy@users.noreply.github.com

What changes are proposed in this pull request?

  • A follow-up for the cross version test.
  • Curretnly, get_changed_flavors in set_matrix.py doesn't detect changes on files under tests/<flavor_name>_autolog (e.g. tests/keras_autlog) or tests/<flavor_name>_autologging (e.g. tests/spark_autologging) because it just expects the format: tests/<flavor_name>. This PR fixes this issue by modifying the regular expression to capture a flavor name.

How is this patch tested?

New doctests

Release Notes

Is this a user-facing change?

  • No. You can skip the rest of this section.
  • Yes. Give a description of this change to be included in the release notes for MLflow users.

(Details in 1-2 sentences. You can just refer to another PR with a description if this PR is part of a larger change.)

What component(s), interfaces, languages, and integrations does this PR affect?

Components

  • area/artifacts: Artifact stores and artifact logging
  • area/build: Build and test infrastructure for MLflow
  • area/docs: MLflow documentation pages
  • area/examples: Example code
  • area/model-registry: Model Registry service, APIs, and the fluent client calls for Model Registry
  • area/models: MLmodel format, model serialization/deserialization, flavors
  • area/projects: MLproject format, project running backends
  • area/scoring: Local serving, model deployment tools, spark UDFs
  • area/server-infra: MLflow server, JavaScript dev server
  • area/tracking: Tracking Service, tracking client APIs, autologging

Interface

  • area/uiux: Front-end, user experience, JavaScript, plotting
  • area/docker: Docker use across MLflow's components, such as MLflow Projects and MLflow Models
  • area/sqlalchemy: Use of SQLAlchemy in the Tracking Service or Model Registry
  • area/windows: Windows support

Language

  • language/r: R APIs and clients
  • language/java: Java APIs and clients
  • language/new: Proposals for new client languages

Integrations

  • integrations/azure: Azure and Azure ML integrations
  • integrations/sagemaker: SageMaker integrations
  • integrations/databricks: Databricks integrations

How should the PR be classified in the release notes? Choose one:

  • rn/breaking-change - The PR will be mentioned in the "Breaking Changes" section
  • rn/none - No description will be included. The PR will be mentioned only by the PR number in the "Small Bugfixes and Documentation Updates" section
  • rn/feature - A new user-facing feature worth mentioning in the release notes
  • rn/bug-fix - A user-facing bug fix worth mentioning in the release notes
  • rn/documentation - A user-facing documentation change worth mentioning in the release notes

Signed-off-by: harupy <17039389+harupy@users.noreply.github.com>
@github-actions github-actions bot added area/build Build and test infrastructure for MLflow rn/none List under Small Changes in Changelogs. labels Dec 22, 2020
@github-actions github-actions bot added area/build Build and test infrastructure for MLflow rn/none List under Small Changes in Changelogs. and removed area/build Build and test infrastructure for MLflow rn/none List under Small Changes in Changelogs. labels Dec 22, 2020
@harupy harupy requested a review from dbczumar December 22, 2020 01:34
Copy link
Collaborator

@dbczumar dbczumar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @harupy !

@dbczumar dbczumar merged commit 713d8ba into mlflow:master Dec 22, 2020
@harupy harupy deleted the detect-files-under-test-autolog branch December 22, 2020 01:50
lorenzwalthert pushed a commit to lorenzwalthert/mlflow that referenced this pull request Dec 23, 2020
Signed-off-by: harupy <17039389+harupy@users.noreply.github.com>
harupy added a commit to chauhang/mlflow that referenced this pull request Apr 8, 2021
Signed-off-by: harupy <17039389+harupy@users.noreply.github.com>
harupy added a commit to wamartin-aml/mlflow that referenced this pull request Jun 7, 2021
Signed-off-by: harupy <17039389+harupy@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/build Build and test infrastructure for MLflow rn/none List under Small Changes in Changelogs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants