Modularize autologging utilities #4216
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: dbczumar <corey.zumar@databricks.com>
Signed-off-by: dbczumar <corey.zumar@databricks.com>
Signed-off-by: dbczumar <corey.zumar@databricks.com>
Signed-off-by: dbczumar <corey.zumar@databricks.com>
Signed-off-by: dbczumar <corey.zumar@databricks.com>
github-actions
bot
added
rn/none
Signed-off-by: dbczumar <corey.zumar@databricks.com>
Signed-off-by: dbczumar <corey.zumar@databricks.com>
Signed-off-by: dbczumar <corey.zumar@databricks.com>
Signed-off-by: dbczumar <corey.zumar@databricks.com>
dbczumar
commented
Mar 30, 2021
| @@ -0,0 +1,227 @@ | |||
| import warnings | |||
There was a problem hiding this comment.
Moved AutologgingEventLogger verbatim from mlflow/utils/autologging_utils/__init__.py.
dbczumar
commented
Mar 30, 2021
| @@ -0,0 +1,734 @@ | |||
| import abc | |||
There was a problem hiding this comment.
Moved safe_patch, exception-safe class/function, and other autologging safety utilities from mlflow/utils/autologging_utils/__init__.py. Moved _is_testing to is_testing since it's used outside of the autologging_utils module.
dbczumar
commented
Mar 30, 2021
| @@ -0,0 +1,50 @@ | |||
| import importlib | |||
There was a problem hiding this comment.
Moved supported version checking / validation logic from mlflow/utils/autologging_utils/__init__.py and updated some docstrings & variable / method names.
apurva-koti
approved these changes
Mar 31, 2021
There was a problem hiding this comment.
Not a blocking comment but this is just one of those PRs that's kind of author-heavy; the split looks good but the actual git diff is super hard to parse. So as long as this pr is cutting/pasting with import changes to match we should be good. (and tests pass of course)
|
Thanks for sifting through this @apurva-koti ! |
alkispoly-db
pushed a commit
to alkispoly-db/mlflow
that referenced
this pull request
Apr 6, 2021
* rename back to autologging_utils Signed-off-by: dbczumar <corey.zumar@databricks.com> * Partial Signed-off-by: dbczumar <corey.zumar@databricks.com> * Add files Signed-off-by: dbczumar <corey.zumar@databricks.com> * Fixes Signed-off-by: dbczumar <corey.zumar@databricks.com> * More Signed-off-by: dbczumar <corey.zumar@databricks.com> * Explanatory comment Signed-off-by: dbczumar <corey.zumar@databricks.com> * Test fixes Signed-off-by: dbczumar <corey.zumar@databricks.com> * Format Signed-off-by: dbczumar <corey.zumar@databricks.com> * Remove raise Signed-off-by: dbczumar <corey.zumar@databricks.com> * Import fix Signed-off-by: dbczumar <corey.zumar@databricks.com> * Test Signed-off-by: dbczumar <corey.zumar@databricks.com> * Lint Signed-off-by: dbczumar <corey.zumar@databricks.com> * Comment Signed-off-by: dbczumar <corey.zumar@databricks.com> * Modularize versions, format Signed-off-by: dbczumar <corey.zumar@databricks.com> * Add versioning Signed-off-by: dbczumar <corey.zumar@databricks.com> * Remove import Signed-off-by: dbczumar <corey.zumar@databricks.com>
alkispoly-db
pushed a commit
to alkispoly-db/mlflow
that referenced
this pull request
Apr 6, 2021
* rename back to autologging_utils Signed-off-by: dbczumar <corey.zumar@databricks.com> * Partial Signed-off-by: dbczumar <corey.zumar@databricks.com> * Add files Signed-off-by: dbczumar <corey.zumar@databricks.com> * Fixes Signed-off-by: dbczumar <corey.zumar@databricks.com> * More Signed-off-by: dbczumar <corey.zumar@databricks.com> * Explanatory comment Signed-off-by: dbczumar <corey.zumar@databricks.com> * Test fixes Signed-off-by: dbczumar <corey.zumar@databricks.com> * Format Signed-off-by: dbczumar <corey.zumar@databricks.com> * Remove raise Signed-off-by: dbczumar <corey.zumar@databricks.com> * Import fix Signed-off-by: dbczumar <corey.zumar@databricks.com> * Test Signed-off-by: dbczumar <corey.zumar@databricks.com> * Lint Signed-off-by: dbczumar <corey.zumar@databricks.com> * Comment Signed-off-by: dbczumar <corey.zumar@databricks.com> * Modularize versions, format Signed-off-by: dbczumar <corey.zumar@databricks.com> * Add versioning Signed-off-by: dbczumar <corey.zumar@databricks.com> * Remove import Signed-off-by: dbczumar <corey.zumar@databricks.com> Signed-off-by: Alkis Polyzotis <alkis.polyzotis@databricks.com>
harupy
added a commit
that referenced
this pull request
Apr 7, 2021
* mlflow.sklearn.log_eval_metrics: implementation and tests Signed-off-by: Alkis Polyzotis <alkis.polyzotis@databricks.com> * Lint cleanups Signed-off-by: Alkis Polyzotis <alkis.polyzotis@databricks.com> * address some review comments Signed-off-by: Alkis Polyzotis <alkis.polyzotis@databricks.com> * Addressed 2nd-round review comments Signed-off-by: Alkis Polyzotis <alkis.polyzotis@databricks.com> * Changes return to metrics only and allows non-keyword arguments for model, X, y_true Signed-off-by: Alkis Polyzotis <alkis.polyzotis@databricks.com> * Apply suggestions from code review Co-authored-by: Siddharth Murching <smurching@gmail.com> Signed-off-by: Alkis Polyzotis <alkis.polyzotis@databricks.com> * [PyTorch] Adding Example for Ax Hyperparameter Optimization (#3885) * Adding Example for Ax Hyperparameter Optimization Signed-off-by: ankan94 <ankan@ideas2it.com> * Updating implementation to use Iris Classification example Signed-off-by: Shrinath Suresh <shrinath@ideas2it.com> * Adding Tests for ax example Signed-off-by: Shrinath Suresh <shrinath@ideas2it.com> * Fixing Lint errors Signed-off-by: Shrinath Suresh <shrinath@ideas2it.com> * removing print statements Signed-off-by: Shrinath Suresh <shrinath@ideas2it.com> * Removing parameters specific to Adam Optimizer Signed-off-by: Shrinath Suresh <shrinath@ideas2it.com> * Adding conditions for SGD parameters Signed-off-by: Shrinath Suresh <shrinath@ideas2it.com> * removing prefix parameter Signed-off-by: Shrinath Suresh <shrinath@ideas2it.com> * Fixed Pythonpath issue Signed-off-by: Shrinath Suresh <shrinath@ideas2it.com> * Moving Iris Classification class to Ax Folder Signed-off-by: Shrinath Suresh <shrinath@ideas2it.com> * Removing the unused code Signed-off-by: Shrinath Suresh <shrinath@ideas2it.com> * Addressing review comments Signed-off-by: Shrinath Suresh <shrinath@ideas2it.com> * Addressing review comments Signed-off-by: Shrinath Suresh <shrinath@ideas2it.com> * Removing pandas from dependency Signed-off-by: Shrinath Suresh <shrinath@ideas2it.com> * removing unused packages from conda.yaml Signed-off-by: Shrinath Suresh <shrinath@ideas2it.com> * Changing project name Signed-off-by: Shrinath Suresh <shrinath@ideas2it.com> * reverting iris file changes Signed-off-by: Shrinath Suresh <shrinath@ideas2it.com> * Changing filename Signed-off-by: Shrinath Suresh <shrinath@ideas2it.com> * Reverting iris files from upstream master branch Signed-off-by: Shrinath Suresh <shrinath@ideas2it.com> * Reverting pytorch autolog file from upstream master Signed-off-by: Shrinath Suresh <shrinath@ideas2it.com> * Fixing doc strings Signed-off-by: Shrinath Suresh <shrinath@ideas2it.com> * Removing unused iris class Signed-off-by: Shrinath Suresh <shrinath@ideas2it.com> * Adding torchvision Signed-off-by: Shrinath Suresh <shrinath@ideas2it.com> * Fixing iris.py Signed-off-by: Shrinath Suresh <shrinath@ideas2it.com> Co-authored-by: Shrinath Suresh <shrinath@ideas2it.com> Co-authored-by: harupy <17039389+harupy@users.noreply.github.com> Signed-off-by: Alkis Polyzotis <alkis.polyzotis@databricks.com> * Modularize autologging utilities (#4216) * rename back to autologging_utils Signed-off-by: dbczumar <corey.zumar@databricks.com> * Partial Signed-off-by: dbczumar <corey.zumar@databricks.com> * Add files Signed-off-by: dbczumar <corey.zumar@databricks.com> * Fixes Signed-off-by: dbczumar <corey.zumar@databricks.com> * More Signed-off-by: dbczumar <corey.zumar@databricks.com> * Explanatory comment Signed-off-by: dbczumar <corey.zumar@databricks.com> * Test fixes Signed-off-by: dbczumar <corey.zumar@databricks.com> * Format Signed-off-by: dbczumar <corey.zumar@databricks.com> * Remove raise Signed-off-by: dbczumar <corey.zumar@databricks.com> * Import fix Signed-off-by: dbczumar <corey.zumar@databricks.com> * Test Signed-off-by: dbczumar <corey.zumar@databricks.com> * Lint Signed-off-by: dbczumar <corey.zumar@databricks.com> * Comment Signed-off-by: dbczumar <corey.zumar@databricks.com> * Modularize versions, format Signed-off-by: dbczumar <corey.zumar@databricks.com> * Add versioning Signed-off-by: dbczumar <corey.zumar@databricks.com> * Remove import Signed-off-by: dbczumar <corey.zumar@databricks.com> Signed-off-by: Alkis Polyzotis <alkis.polyzotis@databricks.com> * Update MLflow version to 1.15.1 (#4209) Signed-off-by: Jenkins <jenkins@databricks.com> Co-authored-by: Jenkins <jenkins@databricks.com> Signed-off-by: Alkis Polyzotis <alkis.polyzotis@databricks.com> * Fix 1.15 migration error (#4211) * Fix 1.15 migration error Signed-off-by: Мартынов Максим Сергеевич <msmarty5@mts.ru> * remove server_deafult because it's False by default Signed-off-by: harupy <17039389+harupy@users.noreply.github.com> * Add migration file Signed-off-by: harupy <17039389+harupy@users.noreply.github.com> * add comment Signed-off-by: harupy <17039389+harupy@users.noreply.github.com> * fix Signed-off-by: harupy <17039389+harupy@users.noreply.github.com> * fix typo Signed-off-by: harupy <17039389+harupy@users.noreply.github.com> Co-authored-by: harupy <17039389+harupy@users.noreply.github.com> Signed-off-by: Alkis Polyzotis <alkis.polyzotis@databricks.com> * Fixes tests that were broken from changed error messages Signed-off-by: Alkis Polyzotis <alkis.polyzotis@databricks.com> * Update mlflow/sklearn/__init__.py for better doc formatting Co-authored-by: Harutaka Kawamura <hkawamura0130@gmail.com> Signed-off-by: Alkis Polyzotis <alkis.polyzotis@databricks.com> * Lint fixes. Signed-off-by: Alkis Polyzotis <alkis.polyzotis@databricks.com> * mlflow.sklearn.log_eval_metrics: implementation and tests Signed-off-by: Alkis Polyzotis <alkis.polyzotis@databricks.com> * Lint cleanups Signed-off-by: Alkis Polyzotis <alkis.polyzotis@databricks.com> * address some review comments Signed-off-by: Alkis Polyzotis <alkis.polyzotis@databricks.com> * Addressed 2nd-round review comments Signed-off-by: Alkis Polyzotis <alkis.polyzotis@databricks.com> * Changes return to metrics only and allows non-keyword arguments for model, X, y_true Signed-off-by: Alkis Polyzotis <alkis.polyzotis@databricks.com> * Apply suggestions from code review Co-authored-by: Siddharth Murching <smurching@gmail.com> Signed-off-by: Alkis Polyzotis <alkis.polyzotis@databricks.com> * Fixes tests that were broken from changed error messages Signed-off-by: Alkis Polyzotis <alkis.polyzotis@databricks.com> * Update mlflow/sklearn/__init__.py for better doc formatting Co-authored-by: Harutaka Kawamura <hkawamura0130@gmail.com> Signed-off-by: Alkis Polyzotis <alkis.polyzotis@databricks.com> * Lint fixes. Signed-off-by: Alkis Polyzotis <alkis.polyzotis@databricks.com> Co-authored-by: Alkis Polyzotis <alkis.polyzotis@gmail.com> Co-authored-by: Siddharth Murching <smurching@gmail.com> Co-authored-by: ankan94 <51693147+ankan94@users.noreply.github.com> Co-authored-by: Shrinath Suresh <shrinath@ideas2it.com> Co-authored-by: harupy <17039389+harupy@users.noreply.github.com> Co-authored-by: dbczumar <39497902+dbczumar@users.noreply.github.com> Co-authored-by: mlflow-automation <61449322+mlflow-automation@users.noreply.github.com> Co-authored-by: Jenkins <jenkins@databricks.com> Co-authored-by: Martynov Maxim <msmarty5@mts.ru> Co-authored-by: Harutaka Kawamura <hkawamura0130@gmail.com>
harupy
pushed a commit
to chauhang/mlflow
that referenced
this pull request
Apr 8, 2021
* rename back to autologging_utils Signed-off-by: dbczumar <corey.zumar@databricks.com> * Partial Signed-off-by: dbczumar <corey.zumar@databricks.com> * Add files Signed-off-by: dbczumar <corey.zumar@databricks.com> * Fixes Signed-off-by: dbczumar <corey.zumar@databricks.com> * More Signed-off-by: dbczumar <corey.zumar@databricks.com> * Explanatory comment Signed-off-by: dbczumar <corey.zumar@databricks.com> * Test fixes Signed-off-by: dbczumar <corey.zumar@databricks.com> * Format Signed-off-by: dbczumar <corey.zumar@databricks.com> * Remove raise Signed-off-by: dbczumar <corey.zumar@databricks.com> * Import fix Signed-off-by: dbczumar <corey.zumar@databricks.com> * Test Signed-off-by: dbczumar <corey.zumar@databricks.com> * Lint Signed-off-by: dbczumar <corey.zumar@databricks.com> * Comment Signed-off-by: dbczumar <corey.zumar@databricks.com> * Modularize versions, format Signed-off-by: dbczumar <corey.zumar@databricks.com> * Add versioning Signed-off-by: dbczumar <corey.zumar@databricks.com> * Remove import Signed-off-by: dbczumar <corey.zumar@databricks.com> Signed-off-by: harupy <17039389+harupy@users.noreply.github.com>
harupy
added a commit
to chauhang/mlflow
that referenced
this pull request
Apr 8, 2021
* mlflow.sklearn.log_eval_metrics: implementation and tests Signed-off-by: Alkis Polyzotis <alkis.polyzotis@databricks.com> * Lint cleanups Signed-off-by: Alkis Polyzotis <alkis.polyzotis@databricks.com> * address some review comments Signed-off-by: Alkis Polyzotis <alkis.polyzotis@databricks.com> * Addressed 2nd-round review comments Signed-off-by: Alkis Polyzotis <alkis.polyzotis@databricks.com> * Changes return to metrics only and allows non-keyword arguments for model, X, y_true Signed-off-by: Alkis Polyzotis <alkis.polyzotis@databricks.com> * Apply suggestions from code review Co-authored-by: Siddharth Murching <smurching@gmail.com> Signed-off-by: Alkis Polyzotis <alkis.polyzotis@databricks.com> * [PyTorch] Adding Example for Ax Hyperparameter Optimization (mlflow#3885) * Adding Example for Ax Hyperparameter Optimization Signed-off-by: ankan94 <ankan@ideas2it.com> * Updating implementation to use Iris Classification example Signed-off-by: Shrinath Suresh <shrinath@ideas2it.com> * Adding Tests for ax example Signed-off-by: Shrinath Suresh <shrinath@ideas2it.com> * Fixing Lint errors Signed-off-by: Shrinath Suresh <shrinath@ideas2it.com> * removing print statements Signed-off-by: Shrinath Suresh <shrinath@ideas2it.com> * Removing parameters specific to Adam Optimizer Signed-off-by: Shrinath Suresh <shrinath@ideas2it.com> * Adding conditions for SGD parameters Signed-off-by: Shrinath Suresh <shrinath@ideas2it.com> * removing prefix parameter Signed-off-by: Shrinath Suresh <shrinath@ideas2it.com> * Fixed Pythonpath issue Signed-off-by: Shrinath Suresh <shrinath@ideas2it.com> * Moving Iris Classification class to Ax Folder Signed-off-by: Shrinath Suresh <shrinath@ideas2it.com> * Removing the unused code Signed-off-by: Shrinath Suresh <shrinath@ideas2it.com> * Addressing review comments Signed-off-by: Shrinath Suresh <shrinath@ideas2it.com> * Addressing review comments Signed-off-by: Shrinath Suresh <shrinath@ideas2it.com> * Removing pandas from dependency Signed-off-by: Shrinath Suresh <shrinath@ideas2it.com> * removing unused packages from conda.yaml Signed-off-by: Shrinath Suresh <shrinath@ideas2it.com> * Changing project name Signed-off-by: Shrinath Suresh <shrinath@ideas2it.com> * reverting iris file changes Signed-off-by: Shrinath Suresh <shrinath@ideas2it.com> * Changing filename Signed-off-by: Shrinath Suresh <shrinath@ideas2it.com> * Reverting iris files from upstream master branch Signed-off-by: Shrinath Suresh <shrinath@ideas2it.com> * Reverting pytorch autolog file from upstream master Signed-off-by: Shrinath Suresh <shrinath@ideas2it.com> * Fixing doc strings Signed-off-by: Shrinath Suresh <shrinath@ideas2it.com> * Removing unused iris class Signed-off-by: Shrinath Suresh <shrinath@ideas2it.com> * Adding torchvision Signed-off-by: Shrinath Suresh <shrinath@ideas2it.com> * Fixing iris.py Signed-off-by: Shrinath Suresh <shrinath@ideas2it.com> Co-authored-by: Shrinath Suresh <shrinath@ideas2it.com> Co-authored-by: harupy <17039389+harupy@users.noreply.github.com> Signed-off-by: Alkis Polyzotis <alkis.polyzotis@databricks.com> * Modularize autologging utilities (mlflow#4216) * rename back to autologging_utils Signed-off-by: dbczumar <corey.zumar@databricks.com> * Partial Signed-off-by: dbczumar <corey.zumar@databricks.com> * Add files Signed-off-by: dbczumar <corey.zumar@databricks.com> * Fixes Signed-off-by: dbczumar <corey.zumar@databricks.com> * More Signed-off-by: dbczumar <corey.zumar@databricks.com> * Explanatory comment Signed-off-by: dbczumar <corey.zumar@databricks.com> * Test fixes Signed-off-by: dbczumar <corey.zumar@databricks.com> * Format Signed-off-by: dbczumar <corey.zumar@databricks.com> * Remove raise Signed-off-by: dbczumar <corey.zumar@databricks.com> * Import fix Signed-off-by: dbczumar <corey.zumar@databricks.com> * Test Signed-off-by: dbczumar <corey.zumar@databricks.com> * Lint Signed-off-by: dbczumar <corey.zumar@databricks.com> * Comment Signed-off-by: dbczumar <corey.zumar@databricks.com> * Modularize versions, format Signed-off-by: dbczumar <corey.zumar@databricks.com> * Add versioning Signed-off-by: dbczumar <corey.zumar@databricks.com> * Remove import Signed-off-by: dbczumar <corey.zumar@databricks.com> Signed-off-by: Alkis Polyzotis <alkis.polyzotis@databricks.com> * Update MLflow version to 1.15.1 (mlflow#4209) Signed-off-by: Jenkins <jenkins@databricks.com> Co-authored-by: Jenkins <jenkins@databricks.com> Signed-off-by: Alkis Polyzotis <alkis.polyzotis@databricks.com> * Fix 1.15 migration error (mlflow#4211) * Fix 1.15 migration error Signed-off-by: Мартынов Максим Сергеевич <msmarty5@mts.ru> * remove server_deafult because it's False by default Signed-off-by: harupy <17039389+harupy@users.noreply.github.com> * Add migration file Signed-off-by: harupy <17039389+harupy@users.noreply.github.com> * add comment Signed-off-by: harupy <17039389+harupy@users.noreply.github.com> * fix Signed-off-by: harupy <17039389+harupy@users.noreply.github.com> * fix typo Signed-off-by: harupy <17039389+harupy@users.noreply.github.com> Co-authored-by: harupy <17039389+harupy@users.noreply.github.com> Signed-off-by: Alkis Polyzotis <alkis.polyzotis@databricks.com> * Fixes tests that were broken from changed error messages Signed-off-by: Alkis Polyzotis <alkis.polyzotis@databricks.com> * Update mlflow/sklearn/__init__.py for better doc formatting Co-authored-by: Harutaka Kawamura <hkawamura0130@gmail.com> Signed-off-by: Alkis Polyzotis <alkis.polyzotis@databricks.com> * Lint fixes. Signed-off-by: Alkis Polyzotis <alkis.polyzotis@databricks.com> * mlflow.sklearn.log_eval_metrics: implementation and tests Signed-off-by: Alkis Polyzotis <alkis.polyzotis@databricks.com> * Lint cleanups Signed-off-by: Alkis Polyzotis <alkis.polyzotis@databricks.com> * address some review comments Signed-off-by: Alkis Polyzotis <alkis.polyzotis@databricks.com> * Addressed 2nd-round review comments Signed-off-by: Alkis Polyzotis <alkis.polyzotis@databricks.com> * Changes return to metrics only and allows non-keyword arguments for model, X, y_true Signed-off-by: Alkis Polyzotis <alkis.polyzotis@databricks.com> * Apply suggestions from code review Co-authored-by: Siddharth Murching <smurching@gmail.com> Signed-off-by: Alkis Polyzotis <alkis.polyzotis@databricks.com> * Fixes tests that were broken from changed error messages Signed-off-by: Alkis Polyzotis <alkis.polyzotis@databricks.com> * Update mlflow/sklearn/__init__.py for better doc formatting Co-authored-by: Harutaka Kawamura <hkawamura0130@gmail.com> Signed-off-by: Alkis Polyzotis <alkis.polyzotis@databricks.com> * Lint fixes. Signed-off-by: Alkis Polyzotis <alkis.polyzotis@databricks.com> Co-authored-by: Alkis Polyzotis <alkis.polyzotis@gmail.com> Co-authored-by: Siddharth Murching <smurching@gmail.com> Co-authored-by: ankan94 <51693147+ankan94@users.noreply.github.com> Co-authored-by: Shrinath Suresh <shrinath@ideas2it.com> Co-authored-by: harupy <17039389+harupy@users.noreply.github.com> Co-authored-by: dbczumar <39497902+dbczumar@users.noreply.github.com> Co-authored-by: mlflow-automation <61449322+mlflow-automation@users.noreply.github.com> Co-authored-by: Jenkins <jenkins@databricks.com> Co-authored-by: Martynov Maxim <msmarty5@mts.ru> Co-authored-by: Harutaka Kawamura <hkawamura0130@gmail.com> Signed-off-by: harupy <17039389+harupy@users.noreply.github.com>
harupy
pushed a commit
to wamartin-aml/mlflow
that referenced
this pull request
Jun 7, 2021
* rename back to autologging_utils Signed-off-by: dbczumar <corey.zumar@databricks.com> * Partial Signed-off-by: dbczumar <corey.zumar@databricks.com> * Add files Signed-off-by: dbczumar <corey.zumar@databricks.com> * Fixes Signed-off-by: dbczumar <corey.zumar@databricks.com> * More Signed-off-by: dbczumar <corey.zumar@databricks.com> * Explanatory comment Signed-off-by: dbczumar <corey.zumar@databricks.com> * Test fixes Signed-off-by: dbczumar <corey.zumar@databricks.com> * Format Signed-off-by: dbczumar <corey.zumar@databricks.com> * Remove raise Signed-off-by: dbczumar <corey.zumar@databricks.com> * Import fix Signed-off-by: dbczumar <corey.zumar@databricks.com> * Test Signed-off-by: dbczumar <corey.zumar@databricks.com> * Lint Signed-off-by: dbczumar <corey.zumar@databricks.com> * Comment Signed-off-by: dbczumar <corey.zumar@databricks.com> * Modularize versions, format Signed-off-by: dbczumar <corey.zumar@databricks.com> * Add versioning Signed-off-by: dbczumar <corey.zumar@databricks.com> * Remove import Signed-off-by: dbczumar <corey.zumar@databricks.com> Signed-off-by: harupy <17039389+harupy@users.noreply.github.com>
harupy
added a commit
to wamartin-aml/mlflow
that referenced
this pull request
Jun 7, 2021
* mlflow.sklearn.log_eval_metrics: implementation and tests Signed-off-by: Alkis Polyzotis <alkis.polyzotis@databricks.com> * Lint cleanups Signed-off-by: Alkis Polyzotis <alkis.polyzotis@databricks.com> * address some review comments Signed-off-by: Alkis Polyzotis <alkis.polyzotis@databricks.com> * Addressed 2nd-round review comments Signed-off-by: Alkis Polyzotis <alkis.polyzotis@databricks.com> * Changes return to metrics only and allows non-keyword arguments for model, X, y_true Signed-off-by: Alkis Polyzotis <alkis.polyzotis@databricks.com> * Apply suggestions from code review Co-authored-by: Siddharth Murching <smurching@gmail.com> Signed-off-by: Alkis Polyzotis <alkis.polyzotis@databricks.com> * [PyTorch] Adding Example for Ax Hyperparameter Optimization (mlflow#3885) * Adding Example for Ax Hyperparameter Optimization Signed-off-by: ankan94 <ankan@ideas2it.com> * Updating implementation to use Iris Classification example Signed-off-by: Shrinath Suresh <shrinath@ideas2it.com> * Adding Tests for ax example Signed-off-by: Shrinath Suresh <shrinath@ideas2it.com> * Fixing Lint errors Signed-off-by: Shrinath Suresh <shrinath@ideas2it.com> * removing print statements Signed-off-by: Shrinath Suresh <shrinath@ideas2it.com> * Removing parameters specific to Adam Optimizer Signed-off-by: Shrinath Suresh <shrinath@ideas2it.com> * Adding conditions for SGD parameters Signed-off-by: Shrinath Suresh <shrinath@ideas2it.com> * removing prefix parameter Signed-off-by: Shrinath Suresh <shrinath@ideas2it.com> * Fixed Pythonpath issue Signed-off-by: Shrinath Suresh <shrinath@ideas2it.com> * Moving Iris Classification class to Ax Folder Signed-off-by: Shrinath Suresh <shrinath@ideas2it.com> * Removing the unused code Signed-off-by: Shrinath Suresh <shrinath@ideas2it.com> * Addressing review comments Signed-off-by: Shrinath Suresh <shrinath@ideas2it.com> * Addressing review comments Signed-off-by: Shrinath Suresh <shrinath@ideas2it.com> * Removing pandas from dependency Signed-off-by: Shrinath Suresh <shrinath@ideas2it.com> * removing unused packages from conda.yaml Signed-off-by: Shrinath Suresh <shrinath@ideas2it.com> * Changing project name Signed-off-by: Shrinath Suresh <shrinath@ideas2it.com> * reverting iris file changes Signed-off-by: Shrinath Suresh <shrinath@ideas2it.com> * Changing filename Signed-off-by: Shrinath Suresh <shrinath@ideas2it.com> * Reverting iris files from upstream master branch Signed-off-by: Shrinath Suresh <shrinath@ideas2it.com> * Reverting pytorch autolog file from upstream master Signed-off-by: Shrinath Suresh <shrinath@ideas2it.com> * Fixing doc strings Signed-off-by: Shrinath Suresh <shrinath@ideas2it.com> * Removing unused iris class Signed-off-by: Shrinath Suresh <shrinath@ideas2it.com> * Adding torchvision Signed-off-by: Shrinath Suresh <shrinath@ideas2it.com> * Fixing iris.py Signed-off-by: Shrinath Suresh <shrinath@ideas2it.com> Co-authored-by: Shrinath Suresh <shrinath@ideas2it.com> Co-authored-by: harupy <17039389+harupy@users.noreply.github.com> Signed-off-by: Alkis Polyzotis <alkis.polyzotis@databricks.com> * Modularize autologging utilities (mlflow#4216) * rename back to autologging_utils Signed-off-by: dbczumar <corey.zumar@databricks.com> * Partial Signed-off-by: dbczumar <corey.zumar@databricks.com> * Add files Signed-off-by: dbczumar <corey.zumar@databricks.com> * Fixes Signed-off-by: dbczumar <corey.zumar@databricks.com> * More Signed-off-by: dbczumar <corey.zumar@databricks.com> * Explanatory comment Signed-off-by: dbczumar <corey.zumar@databricks.com> * Test fixes Signed-off-by: dbczumar <corey.zumar@databricks.com> * Format Signed-off-by: dbczumar <corey.zumar@databricks.com> * Remove raise Signed-off-by: dbczumar <corey.zumar@databricks.com> * Import fix Signed-off-by: dbczumar <corey.zumar@databricks.com> * Test Signed-off-by: dbczumar <corey.zumar@databricks.com> * Lint Signed-off-by: dbczumar <corey.zumar@databricks.com> * Comment Signed-off-by: dbczumar <corey.zumar@databricks.com> * Modularize versions, format Signed-off-by: dbczumar <corey.zumar@databricks.com> * Add versioning Signed-off-by: dbczumar <corey.zumar@databricks.com> * Remove import Signed-off-by: dbczumar <corey.zumar@databricks.com> Signed-off-by: Alkis Polyzotis <alkis.polyzotis@databricks.com> * Update MLflow version to 1.15.1 (mlflow#4209) Signed-off-by: Jenkins <jenkins@databricks.com> Co-authored-by: Jenkins <jenkins@databricks.com> Signed-off-by: Alkis Polyzotis <alkis.polyzotis@databricks.com> * Fix 1.15 migration error (mlflow#4211) * Fix 1.15 migration error Signed-off-by: Мартынов Максим Сергеевич <msmarty5@mts.ru> * remove server_deafult because it's False by default Signed-off-by: harupy <17039389+harupy@users.noreply.github.com> * Add migration file Signed-off-by: harupy <17039389+harupy@users.noreply.github.com> * add comment Signed-off-by: harupy <17039389+harupy@users.noreply.github.com> * fix Signed-off-by: harupy <17039389+harupy@users.noreply.github.com> * fix typo Signed-off-by: harupy <17039389+harupy@users.noreply.github.com> Co-authored-by: harupy <17039389+harupy@users.noreply.github.com> Signed-off-by: Alkis Polyzotis <alkis.polyzotis@databricks.com> * Fixes tests that were broken from changed error messages Signed-off-by: Alkis Polyzotis <alkis.polyzotis@databricks.com> * Update mlflow/sklearn/__init__.py for better doc formatting Co-authored-by: Harutaka Kawamura <hkawamura0130@gmail.com> Signed-off-by: Alkis Polyzotis <alkis.polyzotis@databricks.com> * Lint fixes. Signed-off-by: Alkis Polyzotis <alkis.polyzotis@databricks.com> * mlflow.sklearn.log_eval_metrics: implementation and tests Signed-off-by: Alkis Polyzotis <alkis.polyzotis@databricks.com> * Lint cleanups Signed-off-by: Alkis Polyzotis <alkis.polyzotis@databricks.com> * address some review comments Signed-off-by: Alkis Polyzotis <alkis.polyzotis@databricks.com> * Addressed 2nd-round review comments Signed-off-by: Alkis Polyzotis <alkis.polyzotis@databricks.com> * Changes return to metrics only and allows non-keyword arguments for model, X, y_true Signed-off-by: Alkis Polyzotis <alkis.polyzotis@databricks.com> * Apply suggestions from code review Co-authored-by: Siddharth Murching <smurching@gmail.com> Signed-off-by: Alkis Polyzotis <alkis.polyzotis@databricks.com> * Fixes tests that were broken from changed error messages Signed-off-by: Alkis Polyzotis <alkis.polyzotis@databricks.com> * Update mlflow/sklearn/__init__.py for better doc formatting Co-authored-by: Harutaka Kawamura <hkawamura0130@gmail.com> Signed-off-by: Alkis Polyzotis <alkis.polyzotis@databricks.com> * Lint fixes. Signed-off-by: Alkis Polyzotis <alkis.polyzotis@databricks.com> Co-authored-by: Alkis Polyzotis <alkis.polyzotis@gmail.com> Co-authored-by: Siddharth Murching <smurching@gmail.com> Co-authored-by: ankan94 <51693147+ankan94@users.noreply.github.com> Co-authored-by: Shrinath Suresh <shrinath@ideas2it.com> Co-authored-by: harupy <17039389+harupy@users.noreply.github.com> Co-authored-by: dbczumar <39497902+dbczumar@users.noreply.github.com> Co-authored-by: mlflow-automation <61449322+mlflow-automation@users.noreply.github.com> Co-authored-by: Jenkins <jenkins@databricks.com> Co-authored-by: Martynov Maxim <msmarty5@mts.ru> Co-authored-by: Harutaka Kawamura <hkawamura0130@gmail.com> Signed-off-by: harupy <17039389+harupy@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes are proposed in this pull request?
This PR modularizes our autologging utilities, decomposing
mlflow.utils.autologging_utilsinto 3 submodules:events,versioning, andsafety. It also removes the leading underscore (_) prefix from certain autologging utilities that are consumed outside of the module in which they're defined.How is this patch tested?
Unit tests
Release Notes
Is this a user-facing change?
What component(s), interfaces, languages, and integrations does this PR affect?
Components
area/artifacts: Artifact stores and artifact loggingarea/build: Build and test infrastructure for MLflowarea/docs: MLflow documentation pagesarea/examples: Example codearea/model-registry: Model Registry service, APIs, and the fluent client calls for Model Registryarea/models: MLmodel format, model serialization/deserialization, flavorsarea/projects: MLproject format, project running backendsarea/scoring: Local serving, model deployment tools, spark UDFsarea/server-infra: MLflow server, JavaScript dev serverarea/tracking: Tracking Service, tracking client APIs, autologgingInterface
area/uiux: Front-end, user experience, JavaScript, plottingarea/docker: Docker use across MLflow's components, such as MLflow Projects and MLflow Modelsarea/sqlalchemy: Use of SQLAlchemy in the Tracking Service or Model Registryarea/windows: Windows supportLanguage
language/r: R APIs and clientslanguage/java: Java APIs and clientslanguage/new: Proposals for new client languagesIntegrations
integrations/azure: Azure and Azure ML integrationsintegrations/sagemaker: SageMaker integrationsintegrations/databricks: Databricks integrationsHow should the PR be classified in the release notes? Choose one:
rn/breaking-change- The PR will be mentioned in the "Breaking Changes" sectionrn/none- No description will be included. The PR will be mentioned only by the PR number in the "Small Bugfixes and Documentation Updates" sectionrn/feature- A new user-facing feature worth mentioning in the release notesrn/bug-fix- A user-facing bug fix worth mentioning in the release notesrn/documentation- A user-facing documentation change worth mentioning in the release notes