Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix autologging silent mode bugs #4231

Merged
merged 2 commits into from
Apr 15, 2021
Merged

Conversation

dbczumar
Copy link
Collaborator

@dbczumar dbczumar commented Apr 8, 2021

Signed-off-by: dbczumar corey.zumar@databricks.com

What changes are proposed in this pull request?

MLflow 1.15 introduced the following bugs:

  • The silent=True/False option introduced to autologging in MLflow 1.15 does not respect disable=True. As a result, when autologging is disabled via mlflow.autolog(disable=True, silent=True), warnings from ML frameworks are suppressed.

  • Similarly, warning rerouting intended for the autologging preamble / postamble also does not respect disable=True. As a result, when autologging is disabled via mlflow.autolog(disable=True, silent=False), warnings from ML frameworks are rerouted to the MLflow event logger.

This PR fixes these issues & adds test coverage ensuring that they do not recur.

How is this patch tested?

  • Included unit test coverage

Release Notes

Fix errors causing autologging silent mode to be enforced even when autologging is disabled by the user.

Is this a user-facing change?

  • No. You can skip the rest of this section.
  • Yes. Give a description of this change to be included in the release notes for MLflow users.

What component(s), interfaces, languages, and integrations does this PR affect?

Components

  • area/artifacts: Artifact stores and artifact logging
  • area/build: Build and test infrastructure for MLflow
  • area/docs: MLflow documentation pages
  • area/examples: Example code
  • area/model-registry: Model Registry service, APIs, and the fluent client calls for Model Registry
  • area/models: MLmodel format, model serialization/deserialization, flavors
  • area/projects: MLproject format, project running backends
  • area/scoring: Local serving, model deployment tools, spark UDFs
  • area/server-infra: MLflow server, JavaScript dev server
  • area/tracking: Tracking Service, tracking client APIs, autologging

Interface

  • area/uiux: Front-end, user experience, JavaScript, plotting
  • area/docker: Docker use across MLflow's components, such as MLflow Projects and MLflow Models
  • area/sqlalchemy: Use of SQLAlchemy in the Tracking Service or Model Registry
  • area/windows: Windows support

Language

  • language/r: R APIs and clients
  • language/java: Java APIs and clients
  • language/new: Proposals for new client languages

Integrations

  • integrations/azure: Azure and Azure ML integrations
  • integrations/sagemaker: SageMaker integrations
  • integrations/databricks: Databricks integrations

How should the PR be classified in the release notes? Choose one:

  • rn/breaking-change - The PR will be mentioned in the "Breaking Changes" section
  • rn/none - No description will be included. The PR will be mentioned only by the PR number in the "Small Bugfixes and Documentation Updates" section
  • rn/feature - A new user-facing feature worth mentioning in the release notes
  • rn/bug-fix - A user-facing bug fix worth mentioning in the release notes
  • rn/documentation - A user-facing documentation change worth mentioning in the release notes

Signed-off-by: dbczumar <corey.zumar@databricks.com>
@github-actions github-actions bot added area/tracking Tracking service, tracking client APIs, autologging rn/bug-fix Mention under Bug Fixes in Changelogs. labels Apr 8, 2021
@dbczumar dbczumar requested a review from jinzhang21 April 8, 2021 17:36
# fluent run is active, call the original function and return. Restore the original
# warning behavior during original function execution, since autologging is being
# skipped
with set_non_mlflow_warnings_behavior_for_current_thread(
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another option would be to move the context manager entry statements from above down below this logic. However, that leaves a small risk of us leaking logger / warning statements from this section of the code.

Copy link
Collaborator

@jinzhang21 jinzhang21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@dbczumar dbczumar merged commit 9187181 into mlflow:master Apr 15, 2021
YQ-Wang pushed a commit to YQ-Wang/mlflow that referenced this pull request May 29, 2021
Signed-off-by: dbczumar <corey.zumar@databricks.com>
Signed-off-by: Yiqing Wang <yiqing@wangemail.com>
harupy pushed a commit to wamartin-aml/mlflow that referenced this pull request Jun 7, 2021
Signed-off-by: dbczumar <corey.zumar@databricks.com>
Signed-off-by: harupy <17039389+harupy@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/tracking Tracking service, tracking client APIs, autologging rn/bug-fix Mention under Bug Fixes in Changelogs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants