Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add spark model export tests in cross version tests #4247

Merged
merged 9 commits into from
Apr 15, 2021

Conversation

harupy
Copy link
Member

@harupy harupy commented Apr 14, 2021

Signed-off-by: harupy 17039389+harupy@users.noreply.github.com

What changes are proposed in this pull request?

Add cross version tests for the spark model serialization APIs

How is this patch tested?

Existing unit tests

Release Notes

Is this a user-facing change?

  • No. You can skip the rest of this section.
  • Yes. Give a description of this change to be included in the release notes for MLflow users.

(Details in 1-2 sentences. You can just refer to another PR with a description if this PR is part of a larger change.)

What component(s), interfaces, languages, and integrations does this PR affect?

Components

  • area/artifacts: Artifact stores and artifact logging
  • area/build: Build and test infrastructure for MLflow
  • area/docs: MLflow documentation pages
  • area/examples: Example code
  • area/model-registry: Model Registry service, APIs, and the fluent client calls for Model Registry
  • area/models: MLmodel format, model serialization/deserialization, flavors
  • area/projects: MLproject format, project running backends
  • area/scoring: Local serving, model deployment tools, spark UDFs
  • area/server-infra: MLflow server, JavaScript dev server
  • area/tracking: Tracking Service, tracking client APIs, autologging

Interface

  • area/uiux: Front-end, user experience, JavaScript, plotting
  • area/docker: Docker use across MLflow's components, such as MLflow Projects and MLflow Models
  • area/sqlalchemy: Use of SQLAlchemy in the Tracking Service or Model Registry
  • area/windows: Windows support

Language

  • language/r: R APIs and clients
  • language/java: Java APIs and clients
  • language/new: Proposals for new client languages

Integrations

  • integrations/azure: Azure and Azure ML integrations
  • integrations/sagemaker: SageMaker integrations
  • integrations/databricks: Databricks integrations

How should the PR be classified in the release notes? Choose one:

  • rn/breaking-change - The PR will be mentioned in the "Breaking Changes" section
  • rn/none - No description will be included. The PR will be mentioned only by the PR number in the "Small Bugfixes and Documentation Updates" section
  • rn/feature - A new user-facing feature worth mentioning in the release notes
  • rn/bug-fix - A user-facing bug fix worth mentioning in the release notes
  • rn/documentation - A user-facing documentation change worth mentioning in the release notes

Signed-off-by: harupy <17039389+harupy@users.noreply.github.com>
@harupy harupy marked this pull request as draft April 14, 2021 08:38
@github-actions github-actions bot added the rn/none List under Small Changes in Changelogs. label Apr 14, 2021
Signed-off-by: harupy <17039389+harupy@users.noreply.github.com>
Signed-off-by: harupy <17039389+harupy@users.noreply.github.com>
Signed-off-by: harupy <17039389+harupy@users.noreply.github.com>
Signed-off-by: harupy <17039389+harupy@users.noreply.github.com>
Signed-off-by: harupy <17039389+harupy@users.noreply.github.com>
Signed-off-by: harupy <17039389+harupy@users.noreply.github.com>
Signed-off-by: harupy <17039389+harupy@users.noreply.github.com>
@harupy harupy marked this pull request as ready for review April 14, 2021 09:59
Signed-off-by: harupy <17039389+harupy@users.noreply.github.com>
@harupy harupy merged commit 6bbd93e into mlflow:master Apr 15, 2021
@harupy harupy deleted the cross-spark-model branch April 15, 2021 11:07
YQ-Wang pushed a commit to YQ-Wang/mlflow that referenced this pull request May 29, 2021
* Add spark model export tests in cross version tests

Signed-off-by: harupy <17039389+harupy@users.noreply.github.com>

* Add sklearn

Signed-off-by: harupy <17039389+harupy@users.noreply.github.com>

* add pyarrow

Signed-off-by: harupy <17039389+harupy@users.noreply.github.com>

* build docker image

Signed-off-by: harupy <17039389+harupy@users.noreply.github.com>

* fix

Signed-off-by: harupy <17039389+harupy@users.noreply.github.com>

* fix indent

Signed-off-by: harupy <17039389+harupy@users.noreply.github.com>

* trigger ci

Signed-off-by: harupy <17039389+harupy@users.noreply.github.com>

* remove useless comment

Signed-off-by: harupy <17039389+harupy@users.noreply.github.com>

* Add exit 1

Signed-off-by: harupy <17039389+harupy@users.noreply.github.com>
Signed-off-by: Yiqing Wang <yiqing@wangemail.com>
harupy added a commit to wamartin-aml/mlflow that referenced this pull request Jun 7, 2021
* Add spark model export tests in cross version tests

Signed-off-by: harupy <17039389+harupy@users.noreply.github.com>

* Add sklearn

Signed-off-by: harupy <17039389+harupy@users.noreply.github.com>

* add pyarrow

Signed-off-by: harupy <17039389+harupy@users.noreply.github.com>

* build docker image

Signed-off-by: harupy <17039389+harupy@users.noreply.github.com>

* fix

Signed-off-by: harupy <17039389+harupy@users.noreply.github.com>

* fix indent

Signed-off-by: harupy <17039389+harupy@users.noreply.github.com>

* trigger ci

Signed-off-by: harupy <17039389+harupy@users.noreply.github.com>

* remove useless comment

Signed-off-by: harupy <17039389+harupy@users.noreply.github.com>

* Add exit 1

Signed-off-by: harupy <17039389+harupy@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rn/none List under Small Changes in Changelogs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants