-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add argument type annotations #4255
Conversation
Signed-off-by: harupy <17039389+harupy@users.noreply.github.com>
Signed-off-by: harupy <17039389+harupy@users.noreply.github.com>
mlflow/entities/view_type.py
Outdated
|
||
|
||
class ViewType(object): | ||
class ViewType(Enum): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Refactored ViewType
using Enum
to use it to annotate run_view_type
in search_runs
.
Signed-off-by: harupy <17039389+harupy@users.noreply.github.com>
8f897e6
to
411fc36
Compare
def log_figure( | ||
self, | ||
run_id: str, | ||
figure: Union["matplotlib.figure.Figure", "plotly.graph_objects.Figure"], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does these string type names "matplotlib.figure.Figure", "plotly.graph_objects.Figure"
works when IDE like pycharm checking type error ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think it works. I think we need to add the following import statements:
try:
# These packages might not be installed
import matplotlib
import ploly
except ImportError:
...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why only annotate the tracking module ?
It's because users interact with the tracking module the most. Ideally, we should annotate everything, but it requires a large amount of work. |
Signed-off-by: harupy <17039389+harupy@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally LGTM, only minor comments
Signed-off-by: harupy <17039389+harupy@users.noreply.github.com>
@@ -630,7 +642,7 @@ def print_run_info(r): | |||
""" | |||
self._tracking_client.log_metric(run_id, key, value, timestamp, step) | |||
|
|||
def log_param(self, run_id, key, value) -> None: | |||
def log_param(self, run_id: str, key: str, value: Any) -> None: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note value
will be converted to string via str(value)
.
Signed-off-by: harupy <17039389+harupy@users.noreply.github.com>
Signed-off-by: harupy <17039389+harupy@users.noreply.github.com>
Signed-off-by: harupy <17039389+harupy@users.noreply.github.com>
mlflow/tracking/fluent.py
Outdated
if TYPE_CHECKING: | ||
import matplotlib # pylint: disable=unused-import | ||
import plotly # pylint: disable=unused-import | ||
import PIL # pylint: disable=unused-import | ||
import numpy # pylint: disable=unused-import | ||
import pandas # pylint: disable=unused-import |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This block is not executed at run time: https://docs.python.org/3/library/typing.html#typing.TYPE_CHECKING
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* Add argument type hints Signed-off-by: harupy <17039389+harupy@users.noreply.github.com> * Fix doc build Signed-off-by: harupy <17039389+harupy@users.noreply.github.com> * autolog Signed-off-by: harupy <17039389+harupy@users.noreply.github.com> * Fix run_view_type Signed-off-by: harupy <17039389+harupy@users.noreply.github.com> * fix log_dict Signed-off-by: harupy <17039389+harupy@users.noreply.github.com> * bytes -> str Signed-off-by: harupy <17039389+harupy@users.noreply.github.com> * Use TYPE_CHECKING Signed-off-by: harupy <17039389+harupy@users.noreply.github.com> * use TYPE_CHECKING Signed-off-by: harupy <17039389+harupy@users.noreply.github.com> * Ignore pandas.DataFrame Signed-off-by: harupy <17039389+harupy@users.noreply.github.com> * fix order Signed-off-by: harupy <17039389+harupy@users.noreply.github.com> Signed-off-by: Yiqing Wang <yiqing@wangemail.com>
* Add argument type hints Signed-off-by: harupy <17039389+harupy@users.noreply.github.com> * Fix doc build Signed-off-by: harupy <17039389+harupy@users.noreply.github.com> * autolog Signed-off-by: harupy <17039389+harupy@users.noreply.github.com> * Fix run_view_type Signed-off-by: harupy <17039389+harupy@users.noreply.github.com> * fix log_dict Signed-off-by: harupy <17039389+harupy@users.noreply.github.com> * bytes -> str Signed-off-by: harupy <17039389+harupy@users.noreply.github.com> * Use TYPE_CHECKING Signed-off-by: harupy <17039389+harupy@users.noreply.github.com> * use TYPE_CHECKING Signed-off-by: harupy <17039389+harupy@users.noreply.github.com> * Ignore pandas.DataFrame Signed-off-by: harupy <17039389+harupy@users.noreply.github.com> * fix order Signed-off-by: harupy <17039389+harupy@users.noreply.github.com>
* Add argument type hints Signed-off-by: harupy <17039389+harupy@users.noreply.github.com> * Fix doc build Signed-off-by: harupy <17039389+harupy@users.noreply.github.com> * autolog Signed-off-by: harupy <17039389+harupy@users.noreply.github.com> * Fix run_view_type Signed-off-by: harupy <17039389+harupy@users.noreply.github.com> * fix log_dict Signed-off-by: harupy <17039389+harupy@users.noreply.github.com> * bytes -> str Signed-off-by: harupy <17039389+harupy@users.noreply.github.com> * Use TYPE_CHECKING Signed-off-by: harupy <17039389+harupy@users.noreply.github.com> * use TYPE_CHECKING Signed-off-by: harupy <17039389+harupy@users.noreply.github.com> * Ignore pandas.DataFrame Signed-off-by: harupy <17039389+harupy@users.noreply.github.com> * fix order Signed-off-by: harupy <17039389+harupy@users.noreply.github.com>
* Add argument type hints Signed-off-by: harupy <17039389+harupy@users.noreply.github.com> * Fix doc build Signed-off-by: harupy <17039389+harupy@users.noreply.github.com> * autolog Signed-off-by: harupy <17039389+harupy@users.noreply.github.com> * Fix run_view_type Signed-off-by: harupy <17039389+harupy@users.noreply.github.com> * fix log_dict Signed-off-by: harupy <17039389+harupy@users.noreply.github.com> * bytes -> str Signed-off-by: harupy <17039389+harupy@users.noreply.github.com> * Use TYPE_CHECKING Signed-off-by: harupy <17039389+harupy@users.noreply.github.com> * use TYPE_CHECKING Signed-off-by: harupy <17039389+harupy@users.noreply.github.com> * Ignore pandas.DataFrame Signed-off-by: harupy <17039389+harupy@users.noreply.github.com> * fix order Signed-off-by: harupy <17039389+harupy@users.noreply.github.com>
* Initial set of changes to add list exp page token Signed-off-by: Walter Martin <wamartin@microsoft.com> Signed-off-by: harupy <17039389+harupy@users.noreply.github.com> * add intial testing, none for rest store Signed-off-by: Walter Martin <wamartin@microsoft.com> Signed-off-by: harupy <17039389+harupy@users.noreply.github.com> * quick variable fix Signed-off-by: Walter Martin <wamartin@microsoft.com> Signed-off-by: harupy <17039389+harupy@users.noreply.github.com> * linting fixes Signed-off-by: Walter Martin <wamartin@microsoft.com> Signed-off-by: harupy <17039389+harupy@users.noreply.github.com> * proto generation - someone check this pls Signed-off-by: Walter Martin <wamartin@microsoft.com> Signed-off-by: harupy <17039389+harupy@users.noreply.github.com> * fix comment Signed-off-by: Walter Martin <wamartin@microsoft.com> Signed-off-by: harupy <17039389+harupy@users.noreply.github.com> * adding _get_experiment back after accidental delete Signed-off-by: Walter Martin <wamartin@microsoft.com> Signed-off-by: harupy <17039389+harupy@users.noreply.github.com> * fix tests and page size limit check Signed-off-by: Walter Martin <wamartin@microsoft.com> Signed-off-by: harupy <17039389+harupy@users.noreply.github.com> * fix null token problem Signed-off-by: Walter Martin <wamartin@microsoft.com> Signed-off-by: harupy <17039389+harupy@users.noreply.github.com> * reformatting Signed-off-by: Walter Martin <wamartin@microsoft.com> Signed-off-by: harupy <17039389+harupy@users.noreply.github.com> * protos generated Signed-off-by: Walter Martin <wamartin@microsoft.com> Signed-off-by: harupy <17039389+harupy@users.noreply.github.com> * [HOT FIX] skip `test` job if matrix ends up being empty in cross version tests (#3800) * skip if the matrix is empty Signed-off-by: harupy <17039389+harupy@users.noreply.github.com> * set is_matrix_empty Signed-off-by: harupy <17039389+harupy@users.noreply.github.com> * fix syntax error Signed-off-by: harupy <17039389+harupy@users.noreply.github.com> * minor comment fix Signed-off-by: harupy <17039389+harupy@users.noreply.github.com> * Allow using post releases in the cross version tests (#3807) * Fix for xgboost 1.3.0 Signed-off-by: harupy <17039389+harupy@users.noreply.github.com> * do not include 1.3.0 since it has been removed Signed-off-by: harupy <17039389+harupy@users.noreply.github.com> * re-run all the tests if set_matrix contains changes Signed-off-by: harupy <17039389+harupy@users.noreply.github.com> * nit Signed-off-by: harupy <17039389+harupy@users.noreply.github.com> * fix regexp Signed-off-by: harupy <17039389+harupy@users.noreply.github.com> * add test case Signed-off-by: harupy <17039389+harupy@users.noreply.github.com> * Refactor using packaging Signed-off-by: harupy <17039389+harupy@users.noreply.github.com> * add packaging Signed-off-by: harupy <17039389+harupy@users.noreply.github.com> * nit Signed-off-by: harupy <17039389+harupy@users.noreply.github.com> * Introduce utilities for autologging error tolerance / safety (#3682) * Safe Signed-off-by: Corey Zumar <corey.zumar@databricks.com> * Keras Signed-off-by: Corey Zumar <corey.zumar@databricks.com> * Lint Signed-off-by: Corey Zumar <corey.zumar@databricks.com> * TF Signed-off-by: Corey Zumar <corey.zumar@databricks.com> * Fixes Signed-off-by: Corey Zumar <corey.zumar@databricks.com> * Lint Signed-off-by: Corey Zumar <corey.zumar@databricks.com> * Some unit tests Signed-off-by: Corey Zumar <corey.zumar@databricks.com> * More unit tests Signed-off-by: Corey Zumar <corey.zumar@databricks.com> * Test coverage for safe_patch Signed-off-by: Corey Zumar <corey.zumar@databricks.com> * Add public API for autologging integration configs Signed-off-by: Mohamad Arabi <mohamad.arabi@databricks.com> Signed-off-by: Corey Zumar <corey.zumar@databricks.com> * Remove big comment Signed-off-by: Corey Zumar <corey.zumar@databricks.com> * Conf tests Signed-off-by: Corey Zumar <corey.zumar@databricks.com> * Tests Signed-off-by: Corey Zumar <corey.zumar@databricks.com> * Mark large Signed-off-by: Corey Zumar <corey.zumar@databricks.com> * Whitespace Signed-off-by: Corey Zumar <corey.zumar@databricks.com> * Blackspace Signed-off-by: Corey Zumar <corey.zumar@databricks.com> * Rename Signed-off-by: Corey Zumar <corey.zumar@databricks.com> * Simplify, will raise integrations as separate PR Signed-off-by: Corey Zumar <corey.zumar@databricks.com> * Lint Signed-off-by: Corey Zumar <corey.zumar@databricks.com> * Black Signed-off-by: Corey Zumar <corey.zumar@databricks.com> * Remove test_mode_off for now Signed-off-by: Corey Zumar <corey.zumar@databricks.com> * Support positional arguments Signed-off-by: Corey Zumar <corey.zumar@databricks.com> * Docstring fix Signed-off-by: Corey Zumar <corey.zumar@databricks.com> * use match instead of comparison to str(exc) Signed-off-by: Corey Zumar <corey.zumar@databricks.com> * Black Signed-off-by: Corey Zumar <corey.zumar@databricks.com> * Forward args Signed-off-by: Corey Zumar <corey.zumar@databricks.com> * Lint Signed-off-by: Corey Zumar <corey.zumar@databricks.com> * Try importing mock from unittest? Signed-off-by: Corey Zumar <corey.zumar@databricks.com> * Fix import mock in statsmodel Signed-off-by: Corey Zumar <corey.zumar@databricks.com> * Revert "Fix import mock in statsmodel" This reverts commit a81e810. Signed-off-by: Corey Zumar <corey.zumar@databricks.com> * Black Signed-off-by: Corey Zumar <corey.zumar@databricks.com> * Support tuple Signed-off-by: Corey Zumar <corey.zumar@databricks.com> * Address more comments Signed-off-by: Corey Zumar <corey.zumar@databricks.com> * Stop patching log_param Signed-off-by: Corey Zumar <corey.zumar@databricks.com> Co-authored-by: Mohamad Arabi <mohamad.arabi@databricks.com> Signed-off-by: harupy <17039389+harupy@users.noreply.github.com> * reject bool metric value (#3822) * reject bool metric value Signed-off-by: Halil Coban <halil.coban@gmail.com> * add comment on why we check for bool Signed-off-by: Halil Coban <halil.coban@gmail.com> Signed-off-by: harupy <17039389+harupy@users.noreply.github.com> * Fix invalid metric error in statsmodels tests (#3828) * Fix invalid metric issue in statsmodels flavor Signed-off-by: harupy <17039389+harupy@users.noreply.github.com> * Introduce _is_numeric Signed-off-by: harupy <17039389+harupy@users.noreply.github.com> * Add autologging safety utils to several autologging integrations (#3815) * Safe Signed-off-by: Corey Zumar <corey.zumar@databricks.com> * Keras Signed-off-by: Corey Zumar <corey.zumar@databricks.com> * Lint Signed-off-by: Corey Zumar <corey.zumar@databricks.com> * TF Signed-off-by: Corey Zumar <corey.zumar@databricks.com> * Fixes Signed-off-by: Corey Zumar <corey.zumar@databricks.com> * Lint Signed-off-by: Corey Zumar <corey.zumar@databricks.com> * Some unit tests Signed-off-by: Corey Zumar <corey.zumar@databricks.com> * More unit tests Signed-off-by: Corey Zumar <corey.zumar@databricks.com> * Test coverage for safe_patch Signed-off-by: Corey Zumar <corey.zumar@databricks.com> * Add public API for autologging integration configs Signed-off-by: Mohamad Arabi <mohamad.arabi@databricks.com> Signed-off-by: Corey Zumar <corey.zumar@databricks.com> * Remove big comment Signed-off-by: Corey Zumar <corey.zumar@databricks.com> * Conf tests Signed-off-by: Corey Zumar <corey.zumar@databricks.com> * Tests Signed-off-by: Corey Zumar <corey.zumar@databricks.com> * Mark large Signed-off-by: Corey Zumar <corey.zumar@databricks.com> * Whitespace Signed-off-by: Corey Zumar <corey.zumar@databricks.com> * Blackspace Signed-off-by: Corey Zumar <corey.zumar@databricks.com> * Rename Signed-off-by: Corey Zumar <corey.zumar@databricks.com> * Simplify, will raise integrations as separate PR Signed-off-by: Corey Zumar <corey.zumar@databricks.com> * Remove partial tensorflow Signed-off-by: Corey Zumar <corey.zumar@databricks.com> * Lint Signed-off-by: Corey Zumar <corey.zumar@databricks.com> * Black Signed-off-by: Corey Zumar <corey.zumar@databricks.com> * Updates from utils Signed-off-by: Corey Zumar <corey.zumar@databricks.com> * Remove test_mode_off for now Signed-off-by: Corey Zumar <corey.zumar@databricks.com> * Support positional arguments Signed-off-by: Corey Zumar <corey.zumar@databricks.com> * Docstring fix Signed-off-by: Corey Zumar <corey.zumar@databricks.com> * use match instead of comparison to str(exc) Signed-off-by: Corey Zumar <corey.zumar@databricks.com> * Black Signed-off-by: Corey Zumar <corey.zumar@databricks.com> * Forward args Signed-off-by: Corey Zumar <corey.zumar@databricks.com> * Fixes from #3682 Signed-off-by: Corey Zumar <corey.zumar@databricks.com> * integration start Signed-off-by: Corey Zumar <corey.zumar@databricks.com> * Lint Signed-off-by: Corey Zumar <corey.zumar@databricks.com> * Try importing mock from unittest? Signed-off-by: Corey Zumar <corey.zumar@databricks.com> * Fix import mock in statsmodel Signed-off-by: Corey Zumar <corey.zumar@databricks.com> * Mock fix Signed-off-by: Corey Zumar <corey.zumar@databricks.com> * Revert "Fix import mock in statsmodel" This reverts commit a81e810. Signed-off-by: Corey Zumar <corey.zumar@databricks.com> * Black Signed-off-by: Corey Zumar <corey.zumar@databricks.com> * Support tuple Signed-off-by: Corey Zumar <corey.zumar@databricks.com> * Address more comments Signed-off-by: Corey Zumar <corey.zumar@databricks.com> * Stop patching log_param Signed-off-by: Corey Zumar <corey.zumar@databricks.com> * Modules Signed-off-by: Corey Zumar <corey.zumar@databricks.com> * Another test, enable test mode broadly Signed-off-by: Corey Zumar <corey.zumar@databricks.com> * Black Signed-off-by: Corey Zumar <corey.zumar@databricks.com> * Fix Signed-off-by: Corey Zumar <corey.zumar@databricks.com> * Move to fixture Signed-off-by: Corey Zumar <corey.zumar@databricks.com> * Docstring Signed-off-by: Corey Zumar <corey.zumar@databricks.com> * Use test mode for try_mlflow_log Signed-off-by: Corey Zumar <corey.zumar@databricks.com> * Test try_mlflow_log Signed-off-by: Corey Zumar <corey.zumar@databricks.com> * Docs Signed-off-by: Corey Zumar <corey.zumar@databricks.com> * Assert Signed-off-by: Corey Zumar <corey.zumar@databricks.com> * Try log keras Signed-off-by: Corey Zumar <corey.zumar@databricks.com> * Review comment, add init for tests Signed-off-by: Corey Zumar <corey.zumar@databricks.com> * Lint Signed-off-by: Corey Zumar <corey.zumar@databricks.com> * Actually commit the fixtures file... Signed-off-by: Corey Zumar <corey.zumar@databricks.com> * Test fixes, lint Signed-off-by: Corey Zumar <corey.zumar@databricks.com> * Fix, format Signed-off-by: Corey Zumar <corey.zumar@databricks.com> * Fix fast.ai Signed-off-by: Corey Zumar <corey.zumar@databricks.com> * Lintfix Signed-off-by: Corey Zumar <corey.zumar@databricks.com> * Lint Signed-off-by: Corey Zumar <corey.zumar@databricks.com> * Docstrings Signed-off-by: Corey Zumar <corey.zumar@databricks.com> * Address nit Signed-off-by: Corey Zumar <corey.zumar@databricks.com> * Lint Signed-off-by: Corey Zumar <corey.zumar@databricks.com> Co-authored-by: Mohamad Arabi <mohamad.arabi@databricks.com> Signed-off-by: harupy <17039389+harupy@users.noreply.github.com> * Add disable=True/False flag for Spark autologging (#3838) * Safe Signed-off-by: Corey Zumar <corey.zumar@databricks.com> * Keras Signed-off-by: Corey Zumar <corey.zumar@databricks.com> * Lint Signed-off-by: Corey Zumar <corey.zumar@databricks.com> * TF Signed-off-by: Corey Zumar <corey.zumar@databricks.com> * Fixes Signed-off-by: Corey Zumar <corey.zumar@databricks.com> * Lint Signed-off-by: Corey Zumar <corey.zumar@databricks.com> * Some unit tests Signed-off-by: Corey Zumar <corey.zumar@databricks.com> * Add public API for autologging integration configs Signed-off-by: Mohamad Arabi <mohamad.arabi@databricks.com> * More unit tests Signed-off-by: Corey Zumar <corey.zumar@databricks.com> * Test coverage for safe_patch Signed-off-by: Corey Zumar <corey.zumar@databricks.com> * Add public API for autologging integration configs Signed-off-by: Mohamad Arabi <mohamad.arabi@databricks.com> Signed-off-by: Corey Zumar <corey.zumar@databricks.com> * Remove big comment Signed-off-by: Corey Zumar <corey.zumar@databricks.com> * Conf tests Signed-off-by: Corey Zumar <corey.zumar@databricks.com> * Tests Signed-off-by: Corey Zumar <corey.zumar@databricks.com> * Mark large Signed-off-by: Corey Zumar <corey.zumar@databricks.com> * Whitespace Signed-off-by: Corey Zumar <corey.zumar@databricks.com> * Blackspace Signed-off-by: Corey Zumar <corey.zumar@databricks.com> * Rename Signed-off-by: Corey Zumar <corey.zumar@databricks.com> * Simplify, will raise integrations as separate PR Signed-off-by: Corey Zumar <corey.zumar@databricks.com> * Lint Signed-off-by: Corey Zumar <corey.zumar@databricks.com> * Black Signed-off-by: Corey Zumar <corey.zumar@databricks.com> * Remove test_mode_off for now Signed-off-by: Corey Zumar <corey.zumar@databricks.com> * Support positional arguments Signed-off-by: Corey Zumar <corey.zumar@databricks.com> * Docstring fix Signed-off-by: Corey Zumar <corey.zumar@databricks.com> * use match instead of comparison to str(exc) Signed-off-by: Corey Zumar <corey.zumar@databricks.com> * Black Signed-off-by: Corey Zumar <corey.zumar@databricks.com> * Forward args Signed-off-by: Corey Zumar <corey.zumar@databricks.com> * Lint Signed-off-by: Corey Zumar <corey.zumar@databricks.com> * Try importing mock from unittest? Signed-off-by: Corey Zumar <corey.zumar@databricks.com> * Fix import mock in statsmodel Signed-off-by: Corey Zumar <corey.zumar@databricks.com> * Revert "Fix import mock in statsmodel" This reverts commit a81e810. Signed-off-by: Corey Zumar <corey.zumar@databricks.com> * Black Signed-off-by: Corey Zumar <corey.zumar@databricks.com> * Add support for disabling spark autologging Signed-off-by: Mohamad Arabi <mohamad.arabi@databricks.com> * Remove unused method Signed-off-by: Mohamad Arabi <mohamad.arabi@databricks.com> * Remove unused method part 2 Signed-off-by: Mohamad Arabi <mohamad.arabi@databricks.com> * add test case for before spark session Signed-off-by: Mohamad Arabi <mohamad.arabi@databricks.com> * unnecessary change Signed-off-by: Mohamad Arabi <mohamad.arabi@databricks.com> * modify comment Signed-off-by: Mohamad Arabi <mohamad.arabi@databricks.com> * cannot assign FLAVOR_NAME in _spark_autolgging.py Signed-off-by: Mohamad Arabi <mohamad.arabi@databricks.com> * address final comments Signed-off-by: Mohamad Arabi <mohamad.arabi@databricks.com> * fix api documentation Signed-off-by: Mohamad Arabi <mohamad.arabi@databricks.com> * fix api documentation II Signed-off-by: Mohamad Arabi <mohamad.arabi@databricks.com> Co-authored-by: Corey Zumar <corey.zumar@databricks.com> Signed-off-by: harupy <17039389+harupy@users.noreply.github.com> * Fix ONNX and TF test failures (#3844) * ONNX fixes Signed-off-by: Corey Zumar <corey.zumar@databricks.com> * Fixture fix Signed-off-by: Corey Zumar <corey.zumar@databricks.com> * Test fix Signed-off-by: Corey Zumar <corey.zumar@databricks.com> * Use correct resources Signed-off-by: Corey Zumar <corey.zumar@databricks.com> * ONNX model files Signed-off-by: Corey Zumar <corey.zumar@databricks.com> * fix imports Signed-off-by: Corey Zumar <corey.zumar@databricks.com> * Fix spark line length Signed-off-by: Corey Zumar <corey.zumar@databricks.com> * Add resource generation script Signed-off-by: Corey Zumar <corey.zumar@databricks.com> * Comment Signed-off-by: Corey Zumar <corey.zumar@databricks.com> * Lint Signed-off-by: Corey Zumar <corey.zumar@databricks.com> Signed-off-by: harupy <17039389+harupy@users.noreply.github.com> * Add autologging safety utils to LightGBM integration (#3833) * Add autologging safety utils to LightGBM integration Signed-off-by: harupy <17039389+harupy@users.noreply.github.com> * lint Signed-off-by: harupy <17039389+harupy@users.noreply.github.com> * address comment Signed-off-by: harupy <17039389+harupy@users.noreply.github.com> * Add autologging safety utils to gluon (#3854) * Apply safe patch utils to gluon Signed-off-by: harupy <17039389+harupy@users.noreply.github.com> * revert unrelated change Signed-off-by: harupy <17039389+harupy@users.noreply.github.com> * revert unrelated change Signed-off-by: harupy <17039389+harupy@users.noreply.github.com> * lint Signed-off-by: harupy <17039389+harupy@users.noreply.github.com> * docstring Signed-off-by: harupy <17039389+harupy@users.noreply.github.com> * Set tags on autologged runs for easy identification (and add tags to start_run) (#3847) * Progress Signed-off-by: Corey Zumar <corey.zumar@databricks.com> * Partial Signed-off-by: Corey Zumar <corey.zumar@databricks.com> * Test case Signed-off-by: Corey Zumar <corey.zumar@databricks.com> * Test case Signed-off-by: Corey Zumar <corey.zumar@databricks.com> * Test case Signed-off-by: Corey Zumar <corey.zumar@databricks.com> * Test scaffolding Signed-off-by: Corey Zumar <corey.zumar@databricks.com> * Progress Signed-off-by: Corey Zumar <corey.zumar@databricks.com> * Tests Signed-off-by: Corey Zumar <corey.zumar@databricks.com> * Fix fluent test Signed-off-by: Corey Zumar <corey.zumar@databricks.com> * Lint Signed-off-by: Corey Zumar <corey.zumar@databricks.com> * Sklearn Signed-off-by: Corey Zumar <corey.zumar@databricks.com> Signed-off-by: harupy <17039389+harupy@users.noreply.github.com> * Add autologging safety utils to pytorch integration (#3855) * Add autologging safety utils to pytorch integration Signed-off-by: harupy <17039389+harupy@users.noreply.github.com> * lint Signed-off-by: harupy <17039389+harupy@users.noreply.github.com> * Add ExceptionSafeAbstractClass Signed-off-by: harupy <17039389+harupy@users.noreply.github.com> * nit Signed-off-by: harupy <17039389+harupy@users.noreply.github.com> * docstring and rename Signed-off-by: harupy <17039389+harupy@users.noreply.github.com> * decorate autolog not _autolog Signed-off-by: harupy <17039389+harupy@users.noreply.github.com> * docstring Signed-off-by: harupy <17039389+harupy@users.noreply.github.com> * lint Signed-off-by: harupy <17039389+harupy@users.noreply.github.com> * class -> metaclass Signed-off-by: harupy <17039389+harupy@users.noreply.github.com> * disable invalid-metaclass Signed-off-by: harupy <17039389+harupy@users.noreply.github.com> * update tests Signed-off-by: harupy <17039389+harupy@users.noreply.github.com> * patch in __init__ Signed-off-by: harupy <17039389+harupy@users.noreply.github.com> * Fix max-line-length error Signed-off-by: harupy <17039389+harupy@users.noreply.github.com> * Comment on why we ignore invalid-metaclass error Signed-off-by: harupy <17039389+harupy@users.noreply.github.com> * nit Signed-off-by: harupy <17039389+harupy@users.noreply.github.com> * docstring Signed-off-by: harupy <17039389+harupy@users.noreply.github.com> * nit Signed-off-by: harupy <17039389+harupy@users.noreply.github.com> * comment Signed-off-by: harupy <17039389+harupy@users.noreply.github.com> * rename Signed-off-by: harupy <17039389+harupy@users.noreply.github.com> * API code snippets for fastai model (#3850) * Added short code snippets for autolog and get_default_env Signed-off-by: Jules Damji <dmatrix@comcast.net> * Added short code snippets for log_model, save_model, load_model Signed-off-by: Jules Damji <dmatrix@comcast.net> * minor modification Signed-off-by: Jules Damji <dmatrix@comcast.net> * Use model variable instead of learn Signed-off-by: Jules Damji <dmatrix@comcast.net> * import fastai.vision as vis Signed-off-by: Jules Damji <dmatrix@comcast.net> * Fixed lint issue Signed-off-by: Jules Damji <dmatrix@comcast.net> Signed-off-by: harupy <17039389+harupy@users.noreply.github.com> * Add fault tolerance for Spark autologging (#3860) * Add fault tolerance for Spark autologging Signed-off-by: Mohamad Arabi <mohamad.arabi@databricks.com> * add test case Signed-off-by: Mohamad Arabi <mohamad.arabi@databricks.com> * fix spacing Signed-off-by: Mohamad Arabi <mohamad.arabi@databricks.com> * fix errors Signed-off-by: Mohamad Arabi <mohamad.arabi@databricks.com> * Move autolog impl up to spark.py Signed-off-by: Mohamad Arabi <mohamad.arabi@databricks.com> * Teardown logic to avoid autologging active session bleeding Signed-off-by: Mohamad Arabi <mohamad.arabi@databricks.com> Signed-off-by: harupy <17039389+harupy@users.noreply.github.com> * Add autologging safety utils to tensorflow (#3861) * commit Signed-off-by: harupy <17039389+harupy@users.noreply.github.com> * apply safe patch Signed-off-by: harupy <17039389+harupy@users.noreply.github.com> * workaround for export_saved_model Signed-off-by: harupy <17039389+harupy@users.noreply.github.com> * nit Signed-off-by: harupy <17039389+harupy@users.noreply.github.com> * nit Signed-off-by: harupy <17039389+harupy@users.noreply.github.com> * docstring Signed-off-by: harupy <17039389+harupy@users.noreply.github.com> * lint Signed-off-by: harupy <17039389+harupy@users.noreply.github.com> * Use _on_exception to clean up log_dir Signed-off-by: harupy <17039389+harupy@users.noreply.github.com> * remove inst Signed-off-by: harupy <17039389+harupy@users.noreply.github.com> * inst? Signed-off-by: harupy <17039389+harupy@users.noreply.github.com> * unused import Signed-off-by: harupy <17039389+harupy@users.noreply.github.com> * Add autologging safety utils to statsmodels & Fast.ai (#3859) * Fastai Signed-off-by: Corey Zumar <corey.zumar@databricks.com> * statsmodels Signed-off-by: Corey Zumar <corey.zumar@databricks.com> * Lint Signed-off-by: Corey Zumar <corey.zumar@databricks.com> * Progress Signed-off-by: Corey Zumar <corey.zumar@databricks.com> * Docstring Signed-off-by: Corey Zumar <corey.zumar@databricks.com> * Test fixes Signed-off-by: Corey Zumar <corey.zumar@databricks.com> * Format, docstring Signed-off-by: Corey Zumar <corey.zumar@databricks.com> * Some lint Signed-off-by: Corey Zumar <corey.zumar@databricks.com> * Lint Signed-off-by: Corey Zumar <corey.zumar@databricks.com> * use exception instead of valuerror Signed-off-by: Corey Zumar <corey.zumar@databricks.com> Signed-off-by: harupy <17039389+harupy@users.noreply.github.com> * fixes after scuffed merge Signed-off-by: Walter Martin <wamartin@microsoft.com> Signed-off-by: harupy <17039389+harupy@users.noreply.github.com> * mostly whitespace updates Signed-off-by: Walter Martin <wamartin@microsoft.com> Signed-off-by: harupy <17039389+harupy@users.noreply.github.com> * hopefully final whitespace fix Signed-off-by: Walter Martin <wamartin@microsoft.com> Signed-off-by: harupy <17039389+harupy@users.noreply.github.com> * actual final whitespace fix Signed-off-by: Walter Martin <wamartin@microsoft.com> Signed-off-by: harupy <17039389+harupy@users.noreply.github.com> * removed unused variable again Signed-off-by: Walter Martin <wamartin@microsoft.com> Signed-off-by: harupy <17039389+harupy@users.noreply.github.com> * switch to kwargs, add more testing Signed-off-by: Walter Martin <wamartin@microsoft.com> Signed-off-by: harupy <17039389+harupy@users.noreply.github.com> * fix error test Signed-off-by: Walter Martin <wamartin@microsoft.com> Signed-off-by: harupy <17039389+harupy@users.noreply.github.com> * fix problem kwarg in handlers Signed-off-by: Walter Martin <wamartin@microsoft.com> Signed-off-by: harupy <17039389+harupy@users.noreply.github.com> * linting Signed-off-by: Walter Martin <wamartin@microsoft.com> Signed-off-by: harupy <17039389+harupy@users.noreply.github.com> * fix lint in tracking test Signed-off-by: Walter Martin <wamartin@microsoft.com> Signed-off-by: harupy <17039389+harupy@users.noreply.github.com> * file_store pagination, untested, plus pagedlist and protos changes Signed-off-by: Walter Martin <wamartin@microsoft.com> Signed-off-by: harupy <17039389+harupy@users.noreply.github.com> * testing and fixing for file store Signed-off-by: Walter Martin <wamartin@microsoft.com> Signed-off-by: harupy <17039389+harupy@users.noreply.github.com> * commit mostly to run tests again Signed-off-by: Walter Martin <wamartin@microsoft.com> Signed-off-by: harupy <17039389+harupy@users.noreply.github.com> * commit again to re-trigger tests Signed-off-by: Walter Martin <wamartin@microsoft.com> Signed-off-by: harupy <17039389+harupy@users.noreply.github.com> * add high default back Signed-off-by: Walter Martin <wamartin@microsoft.com> Signed-off-by: harupy <17039389+harupy@users.noreply.github.com> * Add return type annotations to key MLflow APIs (#4242) * Annotate fluent APIs Signed-off-by: harupy <17039389+harupy@users.noreply.github.com> * Fix typo Signed-off-by: harupy <17039389+harupy@users.noreply.github.com> * fix typo Signed-off-by: harupy <17039389+harupy@users.noreply.github.com> * annotate client APIs Signed-off-by: harupy <17039389+harupy@users.noreply.github.com> * add None Signed-off-by: harupy <17039389+harupy@users.noreply.github.com> * Fix lint? Signed-off-by: harupy <17039389+harupy@users.noreply.github.com> * Fix return type of get_experiment_by_name Signed-off-by: harupy <17039389+harupy@users.noreply.github.com> * Fix docstring of get_experiment_by_name Signed-off-by: harupy <17039389+harupy@users.noreply.github.com> * Add PagedList to __init__.py Signed-off-by: harupy <17039389+harupy@users.noreply.github.com> * Workaround for missing reference Signed-off-by: harupy <17039389+harupy@users.noreply.github.com> * rename variable Signed-off-by: harupy <17039389+harupy@users.noreply.github.com> * Add more type hints Signed-off-by: harupy <17039389+harupy@users.noreply.github.com> * fix typo Signed-off-by: harupy <17039389+harupy@users.noreply.github.com> * Fix lint Signed-off-by: harupy <17039389+harupy@users.noreply.github.com> * Fix lint? Signed-off-by: harupy <17039389+harupy@users.noreply.github.com> * apply weichen's suggestion Signed-off-by: harupy <17039389+harupy@users.noreply.github.com> * remove unused re Signed-off-by: harupy <17039389+harupy@users.noreply.github.com> * address comments Signed-off-by: harupy <17039389+harupy@users.noreply.github.com> * fix Signed-off-by: harupy <17039389+harupy@users.noreply.github.com> * Add argument type annotations (#4255) * Add argument type hints Signed-off-by: harupy <17039389+harupy@users.noreply.github.com> * Fix doc build Signed-off-by: harupy <17039389+harupy@users.noreply.github.com> * autolog Signed-off-by: harupy <17039389+harupy@users.noreply.github.com> * Fix run_view_type Signed-off-by: harupy <17039389+harupy@users.noreply.github.com> * fix log_dict Signed-off-by: harupy <17039389+harupy@users.noreply.github.com> * bytes -> str Signed-off-by: harupy <17039389+harupy@users.noreply.github.com> * Use TYPE_CHECKING Signed-off-by: harupy <17039389+harupy@users.noreply.github.com> * use TYPE_CHECKING Signed-off-by: harupy <17039389+harupy@users.noreply.github.com> * Ignore pandas.DataFrame Signed-off-by: harupy <17039389+harupy@users.noreply.github.com> * fix order Signed-off-by: harupy <17039389+harupy@users.noreply.github.com> * trailing whitespace Signed-off-by: Walter Martin <wamartin@microsoft.com> Signed-off-by: harupy <17039389+harupy@users.noreply.github.com> * black reformat Signed-off-by: Walter Martin <wamartin@microsoft.com> Signed-off-by: harupy <17039389+harupy@users.noreply.github.com> * push to update PR Signed-off-by: Walter Martin <wamartin@microsoft.com> Signed-off-by: harupy <17039389+harupy@users.noreply.github.com> * adding validation for lower max_results limit Signed-off-by: Walter Martin <wamartin@microsoft.com> Signed-off-by: harupy <17039389+harupy@users.noreply.github.com> * fix comment length Signed-off-by: Walter Martin <wamartin@microsoft.com> Signed-off-by: harupy <17039389+harupy@users.noreply.github.com> * trailing whitespace Signed-off-by: Walter Martin <wamartin@microsoft.com> Signed-off-by: harupy <17039389+harupy@users.noreply.github.com> * Add end to end integration test against REST server Signed-off-by: harupy <17039389+harupy@users.noreply.github.com> * Fix test Signed-off-by: harupy <17039389+harupy@users.noreply.github.com> * Fix formatting Signed-off-by: harupy <17039389+harupy@users.noreply.github.com> * Fix test Signed-off-by: harupy <17039389+harupy@users.noreply.github.com> * Fix limit for max_results Signed-off-by: harupy <17039389+harupy@users.noreply.github.com> * sort by creation time and experiment id Signed-off-by: harupy <17039389+harupy@users.noreply.github.com> * update proto Signed-off-by: harupy <17039389+harupy@users.noreply.github.com> * remove order by Signed-off-by: harupy <17039389+harupy@users.noreply.github.com> * Fix comment Signed-off-by: harupy <17039389+harupy@users.noreply.github.com> * compile proto Signed-off-by: harupy <17039389+harupy@users.noreply.github.com> * fix tests Signed-off-by: harupy <17039389+harupy@users.noreply.github.com> * Fix validation test Signed-off-by: harupy <17039389+harupy@users.noreply.github.com> * Add view_type doc Signed-off-by: harupy <17039389+harupy@users.noreply.github.com> * fix comment in proto Signed-off-by: harupy <17039389+harupy@users.noreply.github.com> * udpate commet on max_results Signed-off-by: harupy <17039389+harupy@users.noreply.github.com> * Add mlflow.list_experiments Signed-off-by: harupy <17039389+harupy@users.noreply.github.com> * remove unused imports Signed-off-by: harupy <17039389+harupy@users.noreply.github.com> * parametrize Signed-off-by: harupy <17039389+harupy@users.noreply.github.com> * fix experiment name Signed-off-by: harupy <17039389+harupy@users.noreply.github.com> * Verify pagination behavior Signed-off-by: harupy <17039389+harupy@users.noreply.github.com> * fix URI Signed-off-by: harupy <17039389+harupy@users.noreply.github.com> * Fix comment Signed-off-by: harupy <17039389+harupy@users.noreply.github.com> * Set max_results to None Signed-off-by: harupy <17039389+harupy@users.noreply.github.com> * nit Signed-off-by: harupy <17039389+harupy@users.noreply.github.com> * Remove default value for max_results Signed-off-by: harupy <17039389+harupy@users.noreply.github.com> * fix max_results logic Signed-off-by: harupy <17039389+harupy@users.noreply.github.com> * Formatting Signed-off-by: harupy <17039389+harupy@users.noreply.github.com> * use ListFields Signed-off-by: harupy <17039389+harupy@users.noreply.github.com> * comment for listFields Signed-off-by: harupy <17039389+harupy@users.noreply.github.com> * rename function Signed-off-by: harupy <17039389+harupy@users.noreply.github.com> * remove used _list_experiments Signed-off-by: harupy <17039389+harupy@users.noreply.github.com> * fix broken test Signed-off-by: harupy <17039389+harupy@users.noreply.github.com> * remove print Signed-off-by: harupy <17039389+harupy@users.noreply.github.com> * fix Signed-off-by: harupy <17039389+harupy@users.noreply.github.com> * fix Signed-off-by: harupy <17039389+harupy@users.noreply.github.com> * use comprehensive list Signed-off-by: harupy <17039389+harupy@users.noreply.github.com> * fix failed tests Signed-off-by: harupy <17039389+harupy@users.noreply.github.com> * revert unrelated changes Signed-off-by: harupy <17039389+harupy@users.noreply.github.com> * revert unrelated changes Signed-off-by: harupy <17039389+harupy@users.noreply.github.com> * Add fluent list_experiments Signed-off-by: harupy <17039389+harupy@users.noreply.github.com> * remove validation in client Signed-off-by: harupy <17039389+harupy@users.noreply.github.com> * fix test_list_experiments_paginated_errors Signed-off-by: harupy <17039389+harupy@users.noreply.github.com> * Use SEARCH_MAX_RESULTS_DEFAULT Signed-off-by: harupy <17039389+harupy@users.noreply.github.com> * revert unrelated changes Signed-off-by: harupy <17039389+harupy@users.noreply.github.com> * Fix _validate_experiment_pagination to exit immediately if given max_results is None Signed-off-by: harupy <17039389+harupy@users.noreply.github.com> * return nothing Signed-off-by: harupy <17039389+harupy@users.noreply.github.com> * Address comments on _validate_experiment_pagination Signed-off-by: harupy <17039389+harupy@users.noreply.github.com> * update comment Signed-off-by: harupy <17039389+harupy@users.noreply.github.com> * set max_results to None Signed-off-by: harupy <17039389+harupy@users.noreply.github.com> * set max_results to None Signed-off-by: harupy <17039389+harupy@users.noreply.github.com> * fix lint errors Signed-off-by: harupy <17039389+harupy@users.noreply.github.com> * Fix docstrings Signed-off-by: harupy <17039389+harupy@users.noreply.github.com> * set view_type to ACTIVE_ONLY be default Signed-off-by: harupy <17039389+harupy@users.noreply.github.com> * udpate return description Signed-off-by: harupy <17039389+harupy@users.noreply.github.com> * Fix threshold for file/sql stores and comment on max_results Signed-off-by: harupy <17039389+harupy@users.noreply.github.com> * cleanup Signed-off-by: harupy <17039389+harupy@users.noreply.github.com> * Fix test_validate_list_experiments_max_results Signed-off-by: harupy <17039389+harupy@users.noreply.github.com> * lint Signed-off-by: harupy <17039389+harupy@users.noreply.github.com> * lint Signed-off-by: harupy <17039389+harupy@users.noreply.github.com> * remove page_token in fluent list_experiments Signed-off-by: harupy <17039389+harupy@users.noreply.github.com> * protos Signed-off-by: harupy <17039389+harupy@users.noreply.github.com> Co-authored-by: Harutaka Kawamura <hkawamura0130@gmail.com> Co-authored-by: dbczumar <39497902+dbczumar@users.noreply.github.com> Co-authored-by: Mohamad Arabi <mohamad.arabi@databricks.com> Co-authored-by: Halil Coban <halil.coban@gmail.com> Co-authored-by: mohamad-arabi <73549313+mohamad-arabi@users.noreply.github.com> Co-authored-by: Corey Zumar <corey.zumar@databricks.com> Co-authored-by: dmatrix <dmatrix@comcast.net> Co-authored-by: Sid Murching <sid.murching@databricks.com> Co-authored-by: harupy <17039389+harupy@users.noreply.github.com>
Signed-off-by: harupy 17039389+harupy@users.noreply.github.com
What changes are proposed in this pull request?
How is this patch tested?
Existing tests
Release Notes
Is this a user-facing change?
(Details in 1-2 sentences. You can just refer to another PR with a description if this PR is part of a larger change.)
What component(s), interfaces, languages, and integrations does this PR affect?
Components
area/artifacts
: Artifact stores and artifact loggingarea/build
: Build and test infrastructure for MLflowarea/docs
: MLflow documentation pagesarea/examples
: Example codearea/model-registry
: Model Registry service, APIs, and the fluent client calls for Model Registryarea/models
: MLmodel format, model serialization/deserialization, flavorsarea/projects
: MLproject format, project running backendsarea/scoring
: Local serving, model deployment tools, spark UDFsarea/server-infra
: MLflow server, JavaScript dev serverarea/tracking
: Tracking Service, tracking client APIs, autologgingInterface
area/uiux
: Front-end, user experience, JavaScript, plottingarea/docker
: Docker use across MLflow's components, such as MLflow Projects and MLflow Modelsarea/sqlalchemy
: Use of SQLAlchemy in the Tracking Service or Model Registryarea/windows
: Windows supportLanguage
language/r
: R APIs and clientslanguage/java
: Java APIs and clientslanguage/new
: Proposals for new client languagesIntegrations
integrations/azure
: Azure and Azure ML integrationsintegrations/sagemaker
: SageMaker integrationsintegrations/databricks
: Databricks integrationsHow should the PR be classified in the release notes? Choose one:
rn/breaking-change
- The PR will be mentioned in the "Breaking Changes" sectionrn/none
- No description will be included. The PR will be mentioned only by the PR number in the "Small Bugfixes and Documentation Updates" sectionrn/feature
- A new user-facing feature worth mentioning in the release notesrn/bug-fix
- A user-facing bug fix worth mentioning in the release notesrn/documentation
- A user-facing documentation change worth mentioning in the release notes