-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix flaky test #4274
Merged
Merged
Fix flaky test #4274
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: dbczumar <corey.zumar@databricks.com>
Signed-off-by: dbczumar <corey.zumar@databricks.com>
Signed-off-by: dbczumar <corey.zumar@databricks.com>
Signed-off-by: dbczumar <corey.zumar@databricks.com>
Signed-off-by: dbczumar <corey.zumar@databricks.com>
github-actions
bot
added
area/build
Build and test infrastructure for MLflow
rn/none
List under Small Changes in Changelogs.
labels
Apr 22, 2021
Signed-off-by: dbczumar <corey.zumar@databricks.com>
harupy
approved these changes
Apr 22, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
27 tasks
YQ-Wang
pushed a commit
to YQ-Wang/mlflow
that referenced
this pull request
May 29, 2021
* Add teardown Signed-off-by: dbczumar <corey.zumar@databricks.com> * Diagnose Signed-off-by: dbczumar <corey.zumar@databricks.com> * Removed dummy test case Signed-off-by: dbczumar <corey.zumar@databricks.com> * Print run and format Signed-off-by: dbczumar <corey.zumar@databricks.com> * Wait Signed-off-by: dbczumar <corey.zumar@databricks.com> * Print info Signed-off-by: dbczumar <corey.zumar@databricks.com> * remove unused import Signed-off-by: dbczumar <corey.zumar@databricks.com> * Executions Signed-off-by: dbczumar <corey.zumar@databricks.com> Signed-off-by: Yiqing Wang <yiqing@wangemail.com>
harupy
pushed a commit
to wamartin-aml/mlflow
that referenced
this pull request
Jun 7, 2021
* Add teardown Signed-off-by: dbczumar <corey.zumar@databricks.com> * Diagnose Signed-off-by: dbczumar <corey.zumar@databricks.com> * Removed dummy test case Signed-off-by: dbczumar <corey.zumar@databricks.com> * Print run and format Signed-off-by: dbczumar <corey.zumar@databricks.com> * Wait Signed-off-by: dbczumar <corey.zumar@databricks.com> * Print info Signed-off-by: dbczumar <corey.zumar@databricks.com> * remove unused import Signed-off-by: dbczumar <corey.zumar@databricks.com> * Executions Signed-off-by: dbczumar <corey.zumar@databricks.com> Signed-off-by: harupy <17039389+harupy@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes are proposed in this pull request?
This PR fixes flakiness in the evaluation of the
clean_up_leaked_runs
test fixture caused by a failure to block on futures launched duringtest_autologging_behaviors_integration#test_autolog_respects_silent_mode
. It also augmentsclean_up_leaked_runs
to print the leaked run for future failure diagnostics.How is this patch tested?
clean_up_leaked_runs
successfully prints the leaked when a test case is introduced that deliberately leaks a run:Test case code:
Error log:
Release Notes
Is this a user-facing change?
What component(s), interfaces, languages, and integrations does this PR affect?
Components
area/artifacts
: Artifact stores and artifact loggingarea/build
: Build and test infrastructure for MLflowarea/docs
: MLflow documentation pagesarea/examples
: Example codearea/model-registry
: Model Registry service, APIs, and the fluent client calls for Model Registryarea/models
: MLmodel format, model serialization/deserialization, flavorsarea/projects
: MLproject format, project running backendsarea/scoring
: Local serving, model deployment tools, spark UDFsarea/server-infra
: MLflow server, JavaScript dev serverarea/tracking
: Tracking Service, tracking client APIs, autologgingInterface
area/uiux
: Front-end, user experience, JavaScript, plottingarea/docker
: Docker use across MLflow's components, such as MLflow Projects and MLflow Modelsarea/sqlalchemy
: Use of SQLAlchemy in the Tracking Service or Model Registryarea/windows
: Windows supportLanguage
language/r
: R APIs and clientslanguage/java
: Java APIs and clientslanguage/new
: Proposals for new client languagesIntegrations
integrations/azure
: Azure and Azure ML integrationsintegrations/sagemaker
: SageMaker integrationsintegrations/databricks
: Databricks integrationsHow should the PR be classified in the release notes? Choose one:
rn/breaking-change
- The PR will be mentioned in the "Breaking Changes" sectionrn/none
- No description will be included. The PR will be mentioned only by the PR number in the "Small Bugfixes and Documentation Updates" sectionrn/feature
- A new user-facing feature worth mentioning in the release notesrn/bug-fix
- A user-facing bug fix worth mentioning in the release notesrn/documentation
- A user-facing documentation change worth mentioning in the release notes