GC CLI SFTP Support: implement delete_artifacts in sftp_artifact_repository #4670
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sitory Signed-off-by: Alexander Faul <kontakt-github-signature@afaul.de>
github-actions
bot
added
area/artifacts
|
Do you mind adding some unit tests for the proposed change? Existing tests are located at tests/store/artifact/test_sftp_artifact_repo.py. Thank you! |
Signed-off-by: Alexander Faul <kontakt-github-signature@afaul.de>
|
I added two tests for the deletion of artifacts. |
jinzhang21
reviewed
Sep 7, 2021
…don't deletes to much and reformated the file with black as lint.sh suggested Signed-off-by: Alexander Faul <kontakt-github-signature@afaul.de>
jinzhang21
approved these changes
Sep 9, 2021
anjsam1402
pushed a commit
to anjsam1402/mlflow
that referenced
this pull request
Sep 14, 2021
…sitory (mlflow#4670) * GC CLI SFTP Support: implement delete_artifacts in sftp_artifact_repository Signed-off-by: Alexander Faul <kontakt-github-signature@afaul.de> * unit tests for deletion of artifacts via sftp added Signed-off-by: Alexander Faul <kontakt-github-signature@afaul.de> * made suggested changes, added another test to make sure the function don't deletes to much and reformated the file with black as lint.sh suggested Signed-off-by: Alexander Faul <kontakt-github-signature@afaul.de> * Fixed lint Co-authored-by: Alexander Faul <kontakt-github-signature@afaul.de> Co-authored-by: jinzhang21 <jin.zhang@databricks.com> Signed-off-by: Anjali Samad <samad.anjali.14@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Alexander Faul kontakt-github-signature@afaul.de
What changes are proposed in this pull request?
Implementation of delete_artifacts in sftp_artifact_repository.py
How is this patch tested?
(Details)
Release Notes
Is this a user-facing change?
(Details in 1-2 sentences. You can just refer to another PR with a description if this PR is part of a larger change.)
What component(s), interfaces, languages, and integrations does this PR affect?
Components
area/artifacts: Artifact stores and artifact loggingarea/build: Build and test infrastructure for MLflowarea/docs: MLflow documentation pagesarea/examples: Example codearea/model-registry: Model Registry service, APIs, and the fluent client calls for Model Registryarea/models: MLmodel format, model serialization/deserialization, flavorsarea/projects: MLproject format, project running backendsarea/scoring: MLflow Model server, model deployment tools, Spark UDFsarea/server-infra: MLflow Tracking server backendarea/tracking: Tracking Service, tracking client APIs, autologgingInterface
area/uiux: Front-end, user experience, plotting, JavaScript, JavaScript dev serverarea/docker: Docker use across MLflow's components, such as MLflow Projects and MLflow Modelsarea/sqlalchemy: Use of SQLAlchemy in the Tracking Service or Model Registryarea/windows: Windows supportLanguage
language/r: R APIs and clientslanguage/java: Java APIs and clientslanguage/new: Proposals for new client languagesIntegrations
integrations/azure: Azure and Azure ML integrationsintegrations/sagemaker: SageMaker integrationsintegrations/databricks: Databricks integrationsHow should the PR be classified in the release notes? Choose one:
rn/breaking-change- The PR will be mentioned in the "Breaking Changes" sectionrn/none- No description will be included. The PR will be mentioned only by the PR number in the "Small Bugfixes and Documentation Updates" sectionrn/feature- A new user-facing feature worth mentioning in the release notesrn/bug-fix- A user-facing bug fix worth mentioning in the release notesrn/documentation- A user-facing documentation change worth mentioning in the release notes