Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update spark support version to be 3.2 #4770

Merged
merged 4 commits into from
Sep 3, 2021
Merged

Update spark support version to be 3.2 #4770

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
359b618
init
WeichenXu123 Sep 3, 2021
f40642d
Fix set matrix
dbczumar Sep 3, 2021
f2bf3d5
Fix
dbczumar Sep 3, 2021
579428b
Format
dbczumar Sep 3, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 2 additions & 2 deletions mlflow/ml-package-versions.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -312,7 +312,7 @@ spark:

models:
minimum: "3.0.0"
maximum: "3.1.2"
maximum: "3.2.0"
Copy link
Member

@harupy harupy Sep 3, 2021 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to fix set_matrix.py to allow specifying unreleased versions for pyspark:

mlflow/dev/set_matrix.py

Lines 171 to 174 in 73c97db

# Prevent specifying non-existent versions
assert min_ver in versions
assert max_ver in versions
assert all(v in versions for v in excludes)

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done! Added allow_unreleased_max_version

requirements: ["boto3", "scikit-learn", "pyarrow"]
run: |
SAGEMAKER_OUT=$(mktemp)
Expand All @@ -327,7 +327,7 @@ spark:

autologging:
minimum: "3.0.0"
maximum: "3.1.2"
maximum: "3.2.0"
requirements: ["scikit-learn"]
run: |
find tests/spark_autologging/ml -name 'test*.py' | xargs -L 1 pytest --large
Expand Down