Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIx small typo #4772

Merged
merged 1 commit into from
Sep 4, 2021
Merged

FIx small typo #4772

merged 1 commit into from
Sep 4, 2021

Conversation

louisguitton
Copy link
Contributor

@louisguitton louisguitton commented Sep 3, 2021

What changes are proposed in this pull request?

Fixing small typo in the warning message.
Before the change:

2021/09/03 18:53:45 WARNING mlflow.sklearn.utils: precision_score failed. The metric test_gold_precision_scorewill not be recorded. Metric error: '<' not supported between instances of 'float' and 'str'
2021/09/03 18:53:45 WARNING mlflow.sklearn.utils: recall_score failed. The metric test_gold_recall_scorewill not be recorded. Metric error: '<' not supported between instances of 'float' and 'str'
2021/09/03 18:53:45 WARNING mlflow.sklearn.utils: f1_score failed. The metric test_gold_f1_scorewill not be recorded. Metric error: '<' not supported between instances of 'float' and 'str'
2021/09/03 18:53:45 WARNING mlflow.sklearn.utils: accuracy_score failed. The metric test_gold_accuracy_scorewill not be recorded. Metric error: '<' not supported between instances of 'float' and 'str'

How is this patch tested?

from mlflow.sklearn.utils import _log_warning_for_metrics
from sklearn.metrics import precision_score

# given
func_name = "test_gold_precision_score"
func_call = precision_score
err = Exception("'<' not supported between instances of 'float' and 'str'"

# when
_log_warning_for_metrics(func_name, func_call, err)

# then
# visually assert that the words are correctly spaced out

Release Notes

Is this a user-facing change?

  • No. You can skip the rest of this section.
  • Yes. Give a description of this change to be included in the release notes for MLflow users.

(Details in 1-2 sentences. You can just refer to another PR with a description if this PR is part of a larger change.)

What component(s), interfaces, languages, and integrations does this PR affect?

Components

  • area/artifacts: Artifact stores and artifact logging
  • area/build: Build and test infrastructure for MLflow
  • area/docs: MLflow documentation pages
  • area/examples: Example code
  • area/model-registry: Model Registry service, APIs, and the fluent client calls for Model Registry
  • area/models: MLmodel format, model serialization/deserialization, flavors
  • area/projects: MLproject format, project running backends
  • area/scoring: MLflow Model server, model deployment tools, Spark UDFs
  • area/server-infra: MLflow Tracking server backend
  • area/tracking: Tracking Service, tracking client APIs, autologging

Interface

  • area/uiux: Front-end, user experience, plotting, JavaScript, JavaScript dev server
  • area/docker: Docker use across MLflow's components, such as MLflow Projects and MLflow Models
  • area/sqlalchemy: Use of SQLAlchemy in the Tracking Service or Model Registry
  • area/windows: Windows support

Language

  • language/r: R APIs and clients
  • language/java: Java APIs and clients
  • language/new: Proposals for new client languages

Integrations

  • integrations/azure: Azure and Azure ML integrations
  • integrations/sagemaker: SageMaker integrations
  • integrations/databricks: Databricks integrations

How should the PR be classified in the release notes? Choose one:

  • rn/breaking-change - The PR will be mentioned in the "Breaking Changes" section
  • rn/none - No description will be included. The PR will be mentioned only by the PR number in the "Small Bugfixes and Documentation Updates" section
  • rn/feature - A new user-facing feature worth mentioning in the release notes
  • rn/bug-fix - A user-facing bug fix worth mentioning in the release notes
  • rn/documentation - A user-facing documentation change worth mentioning in the release notes

@github-actions github-actions bot added the rn/none List under Small Changes in Changelogs. label Sep 3, 2021
@github-actions
Copy link

github-actions bot commented Sep 3, 2021

@louisguitton Thanks for the contribution! The DCO check failed. Please sign off your commits by following the instructions here: https://github.com/mlflow/mlflow/runs/3508740632. See https://github.com/mlflow/mlflow/blob/master/CONTRIBUTING.rst#sign-your-work for more details.

@louisguitton louisguitton marked this pull request as draft September 3, 2021 18:02
Before:
```
2021/09/03 18:53:45 WARNING mlflow.sklearn.utils: precision_score failed. The metric test_gold_precision_scorewill not be recorded. Metric error: '<' not supported between instances of 'float' and 'str'
2021/09/03 18:53:45 WARNING mlflow.sklearn.utils: recall_score failed. The metric test_gold_recall_scorewill not be recorded. Metric error: '<' not supported between instances of 'float' and 'str'
2021/09/03 18:53:45 WARNING mlflow.sklearn.utils: f1_score failed. The metric test_gold_f1_scorewill not be recorded. Metric error: '<' not supported between instances of 'float' and 'str'
2021/09/03 18:53:45 WARNING mlflow.sklearn.utils: accuracy_score failed. The metric test_gold_accuracy_scorewill not be recorded. Metric error: '<' not supported between instances of 'float' and 'str'
```

Signed-off-by: Louis Guitton <louisguitton93@gmail.com>
@louisguitton louisguitton marked this pull request as ready for review September 3, 2021 18:06
Copy link
Member

@harupy harupy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@harupy harupy merged commit 3e42817 into mlflow:master Sep 4, 2021
@louisguitton louisguitton deleted the patch-1 branch September 4, 2021 10:24
BenWilson2 pushed a commit that referenced this pull request Sep 7, 2021
Before:
```
2021/09/03 18:53:45 WARNING mlflow.sklearn.utils: precision_score failed. The metric test_gold_precision_scorewill not be recorded. Metric error: '<' not supported between instances of 'float' and 'str'
2021/09/03 18:53:45 WARNING mlflow.sklearn.utils: recall_score failed. The metric test_gold_recall_scorewill not be recorded. Metric error: '<' not supported between instances of 'float' and 'str'
2021/09/03 18:53:45 WARNING mlflow.sklearn.utils: f1_score failed. The metric test_gold_f1_scorewill not be recorded. Metric error: '<' not supported between instances of 'float' and 'str'
2021/09/03 18:53:45 WARNING mlflow.sklearn.utils: accuracy_score failed. The metric test_gold_accuracy_scorewill not be recorded. Metric error: '<' not supported between instances of 'float' and 'str'
```

Signed-off-by: Louis Guitton <louisguitton93@gmail.com>
Signed-off-by: Ben Wilson <benjamin.wilson@databricks.com>
BenWilson2 added a commit that referenced this pull request Sep 10, 2021
* WIP build

Signed-off-by: benwilson <benjamin.wilson@databricks.com>

* Finish unit tests and address prophet build dependencies for serving

Signed-off-by: benwilson <benjamin.wilson@databricks.com>

* refactor example for prophet and add tracking validation test

Signed-off-by: benwilson <benjamin.wilson@databricks.com>

* adjusting build env

Signed-off-by: benwilson <benjamin.wilson@databricks.com>

* linting

Signed-off-by: benwilson <benjamin.wilson@databricks.com>

* Increase HTTP timeout to 90s. Disabled cloud storage HTTP timeout. (#4764)

* Increase HTTP timeout to 120s. Disabled cloud storage HTTP timeout.

* Enable auto dependency inference in spark flavor (#4759)

* use infer_pip_requirements to spark.py

Signed-off-by: harupy <hkawamura0130@gmail.com>

* fix tests

Signed-off-by: harupy <hkawamura0130@gmail.com>

* fix tests

Signed-off-by: harupy <hkawamura0130@gmail.com>

* rename test

Signed-off-by: harupy <hkawamura0130@gmail.com>

* workaround for databricks

Signed-off-by: harupy <hkawamura0130@gmail.com>

* workaround for pyspark in databricks

Signed-off-by: harupy <hkawamura0130@gmail.com>

* rename test

Signed-off-by: harupy <hkawamura0130@gmail.com>

* address comments

Signed-off-by: harupy <hkawamura0130@gmail.com>

* better error message

Signed-off-by: harupy <hkawamura0130@gmail.com>

* fix error message

Signed-off-by: harupy <hkawamura0130@gmail.com>

* Fix `test_autolog_emits_warning_message_when_model_prediction_fails` (#4768)

* Use AttributeError

Signed-off-by: harupy <hkawamura0130@gmail.com>

* comment

Signed-off-by: harupy <hkawamura0130@gmail.com>

* fix

Signed-off-by: harupy <hkawamura0130@gmail.com>

* use sanity_checking (#4767)

Signed-off-by: harupy <hkawamura0130@gmail.com>

* refactor: Extract the docker image building _build_image_from_context function (#4769)

* refactor: Extract the docker image building _build_image_from_context function

Signed-off-by: Alexey Volkov <alexey.volkov@ark-kun.com>

* blacken

Signed-off-by: harupy <hkawamura0130@gmail.com>

Co-authored-by: harupy <hkawamura0130@gmail.com>

* Fix autologging compatibility with Keras >= 2.6.0 (#4766)

* Increase HTTP timeout to 90s. Disabled cloud storage HTTP timeout. (#4764)

* Increase HTTP timeout to 120s. Disabled cloud storage HTTP timeout.

Signed-off-by: dbczumar <corey.zumar@databricks.com>

* Include keras conditionally

Signed-off-by: dbczumar <corey.zumar@databricks.com>

* Fixes

Signed-off-by: dbczumar <corey.zumar@databricks.com>

* Fix

Signed-off-by: dbczumar <corey.zumar@databricks.com>

* Fix root cause

Signed-off-by: dbczumar <corey.zumar@databricks.com>

* docstring

Signed-off-by: dbczumar <corey.zumar@databricks.com>

* Some test cases

Signed-off-by: dbczumar <corey.zumar@databricks.com>

* Some test cases

Signed-off-by: dbczumar <corey.zumar@databricks.com>

* Tests

Signed-off-by: dbczumar <corey.zumar@databricks.com>

* Format

Signed-off-by: dbczumar <corey.zumar@databricks.com>

* Test fixes

Signed-off-by: dbczumar <corey.zumar@databricks.com>

* Test fix 2

Signed-off-by: dbczumar <corey.zumar@databricks.com>

* Remove keras change

Signed-off-by: dbczumar <corey.zumar@databricks.com>

* Use is

Signed-off-by: dbczumar <corey.zumar@databricks.com>

* Remove unused modules

Signed-off-by: dbczumar <corey.zumar@databricks.com>

* Use fixtures

Signed-off-by: dbczumar <corey.zumar@databricks.com>

* Docstring

Signed-off-by: dbczumar <corey.zumar@databricks.com>

* Fix fixtures

Signed-off-by: dbczumar <corey.zumar@databricks.com>

* Lint fixes

Signed-off-by: dbczumar <corey.zumar@databricks.com>

* Format

Signed-off-by: dbczumar <corey.zumar@databricks.com>

* Try preserve find module

Signed-off-by: dbczumar <corey.zumar@databricks.com>

* fix

Signed-off-by: Weichen Xu <weichen.xu@databricks.com>

* fix2

Signed-off-by: Weichen Xu <weichen.xu@databricks.com>

* Simplify fluent test cases

Signed-off-by: dbczumar <corey.zumar@databricks.com>

* Format

Signed-off-by: dbczumar <corey.zumar@databricks.com>

* Tweaks, add a warning

Signed-off-by: dbczumar <corey.zumar@databricks.com>

* Test excludee

Signed-off-by: dbczumar <corey.zumar@databricks.com>

* Reverts

Signed-off-by: dbczumar <corey.zumar@databricks.com>

Co-authored-by: jinzhang21 <78067366+jinzhang21@users.noreply.github.com>
Co-authored-by: Weichen Xu <weichen.xu@databricks.com>

* Update spark support version to be 3.2 (#4770)

* init

Signed-off-by: Weichen Xu <weichen.xu@databricks.com>

* Fix set matrix

Signed-off-by: dbczumar <corey.zumar@databricks.com>

* Fix

Signed-off-by: dbczumar <corey.zumar@databricks.com>

* Format

Signed-off-by: dbczumar <corey.zumar@databricks.com>

Co-authored-by: dbczumar <corey.zumar@databricks.com>

* merge

* merge

* fix build errors

* Changelog message tweak (#4777)

* Tweak

Signed-off-by: dbczumar <corey.zumar@databricks.com>

* Lang

Signed-off-by: dbczumar <corey.zumar@databricks.com>

* Update CHANGELOG.rst

* [ALL TESTS] Update  (#4778)

* Update MLflow version to 1.20.3

Signed-off-by: Jenkins <jenkins@databricks.com>

* Update

Signed-off-by: dbczumar <corey.zumar@databricks.com>

Co-authored-by: Jenkins <jenkins@databricks.com>
Co-authored-by: dbczumar <corey.zumar@databricks.com>

* Fix small typo (#4772)

Before:
```
2021/09/03 18:53:45 WARNING mlflow.sklearn.utils: precision_score failed. The metric test_gold_precision_scorewill not be recorded. Metric error: '<' not supported between instances of 'float' and 'str'
2021/09/03 18:53:45 WARNING mlflow.sklearn.utils: recall_score failed. The metric test_gold_recall_scorewill not be recorded. Metric error: '<' not supported between instances of 'float' and 'str'
2021/09/03 18:53:45 WARNING mlflow.sklearn.utils: f1_score failed. The metric test_gold_f1_scorewill not be recorded. Metric error: '<' not supported between instances of 'float' and 'str'
2021/09/03 18:53:45 WARNING mlflow.sklearn.utils: accuracy_score failed. The metric test_gold_accuracy_scorewill not be recorded. Metric error: '<' not supported between instances of 'float' and 'str'
```

Signed-off-by: Louis Guitton <louisguitton93@gmail.com>

* Push MLflow model to Sagemaker model registry (#4669)

* Added push_sagemaker_model() api to enable push model from MLflow to Sagemaker model registry

Signed-off-by: Jinni Gu <jinnigu@uw.edu>

* Fixed the python doc for _find_transform_job()

Signed-off-by: Jinni Gu <jinnigu@uw.edu>

* Replace https protocol with s3:// protocol for the URL where Sagemaker model artifacts are stored in S3.

Signed-off-by: Yiqing Wang <yiqing@wangemail.com>

* rename push_sagemaker_model function
add CLI function for push_model_to_sagemaker

Signed-off-by: qtz123 <qiutingzhi1995@gmail.com>

* reformat CLI for push_model_to_sagemaker

Signed-off-by: qtz123 <qiutingzhi1995@gmail.com>

* Used describe_model instead of list_models to check if the model exists.

Signed-off-by: Yiqing Wang <yiqing@wangemail.com>

* Renamed the _find_model method to _does_model_exist and limit the scope

Signed-off-by: Yiqing Wang <yiqing@wangemail.com>

* Fixed lint error and changed command to push model

Signed-off-by: Yiqing Wang <yiqing@wangemail.com>

Co-authored-by: Yiqing Wang <yiqing@wangemail.com>
Co-authored-by: qtz123 <qiutingzhi1995@gmail.com>

* Fix tensorflow dev cross test (#4780)

* init

Signed-off-by: Weichen Xu <weichen.xu@databricks.com>

* dummy tf update

Signed-off-by: Weichen Xu <weichen.xu@databricks.com>

* Adding requirements for prophet examples

Signed-off-by: Ben Wilson <benjamin.wilson@databricks.com>

* update conda versions for prophet

Signed-off-by: Ben Wilson <benjamin.wilson@databricks.com>

* Fixing the prophet tests

Signed-off-by: Ben Wilson <benjamin.wilson@databricks.com>

* PR fixes

Signed-off-by: Ben Wilson <benjamin.wilson@databricks.com>

* Add notes on sub-dependencies

Signed-off-by: Ben Wilson <benjamin.wilson@databricks.com>

* Updating docs for Prophet flavor

Signed-off-by: Ben Wilson <benjamin.wilson@databricks.com>

* Resolve dependencies and add flavor tests

Signed-off-by: Ben Wilson <benjamin.wilson@databricks.com>

* update conda.yaml in examples for prophet

Signed-off-by: Ben Wilson <benjamin.wilson@databricks.com>

Co-authored-by: jinzhang21 <78067366+jinzhang21@users.noreply.github.com>
Co-authored-by: Harutaka Kawamura <hkawamura0130@gmail.com>
Co-authored-by: Alexey Volkov <alexey.volkov@ark-kun.com>
Co-authored-by: dbczumar <39497902+dbczumar@users.noreply.github.com>
Co-authored-by: Weichen Xu <weichen.xu@databricks.com>
Co-authored-by: dbczumar <corey.zumar@databricks.com>
Co-authored-by: mlflow-automation <61449322+mlflow-automation@users.noreply.github.com>
Co-authored-by: Jenkins <jenkins@databricks.com>
Co-authored-by: Louis Guitton <louisguitton@users.noreply.github.com>
Co-authored-by: Jinni Gu <jinnigu@uw.edu>
Co-authored-by: Yiqing Wang <yiqing@wangemail.com>
Co-authored-by: qtz123 <qiutingzhi1995@gmail.com>
anjsam1402 pushed a commit to anjsam1402/mlflow that referenced this pull request Sep 14, 2021
* WIP build

Signed-off-by: benwilson <benjamin.wilson@databricks.com>

* Finish unit tests and address prophet build dependencies for serving

Signed-off-by: benwilson <benjamin.wilson@databricks.com>

* refactor example for prophet and add tracking validation test

Signed-off-by: benwilson <benjamin.wilson@databricks.com>

* adjusting build env

Signed-off-by: benwilson <benjamin.wilson@databricks.com>

* linting

Signed-off-by: benwilson <benjamin.wilson@databricks.com>

* Increase HTTP timeout to 90s. Disabled cloud storage HTTP timeout. (mlflow#4764)

* Increase HTTP timeout to 120s. Disabled cloud storage HTTP timeout.

* Enable auto dependency inference in spark flavor (mlflow#4759)

* use infer_pip_requirements to spark.py

Signed-off-by: harupy <hkawamura0130@gmail.com>

* fix tests

Signed-off-by: harupy <hkawamura0130@gmail.com>

* fix tests

Signed-off-by: harupy <hkawamura0130@gmail.com>

* rename test

Signed-off-by: harupy <hkawamura0130@gmail.com>

* workaround for databricks

Signed-off-by: harupy <hkawamura0130@gmail.com>

* workaround for pyspark in databricks

Signed-off-by: harupy <hkawamura0130@gmail.com>

* rename test

Signed-off-by: harupy <hkawamura0130@gmail.com>

* address comments

Signed-off-by: harupy <hkawamura0130@gmail.com>

* better error message

Signed-off-by: harupy <hkawamura0130@gmail.com>

* fix error message

Signed-off-by: harupy <hkawamura0130@gmail.com>

* Fix `test_autolog_emits_warning_message_when_model_prediction_fails` (mlflow#4768)

* Use AttributeError

Signed-off-by: harupy <hkawamura0130@gmail.com>

* comment

Signed-off-by: harupy <hkawamura0130@gmail.com>

* fix

Signed-off-by: harupy <hkawamura0130@gmail.com>

* use sanity_checking (mlflow#4767)

Signed-off-by: harupy <hkawamura0130@gmail.com>

* refactor: Extract the docker image building _build_image_from_context function (mlflow#4769)

* refactor: Extract the docker image building _build_image_from_context function

Signed-off-by: Alexey Volkov <alexey.volkov@ark-kun.com>

* blacken

Signed-off-by: harupy <hkawamura0130@gmail.com>

Co-authored-by: harupy <hkawamura0130@gmail.com>

* Fix autologging compatibility with Keras >= 2.6.0 (mlflow#4766)

* Increase HTTP timeout to 90s. Disabled cloud storage HTTP timeout. (mlflow#4764)

* Increase HTTP timeout to 120s. Disabled cloud storage HTTP timeout.

Signed-off-by: dbczumar <corey.zumar@databricks.com>

* Include keras conditionally

Signed-off-by: dbczumar <corey.zumar@databricks.com>

* Fixes

Signed-off-by: dbczumar <corey.zumar@databricks.com>

* Fix

Signed-off-by: dbczumar <corey.zumar@databricks.com>

* Fix root cause

Signed-off-by: dbczumar <corey.zumar@databricks.com>

* docstring

Signed-off-by: dbczumar <corey.zumar@databricks.com>

* Some test cases

Signed-off-by: dbczumar <corey.zumar@databricks.com>

* Some test cases

Signed-off-by: dbczumar <corey.zumar@databricks.com>

* Tests

Signed-off-by: dbczumar <corey.zumar@databricks.com>

* Format

Signed-off-by: dbczumar <corey.zumar@databricks.com>

* Test fixes

Signed-off-by: dbczumar <corey.zumar@databricks.com>

* Test fix 2

Signed-off-by: dbczumar <corey.zumar@databricks.com>

* Remove keras change

Signed-off-by: dbczumar <corey.zumar@databricks.com>

* Use is

Signed-off-by: dbczumar <corey.zumar@databricks.com>

* Remove unused modules

Signed-off-by: dbczumar <corey.zumar@databricks.com>

* Use fixtures

Signed-off-by: dbczumar <corey.zumar@databricks.com>

* Docstring

Signed-off-by: dbczumar <corey.zumar@databricks.com>

* Fix fixtures

Signed-off-by: dbczumar <corey.zumar@databricks.com>

* Lint fixes

Signed-off-by: dbczumar <corey.zumar@databricks.com>

* Format

Signed-off-by: dbczumar <corey.zumar@databricks.com>

* Try preserve find module

Signed-off-by: dbczumar <corey.zumar@databricks.com>

* fix

Signed-off-by: Weichen Xu <weichen.xu@databricks.com>

* fix2

Signed-off-by: Weichen Xu <weichen.xu@databricks.com>

* Simplify fluent test cases

Signed-off-by: dbczumar <corey.zumar@databricks.com>

* Format

Signed-off-by: dbczumar <corey.zumar@databricks.com>

* Tweaks, add a warning

Signed-off-by: dbczumar <corey.zumar@databricks.com>

* Test excludee

Signed-off-by: dbczumar <corey.zumar@databricks.com>

* Reverts

Signed-off-by: dbczumar <corey.zumar@databricks.com>

Co-authored-by: jinzhang21 <78067366+jinzhang21@users.noreply.github.com>
Co-authored-by: Weichen Xu <weichen.xu@databricks.com>

* Update spark support version to be 3.2 (mlflow#4770)

* init

Signed-off-by: Weichen Xu <weichen.xu@databricks.com>

* Fix set matrix

Signed-off-by: dbczumar <corey.zumar@databricks.com>

* Fix

Signed-off-by: dbczumar <corey.zumar@databricks.com>

* Format

Signed-off-by: dbczumar <corey.zumar@databricks.com>

Co-authored-by: dbczumar <corey.zumar@databricks.com>

* merge

* merge

* fix build errors

* Changelog message tweak (mlflow#4777)

* Tweak

Signed-off-by: dbczumar <corey.zumar@databricks.com>

* Lang

Signed-off-by: dbczumar <corey.zumar@databricks.com>

* Update CHANGELOG.rst

* [ALL TESTS] Update  (mlflow#4778)

* Update MLflow version to 1.20.3

Signed-off-by: Jenkins <jenkins@databricks.com>

* Update

Signed-off-by: dbczumar <corey.zumar@databricks.com>

Co-authored-by: Jenkins <jenkins@databricks.com>
Co-authored-by: dbczumar <corey.zumar@databricks.com>

* Fix small typo (mlflow#4772)

Before:
```
2021/09/03 18:53:45 WARNING mlflow.sklearn.utils: precision_score failed. The metric test_gold_precision_scorewill not be recorded. Metric error: '<' not supported between instances of 'float' and 'str'
2021/09/03 18:53:45 WARNING mlflow.sklearn.utils: recall_score failed. The metric test_gold_recall_scorewill not be recorded. Metric error: '<' not supported between instances of 'float' and 'str'
2021/09/03 18:53:45 WARNING mlflow.sklearn.utils: f1_score failed. The metric test_gold_f1_scorewill not be recorded. Metric error: '<' not supported between instances of 'float' and 'str'
2021/09/03 18:53:45 WARNING mlflow.sklearn.utils: accuracy_score failed. The metric test_gold_accuracy_scorewill not be recorded. Metric error: '<' not supported between instances of 'float' and 'str'
```

Signed-off-by: Louis Guitton <louisguitton93@gmail.com>

* Push MLflow model to Sagemaker model registry (mlflow#4669)

* Added push_sagemaker_model() api to enable push model from MLflow to Sagemaker model registry

Signed-off-by: Jinni Gu <jinnigu@uw.edu>

* Fixed the python doc for _find_transform_job()

Signed-off-by: Jinni Gu <jinnigu@uw.edu>

* Replace https protocol with s3:// protocol for the URL where Sagemaker model artifacts are stored in S3.

Signed-off-by: Yiqing Wang <yiqing@wangemail.com>

* rename push_sagemaker_model function
add CLI function for push_model_to_sagemaker

Signed-off-by: qtz123 <qiutingzhi1995@gmail.com>

* reformat CLI for push_model_to_sagemaker

Signed-off-by: qtz123 <qiutingzhi1995@gmail.com>

* Used describe_model instead of list_models to check if the model exists.

Signed-off-by: Yiqing Wang <yiqing@wangemail.com>

* Renamed the _find_model method to _does_model_exist and limit the scope

Signed-off-by: Yiqing Wang <yiqing@wangemail.com>

* Fixed lint error and changed command to push model

Signed-off-by: Yiqing Wang <yiqing@wangemail.com>

Co-authored-by: Yiqing Wang <yiqing@wangemail.com>
Co-authored-by: qtz123 <qiutingzhi1995@gmail.com>

* Fix tensorflow dev cross test (mlflow#4780)

* init

Signed-off-by: Weichen Xu <weichen.xu@databricks.com>

* dummy tf update

Signed-off-by: Weichen Xu <weichen.xu@databricks.com>

* Adding requirements for prophet examples

Signed-off-by: Ben Wilson <benjamin.wilson@databricks.com>

* update conda versions for prophet

Signed-off-by: Ben Wilson <benjamin.wilson@databricks.com>

* Fixing the prophet tests

Signed-off-by: Ben Wilson <benjamin.wilson@databricks.com>

* PR fixes

Signed-off-by: Ben Wilson <benjamin.wilson@databricks.com>

* Add notes on sub-dependencies

Signed-off-by: Ben Wilson <benjamin.wilson@databricks.com>

* Updating docs for Prophet flavor

Signed-off-by: Ben Wilson <benjamin.wilson@databricks.com>

* Resolve dependencies and add flavor tests

Signed-off-by: Ben Wilson <benjamin.wilson@databricks.com>

* update conda.yaml in examples for prophet

Signed-off-by: Ben Wilson <benjamin.wilson@databricks.com>

Co-authored-by: jinzhang21 <78067366+jinzhang21@users.noreply.github.com>
Co-authored-by: Harutaka Kawamura <hkawamura0130@gmail.com>
Co-authored-by: Alexey Volkov <alexey.volkov@ark-kun.com>
Co-authored-by: dbczumar <39497902+dbczumar@users.noreply.github.com>
Co-authored-by: Weichen Xu <weichen.xu@databricks.com>
Co-authored-by: dbczumar <corey.zumar@databricks.com>
Co-authored-by: mlflow-automation <61449322+mlflow-automation@users.noreply.github.com>
Co-authored-by: Jenkins <jenkins@databricks.com>
Co-authored-by: Louis Guitton <louisguitton@users.noreply.github.com>
Co-authored-by: Jinni Gu <jinnigu@uw.edu>
Co-authored-by: Yiqing Wang <yiqing@wangemail.com>
Co-authored-by: qtz123 <qiutingzhi1995@gmail.com>
Signed-off-by: Anjali Samad <samad.anjali.14@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rn/none List under Small Changes in Changelogs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants