Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shallow git fetch before mlflow run #4838

Merged
merged 4 commits into from
Sep 30, 2021

Conversation

marijncv
Copy link
Contributor

Signed-off-by: Marijn Valk marijncv@hotmail.com

What changes are proposed in this pull request?

This PR updates the project run utils such that it fetches the user code repository with depth=1. This is a small optimization to reduce the size of the .git folder in the repository that is cloned (and subsequently sent to dbfs when running on Databricks backend). The revisions are not needed when running a project.

How is this patch tested?

Used the mlflow run command with a git repository uri. Tested with and without version specified.

Release Notes

Is this a user-facing change?

  • No. You can skip the rest of this section.
  • Yes. Give a description of this change to be included in the release notes for MLflow users.

What component(s), interfaces, languages, and integrations does this PR affect?

Components

  • area/artifacts: Artifact stores and artifact logging
  • area/build: Build and test infrastructure for MLflow
  • area/docs: MLflow documentation pages
  • area/examples: Example code
  • area/model-registry: Model Registry service, APIs, and the fluent client calls for Model Registry
  • area/models: MLmodel format, model serialization/deserialization, flavors
  • area/projects: MLproject format, project running backends
  • area/scoring: MLflow Model server, model deployment tools, Spark UDFs
  • area/server-infra: MLflow Tracking server backend
  • area/tracking: Tracking Service, tracking client APIs, autologging

Interface

  • area/uiux: Front-end, user experience, plotting, JavaScript, JavaScript dev server
  • area/docker: Docker use across MLflow's components, such as MLflow Projects and MLflow Models
  • area/sqlalchemy: Use of SQLAlchemy in the Tracking Service or Model Registry
  • area/windows: Windows support

Language

  • language/r: R APIs and clients
  • language/java: Java APIs and clients
  • language/new: Proposals for new client languages

Integrations

  • integrations/azure: Azure and Azure ML integrations
  • integrations/sagemaker: SageMaker integrations
  • integrations/databricks: Databricks integrations

How should the PR be classified in the release notes? Choose one:

  • rn/breaking-change - The PR will be mentioned in the "Breaking Changes" section
  • rn/none - No description will be included. The PR will be mentioned only by the PR number in the "Small Bugfixes and Documentation Updates" section
  • rn/feature - A new user-facing feature worth mentioning in the release notes
  • rn/bug-fix - A user-facing bug fix worth mentioning in the release notes
  • rn/documentation - A user-facing documentation change worth mentioning in the release notes

Signed-off-by: Marijn Valk <marijncv@hotmail.com>
@github-actions github-actions bot added area/projects MLproject format, project running backends rn/none List under Small Changes in Changelogs. labels Sep 21, 2021
@harupy harupy self-requested a review September 22, 2021 11:06
Signed-off-by: Marijn Valk <marijncv@hotmail.com>
Signed-off-by: Marijn Valk <marijncv@hotmail.com>
@harupy
Copy link
Member

harupy commented Sep 29, 2021

@marijncv I locally tested this PR using our example repo and it worked!

Copy link
Member

@harupy harupy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@harupy
Copy link
Member

harupy commented Sep 29, 2021

@marijncv Can you fix the lint error?
https://github.com/mlflow/mlflow/pull/4838/checks?check_run_id=3745168686#step:4:21

tests/projects/test_utils.py (7,0): [W0611 unused-import] Unused ExitStack imported from contextlib as does_not_raise

@marijncv
Copy link
Contributor Author

@harupy, I removed the unused import. Thanks for the review!

@harupy harupy merged commit 997715a into mlflow:master Sep 30, 2021
@adeandrade
Copy link

adeandrade commented May 2, 2022

@harupy @marijncv This PR is causing issues. We cannot run anything but the latest commit. Can we revert or increase GIT_FETCH_DEPTH to something reasonable?

See: #5301

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/projects MLproject format, project running backends rn/none List under Small Changes in Changelogs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants