Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show package release dates to make it easier to identify updated packages #4980

Merged
merged 8 commits into from
Nov 1, 2021

Conversation

harupy
Copy link
Member

@harupy harupy commented Nov 1, 2021

Signed-off-by: harupy hkawamura0130@gmail.com

What changes are proposed in this pull request?

This PR proposes to show package release dates to make it easier to identify updated packages when we encounter issues:

The output looks like this:

Package                              Version             Release Date
---------------------------------------------------------------------
astroid                              2.8.4               2021-10-25  
numpy                                1.21.3              2021-10-20  
xgboost                              1.5.0               2021-10-17  
mleap                                0.18.1              2021-09-27  
platformdirs                         2.4.0               2021-09-25  
pylint                               2.11.1              2021-09-16  
pytest                               6.2.5               2021-08-30  
...

How is this patch tested?

NA

Release Notes

Is this a user-facing change?

  • No. You can skip the rest of this section.
  • Yes. Give a description of this change to be included in the release notes for MLflow users.

(Details in 1-2 sentences. You can just refer to another PR with a description if this PR is part of a larger change.)

What component(s), interfaces, languages, and integrations does this PR affect?

Components

  • area/artifacts: Artifact stores and artifact logging
  • area/build: Build and test infrastructure for MLflow
  • area/docs: MLflow documentation pages
  • area/examples: Example code
  • area/model-registry: Model Registry service, APIs, and the fluent client calls for Model Registry
  • area/models: MLmodel format, model serialization/deserialization, flavors
  • area/projects: MLproject format, project running backends
  • area/scoring: MLflow Model server, model deployment tools, Spark UDFs
  • area/server-infra: MLflow Tracking server backend
  • area/tracking: Tracking Service, tracking client APIs, autologging

Interface

  • area/uiux: Front-end, user experience, plotting, JavaScript, JavaScript dev server
  • area/docker: Docker use across MLflow's components, such as MLflow Projects and MLflow Models
  • area/sqlalchemy: Use of SQLAlchemy in the Tracking Service or Model Registry
  • area/windows: Windows support

Language

  • language/r: R APIs and clients
  • language/java: Java APIs and clients
  • language/new: Proposals for new client languages

Integrations

  • integrations/azure: Azure and Azure ML integrations
  • integrations/sagemaker: SageMaker integrations
  • integrations/databricks: Databricks integrations

How should the PR be classified in the release notes? Choose one:

  • rn/breaking-change - The PR will be mentioned in the "Breaking Changes" section
  • rn/none - No description will be included. The PR will be mentioned only by the PR number in the "Small Bugfixes and Documentation Updates" section
  • rn/feature - A new user-facing feature worth mentioning in the release notes
  • rn/bug-fix - A user-facing bug fix worth mentioning in the release notes
  • rn/documentation - A user-facing documentation change worth mentioning in the release notes

Signed-off-by: harupy <hkawamura0130@gmail.com>
@github-actions github-actions bot added the rn/none List under Small Changes in Changelogs. label Nov 1, 2021
Signed-off-by: harupy <hkawamura0130@gmail.com>
Signed-off-by: harupy <hkawamura0130@gmail.com>
Signed-off-by: harupy <hkawamura0130@gmail.com>
Signed-off-by: harupy <hkawamura0130@gmail.com>
Comment on lines +1 to +4
import subprocess
import requests
from concurrent.futures import ThreadPoolExecutor
import traceback
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This script only contains standard libraries.



if __name__ == "__main__":
main()
Copy link
Member Author

@harupy harupy Nov 1, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Running this script takes 7 seconds in the flavors check where we install many ML libraries:

https://github.com/mlflow/mlflow/runs/4066994172?check_suite_focus=true#step:7:728

Mon, 01 Nov 2021 11:15:47 GMT ++ python dev/show_package_release_dates.py
Mon, 01 Nov 2021 11:15:54 GMT Package                              Version     Release Date

Given it takes 3 ~ 4 minutes to complete the package installation, 7 seconds is almost ignorable.

Signed-off-by: harupy <hkawamura0130@gmail.com>
Signed-off-by: harupy <hkawamura0130@gmail.com>
Signed-off-by: harupy <hkawamura0130@gmail.com>
Copy link
Member

@BenWilson2 BenWilson2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! And the speed improvement for lint checks is very much appreciated! :)

@harupy harupy merged commit 62f484b into mlflow:master Nov 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rn/none List under Small Changes in Changelogs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants