Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace pytorch_lightning.metrics by torchmetrics #4989

Merged
merged 3 commits into from
Nov 3, 2021

Conversation

liangz1
Copy link
Collaborator

@liangz1 liangz1 commented Nov 2, 2021

Signed-off-by: Liang Zhang liang.zhang@databricks.com

What changes are proposed in this pull request?

It appears that torchmetrics 0.6.0 (released on 2021/10/29) introduced breaking changes and broke our example tests:

https://github.com/mlflow/mlflow/runs/4058853498?check_suite_focus=true#step:7:751

Traceback (most recent call last):
  File "iterative_prune_mnist.py", line 15, in <module>
    from mnist import (
  File "/tmp/pytest-of-runner/pytest-0/test_mlflow_run_example_pytorc4/pytorch/IterativePruning/mnist.py", line 15, in <module>
    from pytorch_lightning.metrics.functional import accuracy
  File "/usr/share/miniconda/envs/mlflow-4be2c887adb73537631be3a364e2cad20927ca38/lib/python3.8/site-packages/pytorch_lightning/metrics/functional/__init__.py", line 31, in <module>
    from pytorch_lightning.metrics.functional.r2score import r2score  # noqa: F401
  File "/usr/share/miniconda/envs/mlflow-4be2c887adb73537631be3a364e2cad20927ca38/lib/python3.8/site-packages/pytorch_lightning/metrics/functional/r2score.py", line 16, in <module>
    from torchmetrics.functional import r2score as _r2score
ImportError: cannot import name 'r2score' from 'torchmetrics.functional' (/usr/share/miniconda/envs/mlflow-4be2c887adb73537631be3a364e2cad20927ca38/lib/python3.8/site-packages/torchmetrics/functional/__init__.py)

It can be fixed by replacing pytorch_lightning.metrics by torchmetrics in the import.

This PR also reverted #4976, which is a temporary workaround.

How is this patch tested?

(Details)

Release Notes

Is this a user-facing change?

  • No. You can skip the rest of this section.
  • Yes. Give a description of this change to be included in the release notes for MLflow users.

(Details in 1-2 sentences. You can just refer to another PR with a description if this PR is part of a larger change.)

What component(s), interfaces, languages, and integrations does this PR affect?

Components

  • area/artifacts: Artifact stores and artifact logging
  • area/build: Build and test infrastructure for MLflow
  • area/docs: MLflow documentation pages
  • area/examples: Example code
  • area/model-registry: Model Registry service, APIs, and the fluent client calls for Model Registry
  • area/models: MLmodel format, model serialization/deserialization, flavors
  • area/projects: MLproject format, project running backends
  • area/scoring: MLflow Model server, model deployment tools, Spark UDFs
  • area/server-infra: MLflow Tracking server backend
  • area/tracking: Tracking Service, tracking client APIs, autologging

Interface

  • area/uiux: Front-end, user experience, plotting, JavaScript, JavaScript dev server
  • area/docker: Docker use across MLflow's components, such as MLflow Projects and MLflow Models
  • area/sqlalchemy: Use of SQLAlchemy in the Tracking Service or Model Registry
  • area/windows: Windows support

Language

  • language/r: R APIs and clients
  • language/java: Java APIs and clients
  • language/new: Proposals for new client languages

Integrations

  • integrations/azure: Azure and Azure ML integrations
  • integrations/sagemaker: SageMaker integrations
  • integrations/databricks: Databricks integrations

How should the PR be classified in the release notes? Choose one:

  • rn/breaking-change - The PR will be mentioned in the "Breaking Changes" section
  • rn/none - No description will be included. The PR will be mentioned only by the PR number in the "Small Bugfixes and Documentation Updates" section
  • rn/feature - A new user-facing feature worth mentioning in the release notes
  • rn/bug-fix - A user-facing bug fix worth mentioning in the release notes
  • rn/documentation - A user-facing documentation change worth mentioning in the release notes

Signed-off-by: Liang Zhang <liang.zhang@databricks.com>
Signed-off-by: Liang Zhang <liang.zhang@databricks.com>
@liangz1 liangz1 requested a review from harupy November 2, 2021 17:54
@liangz1 liangz1 added the rn/none List under Small Changes in Changelogs. label Nov 2, 2021
Signed-off-by: Liang Zhang <liang.zhang@databricks.com>
Copy link
Member

@harupy harupy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@liangz1 liangz1 merged commit db7357f into mlflow:master Nov 3, 2021
@liangz1 liangz1 deleted the torchmetrics branch November 3, 2021 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rn/none List under Small Changes in Changelogs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants