Use globalSetup to set timezone when running JS tests
#4998
Conversation
Signed-off-by: harupy <hkawamura0130@gmail.com>
| module.exports = () => { | ||
| // On windows, the timezone is not set with `TZ=GMT`. As a workaround, use `tzutil`. | ||
| // This approach is taken from https://www.npmjs.com/package/set-tz. | ||
| if (os.platform() === 'win32') { | ||
| const TZ = 'GMT Standard Time'; | ||
| const previousTZ = execSync('tzutil /g').toString(); | ||
| const cleanup = () => { | ||
| execSync(`tzutil /s "${previousTZ}"`); | ||
| console.log(`Restored timezone to ${previousTZ}`); | ||
| }; | ||
| execSync(`tzutil /s "${TZ}"`); | ||
| console.warn( | ||
| `Changed timezone to ${TZ}. If process is killed, manually run: tzutil /s "${previousTZ}"`, | ||
| ); | ||
| process.on('exit', cleanup); | ||
| process.on('SIGINT', () => { | ||
| process.exit(2); | ||
| }); | ||
| } else { | ||
| process.env.TZ = 'GMT'; | ||
| } | ||
| }; |
There was a problem hiding this comment.
@marijncv I saw your comment: #4941 (comment). I'm curious what os.platform() returns on bash pre-installed in WSL. Is it possible to check that?
There was a problem hiding this comment.
@harupy, thanks for the PR! It returns 'linux', see screenshot below.
There was a problem hiding this comment.
@marijncv Got it, thanks for the confirmation!
There was a problem hiding this comment.
@marijncv Just out of curiosity, does TZ=GMT react-app-rewired ... work on bash in WSL?
There was a problem hiding this comment.
@harupy it does, but only when using npm run .... See screenshots below:
In any case I will start developing on WSL from now. Was using "regular" windows cmd prompt and powershell because in WSL the development server was not picking up code changes and running tests was really slow. But it turned out it was a configuration issue on my end and not WSL itself.
Signed-off-by: harupy hkawamura0130@gmail.com
What changes are proposed in this pull request?
A follow-up for #4941 to set the timezone using
globalSetupfor developers using windows.How is this patch tested?
Unit tests
Release Notes
Is this a user-facing change?
(Details in 1-2 sentences. You can just refer to another PR with a description if this PR is part of a larger change.)
What component(s), interfaces, languages, and integrations does this PR affect?
Components
area/artifacts: Artifact stores and artifact loggingarea/build: Build and test infrastructure for MLflowarea/docs: MLflow documentation pagesarea/examples: Example codearea/model-registry: Model Registry service, APIs, and the fluent client calls for Model Registryarea/models: MLmodel format, model serialization/deserialization, flavorsarea/projects: MLproject format, project running backendsarea/scoring: MLflow Model server, model deployment tools, Spark UDFsarea/server-infra: MLflow Tracking server backendarea/tracking: Tracking Service, tracking client APIs, autologgingInterface
area/uiux: Front-end, user experience, plotting, JavaScript, JavaScript dev serverarea/docker: Docker use across MLflow's components, such as MLflow Projects and MLflow Modelsarea/sqlalchemy: Use of SQLAlchemy in the Tracking Service or Model Registryarea/windows: Windows supportLanguage
language/r: R APIs and clientslanguage/java: Java APIs and clientslanguage/new: Proposals for new client languagesIntegrations
integrations/azure: Azure and Azure ML integrationsintegrations/sagemaker: SageMaker integrationsintegrations/databricks: Databricks integrationsHow should the PR be classified in the release notes? Choose one:
rn/breaking-change- The PR will be mentioned in the "Breaking Changes" sectionrn/none- No description will be included. The PR will be mentioned only by the PR number in the "Small Bugfixes and Documentation Updates" sectionrn/feature- A new user-facing feature worth mentioning in the release notesrn/bug-fix- A user-facing bug fix worth mentioning in the release notesrn/documentation- A user-facing documentation change worth mentioning in the release notes