Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for azure china #5099

Merged
merged 7 commits into from
Nov 25, 2021
Merged

Conversation

chaosddp
Copy link
Contributor

@chaosddp chaosddp commented Nov 24, 2021

What changes are proposed in this pull request?

Update the regex pattern to parse azure wasbs uri for azure china.

How is this patch tested?

Unit tests (tests/store/artifact/test_azure_blob_artifact_repo.py)

Does this PR change the documentation?

  • No. You can skip the rest of this section.
  • Yes. Make sure the changed pages / sections render correctly by following the steps below.
  1. Check the status of the ci/circleci: build_doc check. If it's successful, proceed to the
    next step, otherwise fix it.
  2. Click Details on the right to open the job page of CircleCI.
  3. Click the Artifacts tab.
  4. Click docs/build/html/index.html.
  5. Find the changed pages / sections and make sure they render correctly.

Release Notes

Is this a user-facing change?

  • No. You can skip the rest of this section.
  • Yes. Give a description of this change to be included in the release notes for MLflow users.

(Details in 1-2 sentences. You can just refer to another PR with a description if this PR is part of a larger change.)

What component(s), interfaces, languages, and integrations does this PR affect?

Components

  • area/artifacts: Artifact stores and artifact logging
  • area/build: Build and test infrastructure for MLflow
  • area/docs: MLflow documentation pages
  • area/examples: Example code
  • area/model-registry: Model Registry service, APIs, and the fluent client calls for Model Registry
  • area/models: MLmodel format, model serialization/deserialization, flavors
  • area/projects: MLproject format, project running backends
  • area/scoring: MLflow Model server, model deployment tools, Spark UDFs
  • area/server-infra: MLflow Tracking server backend
  • area/tracking: Tracking Service, tracking client APIs, autologging

Interface

  • area/uiux: Front-end, user experience, plotting, JavaScript, JavaScript dev server
  • area/docker: Docker use across MLflow's components, such as MLflow Projects and MLflow Models
  • area/sqlalchemy: Use of SQLAlchemy in the Tracking Service or Model Registry
  • area/windows: Windows support

Language

  • language/r: R APIs and clients
  • language/java: Java APIs and clients
  • language/new: Proposals for new client languages

Integrations

  • integrations/azure: Azure and Azure ML integrations
  • integrations/sagemaker: SageMaker integrations
  • integrations/databricks: Databricks integrations

How should the PR be classified in the release notes? Choose one:

  • rn/breaking-change - The PR will be mentioned in the "Breaking Changes" section
  • rn/none - No description will be included. The PR will be mentioned only by the PR number in the "Small Bugfixes and Documentation Updates" section
  • rn/feature - A new user-facing feature worth mentioning in the release notes
  • rn/bug-fix - A user-facing bug fix worth mentioning in the release notes
  • rn/documentation - A user-facing documentation change worth mentioning in the release notes

@github-actions
Copy link

@chaosddp Thanks for the contribution! The DCO check failed. Please sign off your commits by following the instructions here: https://github.com/mlflow/mlflow/runs/4309950378. See https://github.com/mlflow/mlflow/blob/master/CONTRIBUTING.rst#sign-your-work for more details.

@github-actions github-actions bot added area/artifacts Artifact stores and artifact logging rn/none List under Small Changes in Changelogs. labels Nov 24, 2021
@harupy harupy self-requested a review November 24, 2021 10:11
@harupy
Copy link
Member

harupy commented Nov 24, 2021

@chaosddp The proposed changes make sense to me! Could you fix the DCO and lint check failures?

Support Azure China api according to  https://docs.microsoft.com/en-us/azure/china/resources-developer-guide

Signed-off-by: chaosddp <chaos.you@gmail.com>
Signed-off-by: chaosddp <chaos.you@gmail.com>
Signed-off-by: chaosddp <chaos.you@gmail.com>
Signed-off-by: chaosddp <chaos.you@gmail.com>
@harupy
Copy link
Member

harupy commented Nov 25, 2021

Signed-off-by: chaosddp <chaos.you@gmail.com>
@harupy harupy marked this pull request as ready for review November 25, 2021 03:56
Copy link
Member

@harupy harupy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@chaosddp
Copy link
Contributor Author

Lint for test, sorry, will update it...

Signed-off-by: chaosddp <chaos.you@gmail.com>
Signed-off-by: chaosddp <chaos.you@gmail.com>
@chaosddp
Copy link
Contributor Author

Lint for test, sorry, will update it...

@chaosddp chaosddp closed this Nov 25, 2021
@chaosddp chaosddp reopened this Nov 25, 2021
@harupy harupy merged commit f5fec68 into mlflow:master Nov 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/artifacts Artifact stores and artifact logging rn/none List under Small Changes in Changelogs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants