Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow alembic>=1.7.5 #5245

Closed

Conversation

jbvaningen
Copy link

@jbvaningen jbvaningen commented Jan 10, 2022

What changes are proposed in this pull request?

The change is simply to increase the allowed upper version bound of alembic to 1.7.5.

This is important because in our organization we install airflow and mlflow in the same environment. Current version constraint "alembic<=1.4.1" is blocking upgrade to latest airflow==2.2.3.

Relevant issue: #4215
Similar PR: #4810

How is this patch tested?

I am aware I could only test this in a limited way, and only for one type of store backend (postgresql), but I did the following:

  • Installed mlflow==0.13.1 locally with a postgresql backend
  • Ran some operations against MLflow: create an experiment with a few runs, tags, registered a model
  • Installed updated mlflow from source, upgraded to alembic==1.7.5
  • Ran mlflow db upgrade ${psql_path}
  • Verified data after upgrade

Does this PR change the documentation?

  • No. You can skip the rest of this section.
  • Yes. Make sure the changed pages / sections render correctly by following the steps below.
  1. Check the status of the ci/circleci: build_doc check. If it's successful, proceed to the
    next step, otherwise fix it.
  2. Click Details on the right to open the job page of CircleCI.
  3. Click the Artifacts tab.
  4. Click docs/build/html/index.html.
  5. Find the changed pages / sections and make sure they render correctly.

Release Notes

Is this a user-facing change?

  • No. You can skip the rest of this section.
  • Yes. Give a description of this change to be included in the release notes for MLflow users.

(Details in 1-2 sentences. You can just refer to another PR with a description if this PR is part of a larger change.)

What component(s), interfaces, languages, and integrations does this PR affect?

Components

  • area/artifacts: Artifact stores and artifact logging
  • area/build: Build and test infrastructure for MLflow
  • area/docs: MLflow documentation pages
  • area/examples: Example code
  • area/model-registry: Model Registry service, APIs, and the fluent client calls for Model Registry
  • area/models: MLmodel format, model serialization/deserialization, flavors
  • area/projects: MLproject format, project running backends
  • area/scoring: MLflow Model server, model deployment tools, Spark UDFs
  • area/server-infra: MLflow Tracking server backend
  • area/tracking: Tracking Service, tracking client APIs, autologging

Interface

  • area/uiux: Front-end, user experience, plotting, JavaScript, JavaScript dev server
  • area/docker: Docker use across MLflow's components, such as MLflow Projects and MLflow Models
  • area/sqlalchemy: Use of SQLAlchemy in the Tracking Service or Model Registry
  • area/windows: Windows support

Language

  • language/r: R APIs and clients
  • language/java: Java APIs and clients
  • language/new: Proposals for new client languages

Integrations

  • integrations/azure: Azure and Azure ML integrations
  • integrations/sagemaker: SageMaker integrations
  • integrations/databricks: Databricks integrations

How should the PR be classified in the release notes? Choose one:

  • rn/breaking-change - The PR will be mentioned in the "Breaking Changes" section
  • rn/none - No description will be included. The PR will be mentioned only by the PR number in the "Small Bugfixes and Documentation Updates" section
  • rn/feature - A new user-facing feature worth mentioning in the release notes
  • rn/bug-fix - A user-facing bug fix worth mentioning in the release notes
  • rn/documentation - A user-facing documentation change worth mentioning in the release notes

I would figure that updating the db migration tool is quite relevant to mention to users, who might want to take extra precautions during upgrades.

@github-actions github-actions bot added area/server-infra MLflow Tracking server backend rn/documentation Mention under Documentation Changes in Changelogs. labels Jan 10, 2022
@harupy
Copy link
Member

harupy commented Jan 11, 2022

Hi @jbvaningen, thanks for the PR, we found unpinning alembic changes the runs table definition (which causes several tests to fail). We're investigating how to fix it in #5249.

@harupy harupy mentioned this pull request Jan 12, 2022
29 tasks
@harupy harupy closed this in #5249 Jan 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/server-infra MLflow Tracking server backend rn/documentation Mention under Documentation Changes in Changelogs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants