Replace "--no-conda" with "--env-manager", "local" in tests

[nishipy]

What changes are proposed in this pull request?

Fix #5590.

How is this patch tested?

Existing tests

Does this PR change the documentation?

• No. You can skip the rest of this section.
• Yes. Make sure the changed pages / sections render correctly by following the steps below.

1. Check the status of the ci/circleci: build_doc check. If it's successful, proceed to the
   next step, otherwise fix it.
2. Click Details on the right to open the job page of CircleCI.
3. Click the Artifacts tab.
4. Click docs/build/html/index.html.
5. Find the changed pages / sections and make sure they render correctly.

Release Notes

Is this a user-facing change?

• No. You can skip the rest of this section.
• Yes. Give a description of this change to be included in the release notes for MLflow users.

(Details in 1-2 sentences. You can just refer to another PR with a description if this PR is part of a larger change.)

What component(s), interfaces, languages, and integrations does this PR affect?

Components

• area/artifacts: Artifact stores and artifact logging
• area/build: Build and test infrastructure for MLflow
• area/docs: MLflow documentation pages
• area/examples: Example code
• area/model-registry: Model Registry service, APIs, and the fluent client calls for Model Registry
• area/models: MLmodel format, model serialization/deserialization, flavors
• area/projects: MLproject format, project running backends
• area/scoring: MLflow Model server, model deployment tools, Spark UDFs
• area/server-infra: MLflow Tracking server backend
• area/tracking: Tracking Service, tracking client APIs, autologging

Interface

• area/uiux: Front-end, user experience, plotting, JavaScript, JavaScript dev server
• area/docker: Docker use across MLflow's components, such as MLflow Projects and MLflow Models
• area/sqlalchemy: Use of SQLAlchemy in the Tracking Service or Model Registry
• area/windows: Windows support

Language

• language/r: R APIs and clients
• language/java: Java APIs and clients
• language/new: Proposals for new client languages

Integrations

• integrations/azure: Azure and Azure ML integrations
• integrations/sagemaker: SageMaker integrations
• integrations/databricks: Databricks integrations

How should the PR be classified in the release notes? Choose one:

• rn/breaking-change - The PR will be mentioned in the "Breaking Changes" section
• rn/none - No description will be included. The PR will be mentioned only by the PR number in the "Small Bugfixes and Documentation Updates" section
• rn/feature - A new user-facing feature worth mentioning in the release notes
• rn/bug-fix - A user-facing bug fix worth mentioning in the release notes
• rn/documentation - A user-facing documentation change worth mentioning in the release notes

[harupy]

@nishipy Thanks for the PR!

Can you also fix this line?
https://github.com/nishipy/mlflow/blob/9f6da780018a5b1a0f4acca7fd9142b9e41f6876/tests/diviner/test_diviner_model_export.py#L40

[harupy]

pylint complains this is too long

https://github.com/mlflow/mlflow/runs/5830151998?check_suite_focus=true#step:7:20

tests/helper_functions.py:161:0: C0301: Line too long (119/100) (line-too-long)

Can you adjust the line length by wrapping it?

[nishipy]

Hi @harupy,
Thank you for your points!
I will fix and commit them. Thanks

[harupy]

LGTM (if all the CI checks pass)!

[harupy]

@nishipy Thanks for working on this PR, would you be interested in making another contribution?

[nishipy]

@nishipy Thanks for working on this PR, would you be interested in making another contribution?

@harupy Thank you for your help. Yes, of course! I like it.

[harupy]

@nishipy Awesome, our team found this GitHub feature that annotates code with lint warnings/errors like the image below:

https://github.com/actions/toolkit/blob/main/docs/problem-matchers.md#problem-matchers

In the attached image, javascript files are annotated. We want to do the same thing for python scripts.

Motivation

Here's a brief comparison of how we check lint errors between with and without this feature:

Now

1. Scroll down to the bottom of a PR page.
2. Click the lint check details.
3. Explore the build logs to find lint errors.

If we use this feature

1. Open the files-changed tab. That's it. GitHub already marked the lines violating out lint check rules.

What needs to be done?

1. Add a file that defines matching rules (example)
2. Add a step to enable the problem matcher.
3. Make a dummy code change (e.g. define an unused variable) to check the problem matcher works.

mlflow/.github/workflows/master.yml

Line 37 in dc3758c

- name: Install dependencies

Please let me know if you're interested in this. I'll provide more details if you're.

[nishipy]

Actually it is the first time for me to see this GitHub feature, but it looks so interesting and useful for us. Let me know more details.
https://github.com/mlflow/mlflow/pull/5613/files

[harupy]

Of course, I described what needs to be done in my comment above. I think we can test this feature with pylint.

[harupy]

@nishipy Let me know if you have questions.

[nishipy]

Thanks for the information. I will try it.
By the way, do we have to create a issue about that before submitting PR?

[harupy]

@nishipy No, we don't have to :)

[harupy]

@nishipy We can enable problem matchers like this:
https://github.com/ianchi/remotecodes/blob/cce29ae9846a759a4e518840458ced32275df3de/.github/workflows/ci.yml#L60

      - name: Register problem matchers
        run: |
          echo "::add-matcher::.github/workflows/matchers/pylint.json"

[nishipy]

@harupy Thanks! If I understand correctly, we have to implement the following things:

1. Add .json file to define regexp for detecting errors on pylint
2. Add the lines (as you describe just above) to the existing workflow definition

[harupy]

@nishipy Yes, exactly!

[nishipy]

Got it! I will start to do that later.

[nishipy]

Hi @harupy, I created PR #5639. Please take a look!