Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Twitte badge on README #5605

Merged
merged 1 commit into from
Apr 5, 2022
Merged

Add Twitte badge on README #5605

merged 1 commit into from
Apr 5, 2022

Conversation

guelate
Copy link
Contributor

@guelate guelate commented Apr 5, 2022

Addresses #5594

What

I added the dependency for twitter.

Before

avant

After

apres

@harupy harupy added the rn/none List under Small Changes in Changelogs. label Apr 5, 2022
@harupy harupy changed the title [ADD BADGE TWITTER] update README Add Twitte badge on README Apr 5, 2022
@harupy
Copy link
Member

harupy commented Apr 5, 2022

@guelate Thanks for the PR, can you fix the DCO check failure?
https://github.com/mlflow/mlflow/pull/5605/checks?check_run_id=5831354328

@guelate
Copy link
Contributor Author

guelate commented Apr 5, 2022

@harupy Okay I'm looking for a way to do it.

@harupy
Copy link
Member

harupy commented Apr 5, 2022

@guelate You can run these commands:

git rebase HEAD~1 --signoff
git push --force-with-lease origin Twitter_link

Signed-off-by: Guelate <guelateseyo@gmail.com>
@guelate
Copy link
Contributor Author

guelate commented Apr 5, 2022

@harupy Yes it's good thanks :)

@github-actions
Copy link

github-actions bot commented Apr 5, 2022

@guelate Thanks for the contribution! The DCO check failed. Please sign off your commits by following the instructions here: https://github.com/mlflow/mlflow/runs/5831354328. See https://github.com/mlflow/mlflow/blob/master/CONTRIBUTING.rst#sign-your-work for more details.


@guelate Never mind this comment.

Copy link
Member

@harupy harupy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@guelate LGTM, thanks for the contribution!

@harupy harupy merged commit e7caa0a into mlflow:master Apr 5, 2022
@guelate guelate deleted the Twitter_link branch April 5, 2022 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rn/none List under Small Changes in Changelogs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants