Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix icon and update logos and favicon #5618

Merged
merged 3 commits into from
Apr 7, 2022
Merged

Fix icon and update logos and favicon #5618

merged 3 commits into from
Apr 7, 2022

Conversation

sisp
Copy link
Contributor

@sisp sisp commented Apr 6, 2022

What changes are proposed in this pull request?

The two circular arrows in the MLflow icon do not have identical shape which I believe is unintended. The top-left arrow has an inner radius of ~7.5 whereas the bottom-right arrow has an inner radius of ~7.7.

This PR fixes the icon by making the bottom-right arrow a flipped copy of the top-left arrow. The logo is updated accordingly and all PNG images and the favicon are re-generated from the vector graphics.

Follow-up of #5529.

Does this PR change the documentation?

  • No. You can skip the rest of this section.
  • Yes. Make sure the changed pages / sections render correctly by following the steps below.

Release Notes

none

Is this a user-facing change?

  • No. You can skip the rest of this section.
  • Yes. Give a description of this change to be included in the release notes for MLflow users.

What component(s), interfaces, languages, and integrations does this PR affect?

Components

  • area/artifacts: Artifact stores and artifact logging
  • area/build: Build and test infrastructure for MLflow
  • area/docs: MLflow documentation pages
  • area/examples: Example code
  • area/model-registry: Model Registry service, APIs, and the fluent client calls for Model Registry
  • area/models: MLmodel format, model serialization/deserialization, flavors
  • area/projects: MLproject format, project running backends
  • area/scoring: MLflow Model server, model deployment tools, Spark UDFs
  • area/server-infra: MLflow Tracking server backend
  • area/tracking: Tracking Service, tracking client APIs, autologging

Interface

  • area/uiux: Front-end, user experience, plotting, JavaScript, JavaScript dev server
  • area/docker: Docker use across MLflow's components, such as MLflow Projects and MLflow Models
  • area/sqlalchemy: Use of SQLAlchemy in the Tracking Service or Model Registry
  • area/windows: Windows support

Language

  • language/r: R APIs and clients
  • language/java: Java APIs and clients
  • language/new: Proposals for new client languages

Integrations

  • integrations/azure: Azure and Azure ML integrations
  • integrations/sagemaker: SageMaker integrations
  • integrations/databricks: Databricks integrations

How should the PR be classified in the release notes? Choose one:

  • rn/breaking-change - The PR will be mentioned in the "Breaking Changes" section
  • rn/none - No description will be included. The PR will be mentioned only by the PR number in the "Small Bugfixes and Documentation Updates" section
  • rn/feature - A new user-facing feature worth mentioning in the release notes
  • rn/bug-fix - A user-facing bug fix worth mentioning in the release notes
  • rn/documentation - A user-facing documentation change worth mentioning in the release notes

Signed-off-by: Sigurd Spieckermann <sigurd.spieckermann@gmail.com>
@github-actions github-actions bot added area/docs Documentation issues rn/none List under Small Changes in Changelogs. labels Apr 6, 2022
@harupy
Copy link
Member

harupy commented Apr 6, 2022

@sisp

Can we remove TM in the new image? or was this added on purpose?

image

assets/icon.svg Show resolved Hide resolved
Signed-off-by: Sigurd Spieckermann <sigurd.spieckermann@gmail.com>
@sisp
Copy link
Contributor Author

sisp commented Apr 6, 2022

No, the TM wasn't added on purpose. It's in the SVG logo and I simply exported a PNG version, that's why it was added. I've pushed a commit where it's removed again.

@sisp
Copy link
Contributor Author

sisp commented Apr 6, 2022

Ah, would you like the TM removed in the SVG logo, too? I merely committed the unmodified SVGs in #5529 and the TM was included there.

@harupy
Copy link
Member

harupy commented Apr 7, 2022

@sisp Thanks for the reply. We discussed whether the logo should include the TM. Let's add it. Sorry for the confusion.

Copy link
Member

@harupy harupy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once #5618 (comment) is addressed!

This reverts commit c94f7ce.

Signed-off-by: Sigurd Spieckermann <sigurd.spieckermann@gmail.com>
@sisp
Copy link
Contributor Author

sisp commented Apr 7, 2022

@harupy No worries, I've reverted the last commit, so the TM is included in the PNG again.

@harupy
Copy link
Member

harupy commented Apr 7, 2022

thanks!

@harupy harupy merged commit f21c63f into mlflow:master Apr 7, 2022
@sisp sisp deleted the fix-icon branch April 7, 2022 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/docs Documentation issues rn/none List under Small Changes in Changelogs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants