Remove attempted sqlalchemy import from mlflow skinny search path and add tests #5622
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area/tracking
dbczumar
commented
Apr 6, 2022
| @@ -33,5 +33,7 @@ pytest tests/deployments/test_cli.py | |||
| pytest tests/deployments/test_deployments.py | |||
| pytest tests/projects/test_projects_cli.py | |||
| pytest tests/utils/test_requirements_utils.py::test_infer_requirements_excludes_mlflow | |||
| pytest tests/store/tracking/test_file_store.py | |||
There was a problem hiding this comment.
Add file store testing because:
- skinny should support file store without any additional dependencies
- test_file_store tests basic search capabilities
dbczumar
commented
Apr 6, 2022
Comment on lines
-18
to
-33
| import pandas as pd | ||
| import pytest | ||
|
|
||
| import mlflow | ||
| import mlflow.pyfunc.scoring_server as pyfunc_scoring_server | ||
| import mlflow.pyfunc | ||
| from mlflow.tracking.artifact_utils import _download_artifact_from_uri | ||
| from mlflow.utils.file_utils import read_yaml, write_yaml | ||
| from mlflow.utils.model_utils import _get_flavor_configuration, FLAVOR_CONFIG_CODE | ||
| from mlflow.utils.environment import ( | ||
| _get_pip_deps, | ||
| _CONDA_ENV_FILE_NAME, | ||
| _REQUIREMENTS_FILE_NAME, | ||
| _CONSTRAINTS_FILE_NAME, | ||
| ) | ||
| from mlflow.utils.requirements_utils import _get_installed_version |
There was a problem hiding this comment.
Tuck imports with dependencies that are not skinny-friendly (e.g. pandas) inside the helper functions where they're actually used. This is necessary because test_file_store depends on some utils from helper_functions.py
BenWilson2
approved these changes
Apr 6, 2022
Thanks Ben! I think we can rely on test coverage here. Import tucking is pretty standard throughout most of the MLflow code base and isn't documented; IMO, no need for extra care / caution in this particular file. |
nishipy
pushed a commit
to nishipy/mlflow
that referenced
this pull request
Apr 8, 2022
… add tests (mlflow#5622) * Fix Signed-off-by: dbczumar <corey.zumar@databricks.com> * Tests Signed-off-by: dbczumar <corey.zumar@databricks.com> * Test refactor Signed-off-by: dbczumar <corey.zumar@databricks.com> * Fix Signed-off-by: dbczumar <corey.zumar@databricks.com> * Path fix Signed-off-by: dbczumar <corey.zumar@databricks.com> Signed-off-by: nishipy <goodisonev4@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: dbczumar corey.zumar@databricks.com
What changes are proposed in this pull request?
Remove attempted sqlalchemy import from mlflow skinny search path and add tests
How is this patch tested?
Added test coverage
Does this PR change the documentation?
ci/circleci: build_doccheck. If it's successful, proceed to thenext step, otherwise fix it.
Detailson the right to open the job page of CircleCI.Artifactstab.docs/build/html/index.html.Release Notes
Is this a user-facing change?
(Details in 1-2 sentences. You can just refer to another PR with a description if this PR is part of a larger change.)
What component(s), interfaces, languages, and integrations does this PR affect?
Components
area/artifacts: Artifact stores and artifact loggingarea/build: Build and test infrastructure for MLflowarea/docs: MLflow documentation pagesarea/examples: Example codearea/model-registry: Model Registry service, APIs, and the fluent client calls for Model Registryarea/models: MLmodel format, model serialization/deserialization, flavorsarea/projects: MLproject format, project running backendsarea/scoring: MLflow Model server, model deployment tools, Spark UDFsarea/server-infra: MLflow Tracking server backendarea/tracking: Tracking Service, tracking client APIs, autologgingInterface
area/uiux: Front-end, user experience, plotting, JavaScript, JavaScript dev serverarea/docker: Docker use across MLflow's components, such as MLflow Projects and MLflow Modelsarea/sqlalchemy: Use of SQLAlchemy in the Tracking Service or Model Registryarea/windows: Windows supportLanguage
language/r: R APIs and clientslanguage/java: Java APIs and clientslanguage/new: Proposals for new client languagesIntegrations
integrations/azure: Azure and Azure ML integrationsintegrations/sagemaker: SageMaker integrationsintegrations/databricks: Databricks integrationsHow should the PR be classified in the release notes? Choose one:
rn/breaking-change- The PR will be mentioned in the "Breaking Changes" sectionrn/none- No description will be included. The PR will be mentioned only by the PR number in the "Small Bugfixes and Documentation Updates" sectionrn/feature- A new user-facing feature worth mentioning in the release notesrn/bug-fix- A user-facing bug fix worth mentioning in the release notesrn/documentation- A user-facing documentation change worth mentioning in the release notes