Change github markdown templates to yaml #5803
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Getting the following error in Release-note category / validate (pull_request). Can the maintainer apply the category label? |
|
Can we rebase on master? |
I reran the job. It should pass this time. |
harupy
reviewed
Apr 30, 2022
harupy
reviewed
Apr 30, 2022
harupy
reviewed
Apr 30, 2022
harupy
reviewed
Apr 30, 2022
harupy
reviewed
Apr 30, 2022
harupy
reviewed
Apr 30, 2022
harupy
reviewed
Apr 30, 2022
harupy
reviewed
Apr 30, 2022
ahlag
force-pushed
the
change-templates-to-yaml
branch
from
660ade6
to
c97b13c
Compare
|
@harupy |
|
@ahlag Can you try this https://stackoverflow.com/a/25357146? git reset $(git merge-base master $(git branch --show-current))
git add -A
git commit -s -m "<commit message>" |
Signed-off-by: Chang Yong Lik <theeahlag@gmail.com>
|
@harupy I have tried with some luck. ❯ git reset $(git merge-base master $(git branch --show-current)) ─╯
Unstaged changes after reset:
D .github/ISSUE_TEMPLATE/bug_report_template.md
D .github/ISSUE_TEMPLATE/doc_fix_template.md
D .github/ISSUE_TEMPLATE/feature_request_template.md
D .github/ISSUE_TEMPLATE/installation_issue_template.md
M mlflow/server/js/src/experiment-tracking/components/HtmlTableView.js
M mlflow/server/js/src/experiment-tracking/components/MetricView.css
M mlflow/server/js/src/experiment-tracking/components/MetricsPlotPanel.js
M mlflow/server/js/src/experiment-tracking/components/MetricsPlotPanel.test.js
M mlflow/server/js/src/experiment-tracking/reducers/MetricReducer.js
M mlflow/server/js/src/experiment-tracking/reducers/MetricReducer.test.js
M mlflow/server/js/src/experiment-tracking/reducers/Reducers.js
M mlflow/server/js/src/i18n/default/en.json
❯ git add -A
❯ git commit -s -m "reset index"
[change-templates-to-yaml c06ba1fc] reset index
18 files changed, 1343 insertions(+), 230 deletions(-)
delete mode 100644 .github/ISSUE_TEMPLATE/bug_report_template.md
create mode 100644 .github/ISSUE_TEMPLATE/bug_report_template.yaml
delete mode 100644 .github/ISSUE_TEMPLATE/doc_fix_template.md
create mode 100644 .github/ISSUE_TEMPLATE/doc_fix_template.yaml
delete mode 100644 .github/ISSUE_TEMPLATE/feature_request_template.md
create mode 100644 .github/ISSUE_TEMPLATE/feature_request_template.yaml
delete mode 100644 .github/ISSUE_TEMPLATE/installation_issue_template.md
create mode 100644 .github/ISSUE_TEMPLATE/installation_issue_template.yaml
create mode 100644 mlflow/server/js/src/experiment-tracking/components/MetricsSummaryTable.js
create mode 100644 mlflow/server/js/src/experiment-tracking/components/MetricsSummaryTable.test.js
❯ git push --force-with-lease origin change-templates-to-yaml ─╯
To github.com:ahlag/mlflow.git
! [rejected] change-templates-to-yaml -> change-templates-to-yaml (stale info)
error: failed to push some refs to 'github.com:ahlag/mlflow.git'Not sure if this solves it. (git prune remote origin) |
|
Have you tried |
ahlag
force-pushed
the
change-templates-to-yaml
branch
from
56b20e7
to
c06ba1f
Compare
|
@harupy |
|
@ahlag can you temporarily change the default branch of your fork to this PR branch? |
|
@harupy |
harupy
reviewed
May 2, 2022
| required: false | ||
| - type: textarea | ||
| attributes: | ||
| label: Details |
There was a problem hiding this comment.
Can we move this section after the motivation section?
harupy
reviewed
May 2, 2022
Comment on lines
39
to
45
| ### What is the use case for this feature? | ||
|
|
||
| ### Why is this use case valuable to support for MLflow users in general? | ||
|
|
||
| ### Why is this use case valuable to support for your project(s) or organization? | ||
|
|
||
| ### Why is it currently difficult to achieve this use case? |
There was a problem hiding this comment.
Suggested change
| ### What is the use case for this feature? | |
| ### Why is this use case valuable to support for MLflow users in general? | |
| ### Why is this use case valuable to support for your project(s) or organization? | |
| ### Why is it currently difficult to achieve this use case? | |
| #### What is the use case for this feature? | |
| #### Why is this use case valuable to support for MLflow users in general? | |
| #### Why is this use case valuable to support for your project(s) or organization? | |
| #### Why is it currently difficult to achieve this use case? |
because the section header (Motivation) uses ###.
harupy
approved these changes
May 2, 2022
Signed-off-by: Chang Yong Lik <theeahlag@gmail.com>
…to change-templates-to-yaml
|
@harupy |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes are proposed in this pull request?
Change github markdown templates to yaml
How is this patch tested?
Tested Locally on a different forked repository
https://github.com/ahlag/mlflow
Does this PR change the documentation?
ci/circleci: build_doccheck. If it's successful, proceed to thenext step, otherwise fix it.
Detailson the right to open the job page of CircleCI.Artifactstab.docs/build/html/index.html.Release Notes
Is this a user-facing change?
(Details in 1-2 sentences. You can just refer to another PR with a description if this PR is part of a larger change.)
What component(s), interfaces, languages, and integrations does this PR affect?
Components
area/artifacts: Artifact stores and artifact loggingarea/build: Build and test infrastructure for MLflowarea/docs: MLflow documentation pagesarea/examples: Example codearea/model-registry: Model Registry service, APIs, and the fluent client calls for Model Registryarea/models: MLmodel format, model serialization/deserialization, flavorsarea/projects: MLproject format, project running backendsarea/scoring: MLflow Model server, model deployment tools, Spark UDFsarea/server-infra: MLflow Tracking server backendarea/tracking: Tracking Service, tracking client APIs, autologgingInterface
area/uiux: Front-end, user experience, plotting, JavaScript, JavaScript dev serverarea/docker: Docker use across MLflow's components, such as MLflow Projects and MLflow Modelsarea/sqlalchemy: Use of SQLAlchemy in the Tracking Service or Model Registryarea/windows: Windows supportLanguage
language/r: R APIs and clientslanguage/java: Java APIs and clientslanguage/new: Proposals for new client languagesIntegrations
integrations/azure: Azure and Azure ML integrationsintegrations/sagemaker: SageMaker integrationsintegrations/databricks: Databricks integrationsHow should the PR be classified in the release notes? Choose one:
rn/breaking-change- The PR will be mentioned in the "Breaking Changes" sectionrn/none- No description will be included. The PR will be mentioned only by the PR number in the "Small Bugfixes and Documentation Updates" sectionrn/feature- A new user-facing feature worth mentioning in the release notesrn/bug-fix- A user-facing bug fix worth mentioning in the release notesrn/documentation- A user-facing documentation change worth mentioning in the release notes