Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various updates to UI server #61

Merged
merged 2 commits into from
Jun 19, 2018
Merged

Conversation

mateiz
Copy link
Contributor

@mateiz mateiz commented Jun 19, 2018

  • Add an mlflow server command separate from mlflow ui that can run with more workers and might eventually provide more production options
  • Use gunicorn to run ui and server
  • Miscellaneous fixes to CLI option names and their help strings

* Add an `mlflow server` command separate from `mlflow ui` that can run with more workers and will (eventually) be the only one to allow updates
* Use gunicorn to run ui and server
* Miscellaneous fixes to CLI help
@aarondav
Copy link
Contributor

LGTM. Ran both locally, worked as expected.

@aarondav aarondav added the LGTM label Jun 19, 2018
@codecov-io
Copy link

Codecov Report

Merging #61 into master will decrease coverage by 0.26%.
The diff coverage is 36.95%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #61      +/-   ##
=========================================
- Coverage   77.46%   77.2%   -0.27%     
=========================================
  Files          45      45              
  Lines        2592    2610      +18     
=========================================
+ Hits         2008    2015       +7     
- Misses        584     595      +11
Impacted Files Coverage Δ
mlflow/store/file_store.py 90.95% <0%> (-0.48%) ⬇️
mlflow/experiments.py 57.89% <100%> (ø) ⬆️
mlflow/server/handlers.py 27.9% <12.5%> (+0.02%) ⬆️
mlflow/server/__init__.py 65.21% <37.5%> (-16.04%) ⬇️
mlflow/cli.py 84.5% <81.81%> (+0.92%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 35a2bf6...3c3acee. Read the comment docs.

@aarondav aarondav merged commit 5478ba0 into mlflow:master Jun 19, 2018
@mateiz mateiz mentioned this pull request Jun 19, 2018
mateiz pushed a commit that referenced this pull request Jun 25, 2018
parameter name and click.option got out of sync while working on #61
jdlesage pushed a commit to jdlesage/mlflow that referenced this pull request Dec 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants