Address some issues with compact runs view #620
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
That's great, these are definitely two changes we want. |
aarondav
reviewed
Oct 11, 2018
| @@ -310,6 +310,7 @@ class ExperimentView extends Component { | |||
| </ButtonGroup> | |||
| </span> | |||
| </div> | |||
| <div> | |||
There was a problem hiding this comment.
Does this affect the layout?
There was a problem hiding this comment.
Oops, this change was accidentally kept in from when I was trying to get the table to scroll on overflow. Will remove!
you could click (cursor:pointer was active) on the sort dropdown for an individual metric or param but the text wouldn't be underlined
|
Thanks @aarondav for the catch! Made another small change to prevent a weird corner case where hovering near the edge of a metric/param name would cause the cursor to change to a pointer but not underline the metric/param name (i.e. now the text should always be underlined when the cursor is a pointer). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: I held off on addressing some other suggestions (like fixing the max-width of the table & adding horizontal scrolling on overflow) since doing those correctly might require some additional discussion (do we also add vertical scrolling, should we consider using a different table component to allow for fixed headers, etc)