Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update mlflowclient to implement java.io.closeable #6580

Merged
merged 1 commit into from
Sep 14, 2022

Conversation

bbarnes52
Copy link
Collaborator

@bbarnes52 bbarnes52 commented Aug 24, 2022

Signed-off-by: Brian Barnes brian.barnes@databricks.com

What changes are proposed in this pull request?

Updates MlflowClient to implement java.io.Closeable. This allows callers to close the client in order to avoid socket leaks.

I opted not to propagate the IOException through to the caller, it is a customer-facing API (simplicity is especially important) and it is unlikely the caller would be able to do anything productive with this information.

Does this PR change the documentation?

  • No. You can skip the rest of this section.
  • Yes. Make sure the changed pages / sections render correctly by following the steps below.

Release Notes

Is this a user-facing change?

  • No. You can skip the rest of this section.
  • Yes. Give a description of this change to be included in the release notes for MLflow users.

What component(s), interfaces, languages, and integrations does this PR affect?

Components

  • area/artifacts: Artifact stores and artifact logging
  • area/build: Build and test infrastructure for MLflow
  • area/docs: MLflow documentation pages
  • area/examples: Example code
  • area/model-registry: Model Registry service, APIs, and the fluent client calls for Model Registry
  • area/models: MLmodel format, model serialization/deserialization, flavors
  • area/pipelines: Pipelines, Pipeline APIs, Pipeline configs, Pipeline Templates
  • area/projects: MLproject format, project running backends
  • area/scoring: MLflow Model server, model deployment tools, Spark UDFs
  • area/server-infra: MLflow Tracking server backend
  • area/tracking: Tracking Service, tracking client APIs, autologging

Interface

  • area/uiux: Front-end, user experience, plotting, JavaScript, JavaScript dev server
  • area/docker: Docker use across MLflow's components, such as MLflow Projects and MLflow Models
  • area/sqlalchemy: Use of SQLAlchemy in the Tracking Service or Model Registry
  • area/windows: Windows support

Language

  • language/r: R APIs and clients
  • language/java: Java APIs and clients
  • language/new: Proposals for new client languages

Integrations

  • integrations/azure: Azure and Azure ML integrations
  • integrations/sagemaker: SageMaker integrations
  • integrations/databricks: Databricks integrations

How should the PR be classified in the release notes? Choose one:

  • rn/breaking-change - The PR will be mentioned in the "Breaking Changes" section
  • rn/none - No description will be included. The PR will be mentioned only by the PR number in the "Small Bugfixes and Documentation Updates" section
  • rn/feature - A new user-facing feature worth mentioning in the release notes
  • rn/bug-fix - A user-facing bug fix worth mentioning in the release notes
  • rn/documentation - A user-facing documentation change worth mentioning in the release notes

@github-actions github-actions bot added language/java Java APIs and clients rn/none List under Small Changes in Changelogs. labels Aug 24, 2022
@bbarnes52 bbarnes52 force-pushed the closehttpclient branch 3 times, most recently from e681a74 to 5bca6d7 Compare September 12, 2022 23:04
Signed-off-by: Brian Barnes <brian.barnes@databricks.com>
Copy link
Collaborator

@dbczumar dbczumar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @bbarnes52 !

@bbarnes52 bbarnes52 merged commit 264125c into mlflow:master Sep 14, 2022
nnethery pushed a commit to nnethery/mlflow that referenced this pull request Feb 1, 2024
Signed-off-by: Brian Barnes <brian.barnes@databricks.com>

Signed-off-by: Brian Barnes <brian.barnes@databricks.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
language/java Java APIs and clients rn/none List under Small Changes in Changelogs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants