-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wheeled Model #6586
Wheeled Model #6586
Conversation
Signed-off-by: Arjun DCunha <arjun.dcunha@databricks.com>
mlflow/models/wheeled_model.py
Outdated
os.makedirs(dst_path) | ||
|
||
download_command = ( | ||
f"python -m pip wheel --only-binary=:all: --wheel-dir={dst_path} -r" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if there is a better mechanism?
mlflow/models/wheeled_model.py
Outdated
os.makedirs(dst_path) | ||
|
||
download_command = ( | ||
f"python -m pip wheel --only-binary=:all: --wheel-dir={dst_path} -r" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why the --only-binary flag?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was to prevent downloading source packages. I guess that wont be as big of a problem as I am imagine it, since sdist can be harder to work with?
Signed-off-by: Arjun DCunha <arjun.dcunha@databricks.com>
Signed-off-by: Arjun DCunha <arjun.dcunha@databricks.com>
Signed-off-by: Arjun DCunha <arjun.dcunha@databricks.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM once https://github.com/mlflow/mlflow/pull/6586/files#r965454194 is addressed. Thanks @arjundc-db !
I got the following warning when I served a model logged by
We can fix this in a follow-up PR. Traceback:
|
Signed-off-by: Arjun DCunha <arjun.dcunha@databricks.com>
* Wheeled Model Signed-off-by: Arjun DCunha <arjun.dcunha@databricks.com> * Docs Signed-off-by: Arjun DCunha <arjun.dcunha@databricks.com> * Comments Signed-off-by: Arjun DCunha <arjun.dcunha@databricks.com> * More tests Signed-off-by: Arjun DCunha <arjun.dcunha@databricks.com> * English Signed-off-by: Arjun DCunha <arjun.dcunha@databricks.com> * Comments part 2 Signed-off-by: Arjun DCunha <arjun.dcunha@databricks.com> * fix Signed-off-by: Arjun DCunha <arjun.dcunha@databricks.com> * Haru Comments Signed-off-by: Arjun DCunha <arjun.dcunha@databricks.com> Signed-off-by: Arjun DCunha <arjun.dcunha@databricks.com>
Signed-off-by: Arjun DCunha arjun.dcunha@databricks.com
Related Issues/PRs
#xxx
What changes are proposed in this pull request?
Add functionality to create a
wheeled
model where the dependencies are stored as wheels along with the model. Credit goes to anirudhachal-db who started this #6416How to use:
How is this patch tested?
Unit tests have been added.
I also manually tested this functionality.
Does this PR change the documentation?
Details
link on thePreview docs
check.Release Notes
Is this a user-facing change?
Add functionality to create a
wheeled
model where the dependencies are stored as wheels along with the model.(Details in 1-2 sentences. You can just refer to another PR with a description if this PR is part of a larger change.)
What component(s), interfaces, languages, and integrations does this PR affect?
Components
area/artifacts
: Artifact stores and artifact loggingarea/build
: Build and test infrastructure for MLflowarea/docs
: MLflow documentation pagesarea/examples
: Example codearea/model-registry
: Model Registry service, APIs, and the fluent client calls for Model Registryarea/models
: MLmodel format, model serialization/deserialization, flavorsarea/pipelines
: Pipelines, Pipeline APIs, Pipeline configs, Pipeline Templatesarea/projects
: MLproject format, project running backendsarea/scoring
: MLflow Model server, model deployment tools, Spark UDFsarea/server-infra
: MLflow Tracking server backendarea/tracking
: Tracking Service, tracking client APIs, autologgingInterface
area/uiux
: Front-end, user experience, plotting, JavaScript, JavaScript dev serverarea/docker
: Docker use across MLflow's components, such as MLflow Projects and MLflow Modelsarea/sqlalchemy
: Use of SQLAlchemy in the Tracking Service or Model Registryarea/windows
: Windows supportLanguage
language/r
: R APIs and clientslanguage/java
: Java APIs and clientslanguage/new
: Proposals for new client languagesIntegrations
integrations/azure
: Azure and Azure ML integrationsintegrations/sagemaker
: SageMaker integrationsintegrations/databricks
: Databricks integrationsHow should the PR be classified in the release notes? Choose one:
rn/breaking-change
- The PR will be mentioned in the "Breaking Changes" sectionrn/none
- No description will be included. The PR will be mentioned only by the PR number in the "Small Bugfixes and Documentation Updates" sectionrn/feature
- A new user-facing feature worth mentioning in the release notesrn/bug-fix
- A user-facing bug fix worth mentioning in the release notesrn/documentation
- A user-facing documentation change worth mentioning in the release notes