Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate mlflow.sagemaker.deploy() & mlflow.sagemaker.delete() #6651

Merged
merged 4 commits into from
Sep 1, 2022

Conversation

dbczumar
Copy link
Collaborator

Signed-off-by: dbczumar corey.zumar@databricks.com

What changes are proposed in this pull request?

Deprecate mlflow.sagemaker.deploy() & mlflow.sagemaker.delete() in favor of methods defined on mlflow.deployments.get_deployment_client('sagemaker') (SageMakerDeploymentClient)

How is this patch tested?

Existing tests

Does this PR change the documentation?

  • No. You can skip the rest of this section.
  • Yes. Make sure the changed pages / sections render correctly by following the steps below.
  1. Click the Details link on the Preview docs check.
  2. Find the changed pages / sections and make sure they render correctly.

Release Notes

Deprecate mlflow.sagemaker.deploy() & mlflow.sagemaker.delete() in favor of methods defined on mlflow.deployments.get_deployment_client('sagemaker') (SageMakerDeploymentClient)

Is this a user-facing change?

  • No. You can skip the rest of this section.
  • Yes. Give a description of this change to be included in the release notes for MLflow users.

What component(s), interfaces, languages, and integrations does this PR affect?

Components

  • area/artifacts: Artifact stores and artifact logging
  • area/build: Build and test infrastructure for MLflow
  • area/docs: MLflow documentation pages
  • area/examples: Example code
  • area/model-registry: Model Registry service, APIs, and the fluent client calls for Model Registry
  • area/models: MLmodel format, model serialization/deserialization, flavors
  • area/pipelines: Pipelines, Pipeline APIs, Pipeline configs, Pipeline Templates
  • area/projects: MLproject format, project running backends
  • area/scoring: MLflow Model server, model deployment tools, Spark UDFs
  • area/server-infra: MLflow Tracking server backend
  • area/tracking: Tracking Service, tracking client APIs, autologging

Interface

  • area/uiux: Front-end, user experience, plotting, JavaScript, JavaScript dev server
  • area/docker: Docker use across MLflow's components, such as MLflow Projects and MLflow Models
  • area/sqlalchemy: Use of SQLAlchemy in the Tracking Service or Model Registry
  • area/windows: Windows support

Language

  • language/r: R APIs and clients
  • language/java: Java APIs and clients
  • language/new: Proposals for new client languages

Integrations

  • integrations/azure: Azure and Azure ML integrations
  • integrations/sagemaker: SageMaker integrations
  • integrations/databricks: Databricks integrations

How should the PR be classified in the release notes? Choose one:

  • rn/breaking-change - The PR will be mentioned in the "Breaking Changes" section
  • rn/none - No description will be included. The PR will be mentioned only by the PR number in the "Small Bugfixes and Documentation Updates" section
  • rn/feature - A new user-facing feature worth mentioning in the release notes
  • rn/bug-fix - A user-facing bug fix worth mentioning in the release notes
  • rn/documentation - A user-facing documentation change worth mentioning in the release notes

Signed-off-by: dbczumar <corey.zumar@databricks.com>
Signed-off-by: dbczumar <corey.zumar@databricks.com>
@github-actions github-actions bot added area/docs Documentation issues area/scoring MLflow Model server, model deployment tools, Spark UDFs rn/documentation Mention under Documentation Changes in Changelogs. labels Aug 30, 2022
Copy link
Member

@harupy harupy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Signed-off-by: dbczumar <corey.zumar@databricks.com>
Signed-off-by: dbczumar <corey.zumar@databricks.com>
@dbczumar dbczumar merged commit 035ad9b into mlflow:master Sep 1, 2022
prithvikannan pushed a commit to prithvikannan/mlflow that referenced this pull request Sep 6, 2022
…ow#6651)

* Deprecations

Signed-off-by: dbczumar <corey.zumar@databricks.com>

* MLP revert

Signed-off-by: dbczumar <corey.zumar@databricks.com>

* docs

Signed-off-by: dbczumar <corey.zumar@databricks.com>

* Docs fixes

Signed-off-by: dbczumar <corey.zumar@databricks.com>

Signed-off-by: dbczumar <corey.zumar@databricks.com>
Signed-off-by: Prithvi Kannan <prithvi.kannan@databricks.com>
prithvikannan pushed a commit to prithvikannan/mlflow that referenced this pull request Sep 7, 2022
…ow#6651)

* Deprecations

Signed-off-by: dbczumar <corey.zumar@databricks.com>

* MLP revert

Signed-off-by: dbczumar <corey.zumar@databricks.com>

* docs

Signed-off-by: dbczumar <corey.zumar@databricks.com>

* Docs fixes

Signed-off-by: dbczumar <corey.zumar@databricks.com>

Signed-off-by: dbczumar <corey.zumar@databricks.com>
Signed-off-by: Prithvi Kannan <prithvi.kannan@databricks.com>
nnethery pushed a commit to nnethery/mlflow that referenced this pull request Feb 1, 2024
…ow#6651)

* Deprecations

Signed-off-by: dbczumar <corey.zumar@databricks.com>

* MLP revert

Signed-off-by: dbczumar <corey.zumar@databricks.com>

* docs

Signed-off-by: dbczumar <corey.zumar@databricks.com>

* Docs fixes

Signed-off-by: dbczumar <corey.zumar@databricks.com>

Signed-off-by: dbczumar <corey.zumar@databricks.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/docs Documentation issues area/scoring MLflow Model server, model deployment tools, Spark UDFs rn/documentation Mention under Documentation Changes in Changelogs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants