Remove unnecessary if condition in autoformat workflow #6653
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harupy
commented
Aug 30, 2022
| @@ -30,7 +30,6 @@ jobs: | |||
| return context.payload.comment.body.trim() === 'autoformat'; | |||
| - name: Create status | |||
| id: create-status | |||
| if: ${{ steps.check-comment.outputs.result == 'true' }} | |||
There was a problem hiding this comment.
The output of this job (check-comment) depends on the output of this step. If this step is skipped, fromJson at line 18 throws an error:
https://github.com/mlflow/mlflow/actions/runs/2955848476
The template is not valid. .github/workflows/autoformat.yml (Line: 18, Col: 19): Error reading JToken from JsonReader. Path '', line 0, position 0.,.github/workflows/autoformat.yml (Line: 19, Col: 12): Error reading JToken from JsonReader. Path '', line 0, position 0.,.github/workflows/autoformat.yml (Line: 20, Col: 12): Error reading JToken from JsonReader. Path '', line 0, position 0.,.github/workflows/autoformat.yml (Line: 21, Col: 20): Error reading JToken from JsonReader. Path '', line 0, position 0.
There was a problem hiding this comment.
It's should be fine to always run this step.
github-actions
bot
added
area/build
harupy
force-pushed
the
remove-if-autoformat
branch
from
f4d21de
to
ac2d9e3
Compare
harupy
force-pushed
the
remove-if-autoformat
branch
from
ac2d9e3
to
33a88c6
Compare
Signed-off-by: harupy <hkawamura0130@gmail.com>
Signed-off-by: harupy <hkawamura0130@gmail.com>
prithvikannan
pushed a commit
to prithvikannan/mlflow
that referenced
this pull request
Sep 6, 2022
* fix Signed-off-by: harupy <hkawamura0130@gmail.com> * fix Signed-off-by: harupy <hkawamura0130@gmail.com> * pass context and github to getPullInformation Signed-off-by: harupy <hkawamura0130@gmail.com> * document how to test this workflow Signed-off-by: harupy <hkawamura0130@gmail.com> Signed-off-by: harupy <hkawamura0130@gmail.com> Signed-off-by: Prithvi Kannan <prithvi.kannan@databricks.com>
prithvikannan
pushed a commit
to prithvikannan/mlflow
that referenced
this pull request
Sep 7, 2022
* fix Signed-off-by: harupy <hkawamura0130@gmail.com> * fix Signed-off-by: harupy <hkawamura0130@gmail.com> * pass context and github to getPullInformation Signed-off-by: harupy <hkawamura0130@gmail.com> * document how to test this workflow Signed-off-by: harupy <hkawamura0130@gmail.com> Signed-off-by: harupy <hkawamura0130@gmail.com> Signed-off-by: Prithvi Kannan <prithvi.kannan@databricks.com>
nnethery
pushed a commit
to nnethery/mlflow
that referenced
this pull request
Feb 1, 2024
* fix Signed-off-by: harupy <hkawamura0130@gmail.com> * fix Signed-off-by: harupy <hkawamura0130@gmail.com> * pass context and github to getPullInformation Signed-off-by: harupy <hkawamura0130@gmail.com> * document how to test this workflow Signed-off-by: harupy <hkawamura0130@gmail.com> Signed-off-by: harupy <hkawamura0130@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: harupy hkawamura0130@gmail.com
Related Issues/PRs
#xxx
What changes are proposed in this pull request?
Remove an unnecessary if condition in the autoformat workflow.
How is this patch tested?
Does this PR change the documentation?
Detailslink on thePreview docscheck.Release Notes
Is this a user-facing change?
(Details in 1-2 sentences. You can just refer to another PR with a description if this PR is part of a larger change.)
What component(s), interfaces, languages, and integrations does this PR affect?
Components
area/artifacts: Artifact stores and artifact loggingarea/build: Build and test infrastructure for MLflowarea/docs: MLflow documentation pagesarea/examples: Example codearea/model-registry: Model Registry service, APIs, and the fluent client calls for Model Registryarea/models: MLmodel format, model serialization/deserialization, flavorsarea/pipelines: Pipelines, Pipeline APIs, Pipeline configs, Pipeline Templatesarea/projects: MLproject format, project running backendsarea/scoring: MLflow Model server, model deployment tools, Spark UDFsarea/server-infra: MLflow Tracking server backendarea/tracking: Tracking Service, tracking client APIs, autologgingInterface
area/uiux: Front-end, user experience, plotting, JavaScript, JavaScript dev serverarea/docker: Docker use across MLflow's components, such as MLflow Projects and MLflow Modelsarea/sqlalchemy: Use of SQLAlchemy in the Tracking Service or Model Registryarea/windows: Windows supportLanguage
language/r: R APIs and clientslanguage/java: Java APIs and clientslanguage/new: Proposals for new client languagesIntegrations
integrations/azure: Azure and Azure ML integrationsintegrations/sagemaker: SageMaker integrationsintegrations/databricks: Databricks integrationsHow should the PR be classified in the release notes? Choose one:
rn/breaking-change- The PR will be mentioned in the "Breaking Changes" sectionrn/none- No description will be included. The PR will be mentioned only by the PR number in the "Small Bugfixes and Documentation Updates" sectionrn/feature- A new user-facing feature worth mentioning in the release notesrn/bug-fix- A user-facing bug fix worth mentioning in the release notesrn/documentation- A user-facing documentation change worth mentioning in the release notes