Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug in MLP evaluation step in which list is accessed as if it were a dictionary #6661

Merged
merged 1 commit into from
Aug 31, 2022

Conversation

bbarnes52
Copy link
Collaborator

@bbarnes52 bbarnes52 commented Aug 31, 2022

Signed-off-by: Brian Barnes brian.barnes@databricks.com

What changes are proposed in this pull request?

This PR addresses a bug in the MLP evaluation step in which a list is indexed with a string value, leading to a runtime error. This bug would only manifest in the event of a programming error (or potentially a version mismatch) in which the client and server disagree on the set of values returned from mlflow.evaluate

How is this patch tested?

I encountered this error when using the log_loss metric which I expected to be returned from mlflow.evaluate for a classifier. I tested with this patch to ensure the desired error message is thrown.

Does this PR change the documentation?

  • No. You can skip the rest of this section.
  • Yes. Make sure the changed pages / sections render correctly by following the steps below.

Release Notes

Is this a user-facing change?

  • No. You can skip the rest of this section.
  • Yes. Give a description of this change to be included in the release notes for MLflow users.

(Details in 1-2 sentences. You can just refer to another PR with a description if this PR is part of a larger change.)

What component(s), interfaces, languages, and integrations does this PR affect?

Components

  • area/artifacts: Artifact stores and artifact logging
  • area/build: Build and test infrastructure for MLflow
  • area/docs: MLflow documentation pages
  • area/examples: Example code
  • area/model-registry: Model Registry service, APIs, and the fluent client calls for Model Registry
  • area/models: MLmodel format, model serialization/deserialization, flavors
  • area/pipelines: Pipelines, Pipeline APIs, Pipeline configs, Pipeline Templates
  • area/projects: MLproject format, project running backends
  • area/scoring: MLflow Model server, model deployment tools, Spark UDFs
  • area/server-infra: MLflow Tracking server backend
  • area/tracking: Tracking Service, tracking client APIs, autologging

Interface

  • area/uiux: Front-end, user experience, plotting, JavaScript, JavaScript dev server
  • area/docker: Docker use across MLflow's components, such as MLflow Projects and MLflow Models
  • area/sqlalchemy: Use of SQLAlchemy in the Tracking Service or Model Registry
  • area/windows: Windows support

Language

  • language/r: R APIs and clients
  • language/java: Java APIs and clients
  • language/new: Proposals for new client languages

Integrations

  • integrations/azure: Azure and Azure ML integrations
  • integrations/sagemaker: SageMaker integrations
  • integrations/databricks: Databricks integrations

How should the PR be classified in the release notes? Choose one:

  • rn/breaking-change - The PR will be mentioned in the "Breaking Changes" section
  • rn/none - No description will be included. The PR will be mentioned only by the PR number in the "Small Bugfixes and Documentation Updates" section
  • rn/feature - A new user-facing feature worth mentioning in the release notes
  • rn/bug-fix - A user-facing bug fix worth mentioning in the release notes
  • rn/documentation - A user-facing documentation change worth mentioning in the release notes

@bbarnes52 bbarnes52 marked this pull request as ready for review August 31, 2022 21:02
@github-actions github-actions bot added area/recipes MLflow Recipes, Recipes APIs, Recipes configs, Recipe Templates rn/none List under Small Changes in Changelogs. labels Aug 31, 2022
summary[metric_name] = False
continue
raise MlflowException(
f"The metric {metric_name} was not returned from mlflow evaluation.",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we specify that this metric was defined as part of the validation criteria for evaluation? This will add some extra context to the error

Copy link
Collaborator

@dbczumar dbczumar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with one tiny comment. Thanks @bbarnes52 !

Signed-off-by: Brian Barnes <brian.barnes@databricks.com>
@bbarnes52 bbarnes52 merged commit 2699e78 into mlflow:master Aug 31, 2022
prithvikannan pushed a commit to prithvikannan/mlflow that referenced this pull request Sep 6, 2022
Signed-off-by: Brian Barnes <brian.barnes@databricks.com>

Signed-off-by: Brian Barnes <brian.barnes@databricks.com>
Signed-off-by: Prithvi Kannan <prithvi.kannan@databricks.com>
prithvikannan pushed a commit to prithvikannan/mlflow that referenced this pull request Sep 7, 2022
Signed-off-by: Brian Barnes <brian.barnes@databricks.com>

Signed-off-by: Brian Barnes <brian.barnes@databricks.com>
Signed-off-by: Prithvi Kannan <prithvi.kannan@databricks.com>
nnethery pushed a commit to nnethery/mlflow that referenced this pull request Feb 1, 2024
Signed-off-by: Brian Barnes <brian.barnes@databricks.com>

Signed-off-by: Brian Barnes <brian.barnes@databricks.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/recipes MLflow Recipes, Recipes APIs, Recipes configs, Recipe Templates rn/none List under Small Changes in Changelogs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants