-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix bug in MLP evaluation step in which list is accessed as if it were a dictionary #6661
Conversation
mlflow/pipelines/steps/evaluate.py
Outdated
summary[metric_name] = False | ||
continue | ||
raise MlflowException( | ||
f"The metric {metric_name} was not returned from mlflow evaluation.", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we specify that this metric was defined as part of the validation criteria for evaluation? This will add some extra context to the error
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with one tiny comment. Thanks @bbarnes52 !
Signed-off-by: Brian Barnes <brian.barnes@databricks.com>
Signed-off-by: Brian Barnes <brian.barnes@databricks.com> Signed-off-by: Brian Barnes <brian.barnes@databricks.com> Signed-off-by: Prithvi Kannan <prithvi.kannan@databricks.com>
Signed-off-by: Brian Barnes <brian.barnes@databricks.com> Signed-off-by: Brian Barnes <brian.barnes@databricks.com> Signed-off-by: Prithvi Kannan <prithvi.kannan@databricks.com>
Signed-off-by: Brian Barnes <brian.barnes@databricks.com> Signed-off-by: Brian Barnes <brian.barnes@databricks.com>
Signed-off-by: Brian Barnes brian.barnes@databricks.com
What changes are proposed in this pull request?
This PR addresses a bug in the MLP evaluation step in which a list is indexed with a string value, leading to a runtime error. This bug would only manifest in the event of a programming error (or potentially a version mismatch) in which the client and server disagree on the set of values returned from mlflow.evaluate
How is this patch tested?
I encountered this error when using the
log_loss
metric which I expected to be returned frommlflow.evaluate
for a classifier. I tested with this patch to ensure the desired error message is thrown.Does this PR change the documentation?
Release Notes
Is this a user-facing change?
(Details in 1-2 sentences. You can just refer to another PR with a description if this PR is part of a larger change.)
What component(s), interfaces, languages, and integrations does this PR affect?
Components
area/artifacts
: Artifact stores and artifact loggingarea/build
: Build and test infrastructure for MLflowarea/docs
: MLflow documentation pagesarea/examples
: Example codearea/model-registry
: Model Registry service, APIs, and the fluent client calls for Model Registryarea/models
: MLmodel format, model serialization/deserialization, flavorsarea/pipelines
: Pipelines, Pipeline APIs, Pipeline configs, Pipeline Templatesarea/projects
: MLproject format, project running backendsarea/scoring
: MLflow Model server, model deployment tools, Spark UDFsarea/server-infra
: MLflow Tracking server backendarea/tracking
: Tracking Service, tracking client APIs, autologgingInterface
area/uiux
: Front-end, user experience, plotting, JavaScript, JavaScript dev serverarea/docker
: Docker use across MLflow's components, such as MLflow Projects and MLflow Modelsarea/sqlalchemy
: Use of SQLAlchemy in the Tracking Service or Model Registryarea/windows
: Windows supportLanguage
language/r
: R APIs and clientslanguage/java
: Java APIs and clientslanguage/new
: Proposals for new client languagesIntegrations
integrations/azure
: Azure and Azure ML integrationsintegrations/sagemaker
: SageMaker integrationsintegrations/databricks
: Databricks integrationsHow should the PR be classified in the release notes? Choose one:
rn/breaking-change
- The PR will be mentioned in the "Breaking Changes" sectionrn/none
- No description will be included. The PR will be mentioned only by the PR number in the "Small Bugfixes and Documentation Updates" sectionrn/feature
- A new user-facing feature worth mentioning in the release notesrn/bug-fix
- A user-facing bug fix worth mentioning in the release notesrn/documentation
- A user-facing documentation change worth mentioning in the release notes