Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove duplicate _SPARK_MODEL_PATH_SUB #6683

Merged
merged 2 commits into from
Sep 8, 2022
Merged

Remove duplicate _SPARK_MODEL_PATH_SUB #6683

merged 2 commits into from
Sep 8, 2022

Conversation

gwy1995
Copy link
Contributor

@gwy1995 gwy1995 commented Sep 2, 2022

Signed-off-by: zero 164434719@qq.com

Related Issues/PRs

Fix #6682

What changes are proposed in this pull request?

Remove duplicate _SPARK_MODEL_PATH_SUB in mlflow.spark.log_model

Does this PR change the documentation?

  • No. You can skip the rest of this section.

@gwy1995
mlflow#6682 Remove duplicate _SPARK_MODEL_PATH_SUB
98d208d 
Signed-off-by: zero <164434719@qq.com>
bbarnes52
bbarnes52 approved these changes Sep 2, 2022
View reviewed changes
Copy link
Collaborator

@bbarnes52 bbarnes52 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @gwy1995 !

@dbczumar
Copy link
Collaborator

dbczumar commented Sep 2, 2022

@bbarnes52 @gwy1995 Looks like a number of Spark tests fail with this change. Can we confirm whether this is a test-only issue (i.e. the tests' expectations are incorrect) or a problematic change in behavior?

@gwy1995
update tests expectations
4efa566 
 The tests' expectations are incorrect due to duplicate _SPARK_MODEL_PATH_SUB mlflow#6683

Signed-off-by: zero <164434719@qq.com>
@gwy1995
Copy link
Contributor Author

gwy1995 commented Sep 7, 2022

@dbczumar I think the tests' expectations are incorrect. I have a new commit on them.

@BenWilson2 BenWilson2 added rn/breaking-change Mention under Breaking Changes in Changelogs. rn/bug-fix Mention under Bug Fixes in Changelogs. and removed rn/breaking-change Mention under Breaking Changes in Changelogs. labels Sep 7, 2022
@dbczumar
Copy link
Collaborator

dbczumar commented Sep 8, 2022

Thanks @gwy1995

@bbarnes52 Can you take a look and also verify that this duplicate path was introduced in MLflow 1.28.0 and wasn't present before? @BenWilson2 flagged that we should be particularly careful about backwards compatibility here - if 1.28.0 introduced a regression, we should absolutely fix it. If this duplicate path component has been around for a long time, we should maintain backwards compatibility.

@dbczumar
Copy link
Collaborator

dbczumar commented Sep 8, 2022

Confirmed offline with @bbarnes52 that this is indeed a regression in MLflow 1.28.0. Merging! cc @BenWilson2

@dbczumar dbczumar merged commit eb69336 into mlflow:master Sep 8, 2022
@BenWilson2 BenWilson2 mentioned this pull request Sep 23, 2022
Closed
21 tasks
nnethery pushed a commit to nnethery/mlflow that referenced this pull request Feb 1, 2024
@gwy1995 @nnethery
Remove duplicate _SPARK_MODEL_PATH_SUB (mlflow#6683)
d163378 
* mlflow#6682 Remove duplicate `_SPARK_MODEL_PATH_SUB`

Signed-off-by: zero <164434719@qq.com>

* update tests expectations

 The tests' expectations are incorrect due to duplicate _SPARK_MODEL_PATH_SUB mlflow#6683

Signed-off-by: zero <164434719@qq.com>

Signed-off-by: zero <164434719@qq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bbarnes52 bbarnes52 bbarnes52 approved these changes

Assignees
No one assigned
Labels
rn/bug-fix Mention under Bug Fixes in Changelogs.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] Duplicate _SPARK_MODEL_PATH_SUB in mlflow.spark.log_model
4 participants
@gwy1995 @dbczumar @bbarnes52 @BenWilson2