Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change base image to python:3.7 in Dockerfile #6699

Merged
merged 8 commits into from
Sep 6, 2022

Conversation

harupy
Copy link
Member

@harupy harupy commented Sep 5, 2022

Signed-off-by: harupy hkawamura0130@gmail.com

Related Issues/PRs

#xxx

What changes are proposed in this pull request?

Avoid using condaforge/miniforge3 as a base environment in Dockerfile to fix the following error:

https://github.com/mlflow/mlflow/runs/8189395961?check_suite_focus=true

Traceback (most recent call last):
  File "/opt/conda/lib/python3.10/site-packages/conda/exceptions.py", line 1125, in __call__
  File "/opt/conda/lib/python3.10/site-packages/conda/cli/main.py", line 86, in main_subshell
  File "/opt/conda/lib/python3.10/site-packages/conda/cli/conda_argparse.py", line 93, in do_call
  File "/opt/conda/lib/python3.10/site-packages/conda/notices/core.py", line 75, in wrapper
  File "/opt/conda/lib/python3.10/site-packages/conda/notices/core.py", line 39, in display_notices
  File "/opt/conda/lib/python3.10/site-packages/conda/notices/http.py", line 36, in get_notice_responses
  File "/opt/conda/lib/python3.10/site-packages/conda/notices/http.py", line 39, in <genexpr>
  File "/opt/conda/lib/python3.10/concurrent/futures/_base.py", line 621, in result_iterator
  File "/opt/conda/lib/python3.10/concurrent/futures/_base.py", line 319, in _result_or_cancel
  File "/opt/conda/lib/python3.10/concurrent/futures/_base.py", line 458, in result
  File "/opt/conda/lib/python3.10/concurrent/futures/_base.py", line 403, in __get_result
  File "/opt/conda/lib/python3.10/concurrent/futures/thread.py", line 58, in run
  File "/opt/conda/lib/python3.10/site-packages/conda/notices/http.py", line 42, in <lambda>
  File "/opt/conda/lib/python3.10/site-packages/conda/notices/cache.py", line 37, in wrapper
  File "/opt/conda/lib/python3.10/site-packages/conda/notices/http.py", line 58, in get_channel_notice_response
  File "/opt/conda/lib/python3.10/site-packages/requests/sessions.py", line 600, in get
  File "/opt/conda/lib/python3.10/site-packages/requests/sessions.py", line 587, in request
  File "/opt/conda/lib/python3.10/site-packages/requests/sessions.py", line 701, in send
  File "/opt/conda/lib/python3.10/site-packages/requests/adapters.py", line 460, in send
  File "/opt/conda/lib/python3.10/site-packages/requests/adapters.py", line 263, in cert_verify
OSError: Could not find a suitable TLS CA certificate bundle, invalid path: /opt/conda/lib/python3.10/site-packages/certifi/cacert.pem

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/opt/conda/bin/conda", line 13, in <module>
    sys.exit(main())
  File "/opt/conda/lib/python3.10/site-packages/conda/cli/main.py", line 129, in main
  File "/opt/conda/lib/python3.10/site-packages/conda/exceptions.py", line 1413, in conda_exception_handler
  File "/opt/conda/lib/python3.10/site-packages/conda/exceptions.py", line 1128, in __call__
  File "/opt/conda/lib/python3.10/site-packages/conda/exceptions.py", line 1170, in handle_exception
  File "/opt/conda/lib/python3.10/site-packages/conda/exceptions.py", line 1181, in handle_unexpected_exception
  File "/opt/conda/lib/python3.10/site-packages/conda/exceptions.py", line 1251, in print_unexpected_error_report
ModuleNotFoundError: No module named 'conda.cli.main_info'

conda-forge/miniforge#341 reports the same error.

In conda-forge/miniforge#341 (comment), a miniforge maintainer says:

Why do you need to change the base environment. This isn't supported.

How is this patch tested?

  • I have written tests (not required for typo or doc fix) and confirmed the proposed feature/bug-fix/change works.

Does this PR change the documentation?

  • No. You can skip the rest of this section.
  • Yes. Make sure the changed pages / sections render correctly by following the steps below.
  1. Click the Details link on the Preview docs check.
  2. Find the changed pages / sections and make sure they render correctly.

Release Notes

Is this a user-facing change?

  • No. You can skip the rest of this section.
  • Yes. Give a description of this change to be included in the release notes for MLflow users.

(Details in 1-2 sentences. You can just refer to another PR with a description if this PR is part of a larger change.)

What component(s), interfaces, languages, and integrations does this PR affect?

Components

  • area/artifacts: Artifact stores and artifact logging
  • area/build: Build and test infrastructure for MLflow
  • area/docs: MLflow documentation pages
  • area/examples: Example code
  • area/model-registry: Model Registry service, APIs, and the fluent client calls for Model Registry
  • area/models: MLmodel format, model serialization/deserialization, flavors
  • area/pipelines: Pipelines, Pipeline APIs, Pipeline configs, Pipeline Templates
  • area/projects: MLproject format, project running backends
  • area/scoring: MLflow Model server, model deployment tools, Spark UDFs
  • area/server-infra: MLflow Tracking server backend
  • area/tracking: Tracking Service, tracking client APIs, autologging

Interface

  • area/uiux: Front-end, user experience, plotting, JavaScript, JavaScript dev server
  • area/docker: Docker use across MLflow's components, such as MLflow Projects and MLflow Models
  • area/sqlalchemy: Use of SQLAlchemy in the Tracking Service or Model Registry
  • area/windows: Windows support

Language

  • language/r: R APIs and clients
  • language/java: Java APIs and clients
  • language/new: Proposals for new client languages

Integrations

  • integrations/azure: Azure and Azure ML integrations
  • integrations/sagemaker: SageMaker integrations
  • integrations/databricks: Databricks integrations

How should the PR be classified in the release notes? Choose one:

  • rn/breaking-change - The PR will be mentioned in the "Breaking Changes" section
  • rn/none - No description will be included. The PR will be mentioned only by the PR number in the "Small Bugfixes and Documentation Updates" section
  • rn/feature - A new user-facing feature worth mentioning in the release notes
  • rn/bug-fix - A user-facing bug fix worth mentioning in the release notes
  • rn/documentation - A user-facing documentation change worth mentioning in the release notes

Signed-off-by: harupy <hkawamura0130@gmail.com>
Signed-off-by: harupy <hkawamura0130@gmail.com>
Signed-off-by: harupy <hkawamura0130@gmail.com>
@github-actions github-actions bot added the rn/none List under Small Changes in Changelogs. label Sep 5, 2022
Signed-off-by: harupy <hkawamura0130@gmail.com>
Signed-off-by: harupy <hkawamura0130@gmail.com>
@harupy harupy changed the title Avoid changing the base environment in Dockerfile Change base image to python:3.7 in Dockerfile Sep 5, 2022
Signed-off-by: harupy <hkawamura0130@gmail.com>
Signed-off-by: harupy <hkawamura0130@gmail.com>
Copy link
Collaborator

@WeichenXu123 WeichenXu123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Signed-off-by: harupy <hkawamura0130@gmail.com>
@harupy harupy merged commit 78d7504 into mlflow:master Sep 6, 2022
@harupy harupy mentioned this pull request Sep 6, 2022
31 tasks
prithvikannan pushed a commit to prithvikannan/mlflow that referenced this pull request Sep 6, 2022
* Avoid changing the base environment

Signed-off-by: harupy <hkawamura0130@gmail.com>

* fix

Signed-off-by: harupy <hkawamura0130@gmail.com>

* use conda run

Signed-off-by: harupy <hkawamura0130@gmail.com>

* use python:3.7

Signed-off-by: harupy <hkawamura0130@gmail.com>

* use python:3.7

Signed-off-by: harupy <hkawamura0130@gmail.com>

* update dev/Dockerfile.test

Signed-off-by: harupy <hkawamura0130@gmail.com>

* use python:3.7

Signed-off-by: harupy <hkawamura0130@gmail.com>

* set CMD

Signed-off-by: harupy <hkawamura0130@gmail.com>

Signed-off-by: harupy <hkawamura0130@gmail.com>
Signed-off-by: Prithvi Kannan <prithvi.kannan@databricks.com>
prithvikannan pushed a commit to prithvikannan/mlflow that referenced this pull request Sep 7, 2022
* Avoid changing the base environment

Signed-off-by: harupy <hkawamura0130@gmail.com>

* fix

Signed-off-by: harupy <hkawamura0130@gmail.com>

* use conda run

Signed-off-by: harupy <hkawamura0130@gmail.com>

* use python:3.7

Signed-off-by: harupy <hkawamura0130@gmail.com>

* use python:3.7

Signed-off-by: harupy <hkawamura0130@gmail.com>

* update dev/Dockerfile.test

Signed-off-by: harupy <hkawamura0130@gmail.com>

* use python:3.7

Signed-off-by: harupy <hkawamura0130@gmail.com>

* set CMD

Signed-off-by: harupy <hkawamura0130@gmail.com>

Signed-off-by: harupy <hkawamura0130@gmail.com>
Signed-off-by: Prithvi Kannan <prithvi.kannan@databricks.com>
nnethery pushed a commit to nnethery/mlflow that referenced this pull request Feb 1, 2024
* Avoid changing the base environment

Signed-off-by: harupy <hkawamura0130@gmail.com>

* fix

Signed-off-by: harupy <hkawamura0130@gmail.com>

* use conda run

Signed-off-by: harupy <hkawamura0130@gmail.com>

* use python:3.7

Signed-off-by: harupy <hkawamura0130@gmail.com>

* use python:3.7

Signed-off-by: harupy <hkawamura0130@gmail.com>

* update dev/Dockerfile.test

Signed-off-by: harupy <hkawamura0130@gmail.com>

* use python:3.7

Signed-off-by: harupy <hkawamura0130@gmail.com>

* set CMD

Signed-off-by: harupy <hkawamura0130@gmail.com>

Signed-off-by: harupy <hkawamura0130@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rn/none List under Small Changes in Changelogs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants