Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tracking server image #6731

Merged
merged 6 commits into from
Sep 13, 2022
Merged

Tracking server image #6731

merged 6 commits into from
Sep 13, 2022

Conversation

oojo12
Copy link
Contributor

@oojo12 oojo12 commented Sep 8, 2022

Related Issues/PRs

#6093

What changes are proposed in this pull request?

This PR introduces a minimal Dockerfile for the MlFLow tracking server as well as a docker compose file that can be invoked for building and pushing all MlFlow docker images.

How is this patch tested?

Requires maintainer testing to ensure the associated workflow PR that goes along with this properly automatically tags and pushes the image to GitHub container registry.

Does this PR change the documentation?

  • No. You can skip the rest of this section.

Release Notes

Is this a user-facing change?

  • [X ] Yes. Give a description of this change to be included in the release notes for MLflow users.

Introduction of Docker image for the MlFlow tracking server.

What component(s), interfaces, languages, and integrations does this PR affect?

Components

  • area/build: Build and test infrastructure for MLflow

Interface

  • area/docker: Docker use across MLflow's components, such as MLflow Projects and MLflow Models

How should the PR be classified in the release notes? Choose one:

  • rn/feature - A new user-facing feature worth mentioning in the release notes

@github-actions github-actions bot added area/build Build and test infrastructure for MLflow area/docker Docker use anywhere, such as MLprojects and MLmodels rn/feature Mention under Features in Changelogs. labels Sep 8, 2022
mlflow/tracking/Dockerfile Outdated Show resolved Hide resolved
mlflow/tracking/Dockerfile Outdated Show resolved Hide resolved
mlflow/tracking/Dockerfile Outdated Show resolved Hide resolved
mlflow/docker-compose.yml Outdated Show resolved Hide resolved
@oojo12 oojo12 mentioned this pull request Sep 8, 2022
5 tasks
mlflow/tracking/Dockerfile Outdated Show resolved Hide resolved
@oojo12 oojo12 requested a review from harupy September 10, 2022 16:46
Comment on lines 1 to 7
version: "3.9" # optional since v1.27.0
services:
tracking:
build: .
args:
VERSION: ${GITHUB_REF_NAME}
entrypoint: ["mlflow", "server"]
Copy link
Member

@harupy harupy Sep 12, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this file used in the workflow added in #6735 #6732?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you mean #6732? No, it isn't and has been deleted.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, #6732

@harupy
Copy link
Member

harupy commented Sep 13, 2022

@oojo12 Thanks for the update! Can you fix the DCO check failure?

oojo12 and others added 6 commits September 13, 2022 10:46
Signed-off-by: Femi <47154698+oojo12@users.noreply.github.com>
Signed-off-by: Femi Oho <47154698+oojo12@users.noreply.github.com>
Signed-off-by: Femi <47154698+oojo12@users.noreply.github.com>
Signed-off-by: Femi Oho <47154698+oojo12@users.noreply.github.com>
Signed-off-by: Femi <47154698+oojo12@users.noreply.github.com>
Signed-off-by: Femi Oho <47154698+oojo12@users.noreply.github.com>
Signed-off-by: Femi Oho <47154698+oojo12@users.noreply.github.com>
Signed-off-by: Femi <47154698+oojo12@users.noreply.github.com>
Signed-off-by: Femi Oho <47154698+oojo12@users.noreply.github.com>
Signed-off-by: Femi <47154698+oojo12@users.noreply.github.com>
Signed-off-by: Femi Oho <47154698+oojo12@users.noreply.github.com>
@oojo12
Copy link
Contributor Author

oojo12 commented Sep 13, 2022

@harupy DCO failure resolved.

Copy link
Member

@harupy harupy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@@ -0,0 +1,3 @@
FROM python:3.10.6-slim-bullseye
ARG VERSION
RUN pip install --no-cache mlflow==$VERSION
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It complains about not having psycopg2 installed when using with postgres

Copy link
Contributor Author

@oojo12 oojo12 Oct 21, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Rusteam can you create an issue with a reproducible example, since this PR has already been merged? With the reproducible example I can identify and rectify any missing dependencies.

@harupy do you think it is better to add this to the requirements.txt for mlflow?

nnethery pushed a commit to nnethery/mlflow that referenced this pull request Feb 1, 2024
* Create docker-compose.yml

Signed-off-by: Femi <47154698+oojo12@users.noreply.github.com>
Signed-off-by: Femi Oho <47154698+oojo12@users.noreply.github.com>

* Create Dockerfile

Signed-off-by: Femi <47154698+oojo12@users.noreply.github.com>
Signed-off-by: Femi Oho <47154698+oojo12@users.noreply.github.com>

* pip install from Pypi

Signed-off-by: Femi <47154698+oojo12@users.noreply.github.com>
Signed-off-by: Femi Oho <47154698+oojo12@users.noreply.github.com>

* organized docker folder

Signed-off-by: Femi Oho <47154698+oojo12@users.noreply.github.com>

* remove unnecessary comment

Signed-off-by: Femi <47154698+oojo12@users.noreply.github.com>
Signed-off-by: Femi Oho <47154698+oojo12@users.noreply.github.com>

* Delete docker-compose.yml

Signed-off-by: Femi <47154698+oojo12@users.noreply.github.com>
Signed-off-by: Femi Oho <47154698+oojo12@users.noreply.github.com>

Signed-off-by: Femi <47154698+oojo12@users.noreply.github.com>
Signed-off-by: Femi Oho <47154698+oojo12@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/build Build and test infrastructure for MLflow area/docker Docker use anywhere, such as MLprojects and MLmodels rn/feature Mention under Features in Changelogs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants