Use mslex.quote when shell-escaping strings
#6745
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: harupy <hkawamura0130@gmail.com>
github-actions
bot
added
area/projects
21 tasks
Signed-off-by: harupy <hkawamura0130@gmail.com>
dbczumar
reviewed
Sep 13, 2022
dbczumar
approved these changes
Sep 13, 2022
There was a problem hiding this comment.
LGTM with one comment - https://github.com/mlflow/mlflow/pull/6745/files#r969068670. Thanks @harupy !
Signed-off-by: harupy <hkawamura0130@gmail.com>
harupy
commented
Sep 13, 2022
tests/utils/test_string_utils.py
Outdated
Comment on lines
35
to
38
| def test_mslex_quote(): | ||
| assert mslex_quote("abc") == "abc" | ||
| assert mslex_quote("a b c") == '"a b c"' | ||
| assert mslex_quote("C:\\file\\to\\file") == "C:\\file\\to\\file" |
There was a problem hiding this comment.
A minimum test to ensure C:\\file\\to\\file is not converted to 'C:\\file\\to\\file'.
Signed-off-by: harupy <hkawamura0130@gmail.com>
Signed-off-by: harupy <hkawamura0130@gmail.com>
nnethery
pushed a commit
to nnethery/mlflow
that referenced
this pull request
Feb 1, 2024
* Use mslex.quote when shell-escaping strings Signed-off-by: harupy <hkawamura0130@gmail.com> * Add test for mslex_quote Signed-off-by: harupy <hkawamura0130@gmail.com> * Replace shlex_quote Signed-off-by: harupy <hkawamura0130@gmail.com> * string_utils Signed-off-by: harupy <hkawamura0130@gmail.com> * Fix test_mslex_quote Signed-off-by: harupy <hkawamura0130@gmail.com> Signed-off-by: harupy <hkawamura0130@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: harupy hkawamura0130@gmail.com
Related Issues/PRs
Fix #6585
What changes are proposed in this pull request?
Use
mslex.quote(https://github.com/smoofra/mslex) when shell-escaping strings.How is this patch tested?
Does this PR change the documentation?
Detailslink on thePreview docscheck.Release Notes
Is this a user-facing change?
(Details in 1-2 sentences. You can just refer to another PR with a description if this PR is part of a larger change.)
What component(s), interfaces, languages, and integrations does this PR affect?
Components
area/artifacts: Artifact stores and artifact loggingarea/build: Build and test infrastructure for MLflowarea/docs: MLflow documentation pagesarea/examples: Example codearea/model-registry: Model Registry service, APIs, and the fluent client calls for Model Registryarea/models: MLmodel format, model serialization/deserialization, flavorsarea/pipelines: Pipelines, Pipeline APIs, Pipeline configs, Pipeline Templatesarea/projects: MLproject format, project running backendsarea/scoring: MLflow Model server, model deployment tools, Spark UDFsarea/server-infra: MLflow Tracking server backendarea/tracking: Tracking Service, tracking client APIs, autologgingInterface
area/uiux: Front-end, user experience, plotting, JavaScript, JavaScript dev serverarea/docker: Docker use across MLflow's components, such as MLflow Projects and MLflow Modelsarea/sqlalchemy: Use of SQLAlchemy in the Tracking Service or Model Registryarea/windows: Windows supportLanguage
language/r: R APIs and clientslanguage/java: Java APIs and clientslanguage/new: Proposals for new client languagesIntegrations
integrations/azure: Azure and Azure ML integrationsintegrations/sagemaker: SageMaker integrationsintegrations/databricks: Databricks integrationsHow should the PR be classified in the release notes? Choose one:
rn/breaking-change- The PR will be mentioned in the "Breaking Changes" sectionrn/none- No description will be included. The PR will be mentioned only by the PR number in the "Small Bugfixes and Documentation Updates" sectionrn/feature- A new user-facing feature worth mentioning in the release notesrn/bug-fix- A user-facing bug fix worth mentioning in the release notesrn/documentation- A user-facing documentation change worth mentioning in the release notes